From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87FAF1D54FA for ; Sat, 30 May 2026 11:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780141450; cv=none; b=uyX1l3kMFFvY4CAuICbhgg97aZEHNXE8rpQn9Wi2BW+MfcMZp/onqzWsdiLtEwpzh5pj8CNx1KFe00YdLtwWBl/LVsPGM6i0ZHPhsluyJcd2rOBkcnAXZUfe1T7PS9C6auc1ntKoikSTC1asz8y6k/IOifFek9MfycwSi16oYM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780141450; c=relaxed/simple; bh=iCt4OBc2i4DWOwQ0gwQUwWndqI/atTQNSX8T2tkMTJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RfOiVoeyJQYas/omyj9ESUZ3bPmBDYcIWYw3RARxPV5Sm2KaESSHVbHxdA1ym9B48+YKi2Sgi2ffZBM1KGygZ8q/EOx989NqRQQcL1betxkSR2yAHt3hcprhu9JCK1XvzYN8msU8OZ6BdBVdlzh03NMlZBy76KhG0Hod8W3EQ3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bxoLHioh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bxoLHioh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 329A71F00893; Sat, 30 May 2026 11:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780141449; bh=hmxe6NjZFpeqGBUg1XP8AlDG9Z+iXwYzdjE8nlwrWxc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bxoLHiohgojsJ661NLlUSAi7BeJYSocM3uDFLWrUXjABRGGMReaN1A+7/v6hRH/lh UlzFFBZEwBh6WFIHdCLkX9OsmF3fVhj62/xmXX2EZvu+U2YAgG+rEBG/rFq5j0i31W 1PzdVhmw88dt6T3qJsps9KGzan1bFhIQCs6khb8ztV0glHreckWn5Qwxo0CYfshKu/ jTa4rex9A1Rj/ePPSkhd1rD1AQgg14N33h2vJJsq1P3483rCQVQYzQw/9/Ba/qP2CN 2vmvo57aChRVlSj7zEOUsnfTV7rlVofym/2NfL8wwTfVg1Y3n2p6C+EKrSjfD0zaBo eGCL6qnnbRbCA== From: Sasha Levin To: stable@vger.kernel.org Cc: Jose Ignacio Tornos Martinez , Jacob Keller , Michal Swiatkowski , Paul Menzel , Rafal Romanowski , Tony Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y] ice: fix VF queue configuration with low MTU values Date: Sat, 30 May 2026 07:44:06 -0400 Message-ID: <20260530114406.1959724-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026052806-proxy-busily-c19b@gregkh> References: <2026052806-proxy-busily-c19b@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jose Ignacio Tornos Martinez [ Upstream commit 3ba4dd024d26372733d1c02e13e076c6016e3320 ] The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes. The iavf driver calculates databuffer_size based on the MTU using: databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128) where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN). For MTU values below 871: MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected) MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted) The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes. I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations. Fixes: 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message") cc: stable@vger.kernel.org Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Jacob Keller Reviewed-by: Michal Swiatkowski Reviewed-by: Paul Menzel Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Link: https://patch.msgid.link/20260515182419.1597859-3-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c index a980d337861de..107cfa93a80f3 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c @@ -2990,7 +2990,7 @@ static int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg) if (qpi->rxq.databuffer_size != 0 && (qpi->rxq.databuffer_size > ((16 * 1024) - 128) || - qpi->rxq.databuffer_size < 1024)) { + qpi->rxq.databuffer_size < 128)) { v_ret = VIRTCHNL_STATUS_ERR_PARAM; goto error_param; } -- 2.53.0