From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB68D357739 for ; Fri, 5 Jun 2026 19:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780688308; cv=none; b=Hi1eIWs7ZtjKZetXMJrYkz3fyiFAzAYg7nzwK74OsVqSqXF5Qlxo3rLheYdPcIv9bc2/Xctidwx5/1jUgT4vd/dphIWJlvzSYiB35PnwAG7XlzHSxcDOFqaJpXKPsxt7M2LOkR3THKxxTOmaAPVga+MfUX3aUwndrSzpJYO6UbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780688308; c=relaxed/simple; bh=+GuaE5CWl/At4cVwobgWmEJXDOtiRTTGI83H93gi43g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PzbDlOE5cqiQiLG1jxoKWPBdcyWMLjpGpeUzrQ6l7chwIbyOMeBAg1HEeFXLYUPYn9+X8w0YVyMb2ZtrP7bdY7fC41PiO6U2DaPmqjaJtU/BmnBEFeOibj0tCp+XhBSJyH6z27Q5FdsIpFOcIG7x2uWM2JEuaUb5XfqDHRYsX9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MnmwpaXn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MnmwpaXn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 025E31F0089A; Fri, 5 Jun 2026 19:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780688307; bh=gAGQumzm3W1a+pXTIsDcs0W5mx9lbyJqR+3f/MwYKGo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MnmwpaXnRCZ7CL6KlSJTqd/5D/rqxn11tuslb+t4mRfQNPPUE4jY5/pEXAmlxxIIR wmM2KTnMASPm+wY/gG3UNVg+kEgIf7xu5XwJeeurtSt1H2hJi3Zo45E992BBb8s8Kt 3CLxjYY6yGE+A8sQaexriu4UGrjy/Dy+RA/vEwlQ9iyHSpy8l1BWh4CbQBtQyyFrxB zX4469VOWb/q0dv8h/2I1Z9yKI7M8kxsz7LXOaFz64HQbgi78gz3ZxKuePah8XRGyM hUmYSRZ6+1wRSdrT8vJbGBKfEEM9oP5KWKL+AjKJM2uYjLWRLF0KKzjy3hs2FRmjkm y0BRCvkoxv0sQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Tudor Ambarus , stable , John Ogness , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.10.y 3/3] tty: serial: samsung: Remove redundant port lock acquisition in rx helpers Date: Fri, 5 Jun 2026 15:38:23 -0400 Message-ID: <20260605193823.2169333-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260605193823.2169333-1-sashal@kernel.org> References: <2026060429-earflap-scope-57c7@gregkh> <20260605193823.2169333-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tudor Ambarus [ Upstream commit a3bb136bff5e6a5e48cdd813246c9c4686feaaa9 ] Sashiko identified a deadlock when the console flow is engaged [1]. When console flow control is enabled (UPF_CONS_FLOW), s3c24xx_serial_stop_tx() calls s3c24xx_serial_rx_enable() and s3c24xx_serial_start_tx() calls s3c24xx_serial_rx_disable(). The serial core framework invokes the .stop_tx() and .start_tx() callbacks with the port->lock spinlock already held. Furthermore, all internal driver paths that invoke stop_tx (such as the DMA TX completion handler s3c24xx_serial_tx_dma_complete() or the PIO TX IRQ handler s3c24xx_serial_tx_irq()) also acquire port->lock prior to calling it. (Note that s3c24xx_serial_start_tx() is only invoked by the serial core). However, s3c24xx_serial_rx_enable() and s3c24xx_serial_rx_disable() unconditionally attempt to acquire port->lock again using uart_port_lock_irqsave(). Since spinlocks are not recursive, this causes a deadlock on the same CPU when console flow control is engaged. Remove the redundant lock acquisition from both rx helper functions. Cc: stable Fixes: b497549a035c ("[ARM] S3C24XX: Split serial driver into core and per-cpu drivers") Reported-by: John Ogness Closes: https://sashiko.dev/#/patchset/20260506121606.5805-1-john.ogness%40linutronix.de [1] Signed-off-by: Tudor Ambarus Link: https://patch.msgid.link/20260515-samsung-tty-flow-control-deadlock-v1-1-93255edbc9bc@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/samsung_tty.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 1639a6a67e70b4..661e9af32c3290 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -241,12 +241,9 @@ static int s3c24xx_serial_has_interrupt_mask(struct uart_port *port) static void s3c24xx_serial_rx_enable(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); - unsigned long flags; int count = 10000; u32 ucon, ufcon; - uart_port_lock_irqsave(port, &flags); - while (--count && !s3c24xx_serial_txempty_nofifo(port)) udelay(100); @@ -259,23 +256,18 @@ static void s3c24xx_serial_rx_enable(struct uart_port *port) wr_regl(port, S3C2410_UCON, ucon); ourport->rx_enabled = 1; - uart_port_unlock_irqrestore(port, flags); } static void s3c24xx_serial_rx_disable(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); - unsigned long flags; u32 ucon; - uart_port_lock_irqsave(port, &flags); - ucon = rd_regl(port, S3C2410_UCON); ucon &= ~S3C2410_UCON_RXIRQMODE; wr_regl(port, S3C2410_UCON, ucon); ourport->rx_enabled = 0; - uart_port_unlock_irqrestore(port, flags); } static void s3c24xx_serial_stop_tx(struct uart_port *port) -- 2.53.0