From: Greg KH <greg@kroah.com>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
stable@kernel.org, Nicholas Carlini <npc@anthropic.com>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH 5.15.y] nfsd: fix heap overflow in NFSv4.0 LOCK replay cache
Date: Tue, 16 Jun 2026 15:23:37 +0530 [thread overview]
Message-ID: <2026061626-ladder-unwired-2bd4@gregkh> (raw)
In-Reply-To: <919817c7-2684-455b-8f62-14e31d2b5eb1@oracle.com>
On Tue, May 12, 2026 at 02:43:57PM +0530, ALOK TIWARI wrote:
> Hi,
>
> On 3/20/2026 5:09 PM, Sasha Levin wrote:
> > From: Jeff Layton<jlayton@kernel.org>
> >
> > [ Upstream commit 5133b61aaf437e5f25b1b396b14242a6bb0508e2 ]
> >
> > The NFSv4.0 replay cache uses a fixed 112-byte inline buffer
> > (rp_ibuf[NFSD4_REPLAY_ISIZE]) to store encoded operation responses.
> > This size was calculated based on OPEN responses and does not account
> > for LOCK denied responses, which include the conflicting lock owner as
> > a variable-length field up to 1024 bytes (NFS4_OPAQUE_LIMIT).
> >
> > When a LOCK operation is denied due to a conflict with an existing lock
> > that has a large owner, nfsd4_encode_operation() copies the full encoded
> > response into the undersized replay buffer via read_bytes_from_xdr_buf()
> > with no bounds check. This results in a slab-out-of-bounds write of up
> > to 944 bytes past the end of the buffer, corrupting adjacent heap memory.
> >
> > This can be triggered remotely by an unauthenticated attacker with two
> > cooperating NFSv4.0 clients: one sets a lock with a large owner string,
> > then the other requests a conflicting lock to provoke the denial.
> >
> > We could fix this by increasing NFSD4_REPLAY_ISIZE to allow for a full
> > opaque, but that would increase the size of every stateowner, when most
> > lockowners are not that large.
> >
> > Instead, fix this by checking the encoded response length against
> > NFSD4_REPLAY_ISIZE before copying into the replay buffer. If the
> > response is too large, set rp_buflen to 0 to skip caching the replay
> > payload. The status is still cached, and the client already received the
> > correct response on the original request.
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Cc:stable@kernel.org
> > Reported-by: Nicholas Carlini<npc@anthropic.com>
> > Tested-by: Nicholas Carlini<npc@anthropic.com>
> > Signed-off-by: Jeff Layton<jlayton@kernel.org>
> > Signed-off-by: Chuck Lever<chuck.lever@oracle.com>
> > [ replaced `op_status_offset + XDR_UNIT` with existing `post_err_offset` variable ]
> > Signed-off-by: Sasha Levin<sashal@kernel.org>
>
>
> This patch does not appear to be queued in 5.15.y yet, although
> it is already present in 5.10.y and 6.1.y.
>
> Could this please also be queued for 5.15.y?
> It seems it may have been missed inadvertently.
Odd, I did miss it, now added, thanks!
greg k-h
prev parent reply other threads:[~2026-06-16 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 8:47 FAILED: patch "[PATCH] nfsd: fix heap overflow in NFSv4.0 LOCK replay cache" failed to apply to 5.15-stable tree gregkh
2026-03-20 11:39 ` [PATCH 5.15.y] nfsd: fix heap overflow in NFSv4.0 LOCK replay cache Sasha Levin
2026-05-12 9:13 ` ALOK TIWARI
2026-06-16 9:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026061626-ladder-unwired-2bd4@gregkh \
--to=greg@kroah.com \
--cc=alok.a.tiwari@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=npc@anthropic.com \
--cc=sashal@kernel.org \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox