From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF3D136A367 for ; Tue, 7 Jul 2026 07:49:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410567; cv=none; b=cluL64z5xgqJ6PJw4lzilHkcfEBj0t3QoYPEWbcWZ80uMlKw/BhC4ZOmNaAZraPkif9CBDx+l9PxCQ8KJcC9zOF2+MS5X7HdA5w9nYwZAavyyNzP+qcGw2jucw+rJAJ2tEGIUYpkQblp1pBQZYeU4weakT7bYeEzmoGV67O5sFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410567; c=relaxed/simple; bh=xFiN6+TdamKPKo1XCbG5OGzCj40TPx1ysKsFcpDfGRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nvZ/jYc0LKcN9k7Br5x2oB8G65W7YwDPuhJwyAPm7YZ0tKELdfXwmTJR48hVWK1ykcl3n4Hk5WxWmweWo6ZneaAvHlOQR9J+QzHWYUFLgEE6l3BSvWcNSwd7NPWYQB4aqJBsbAeCzWu9hASS+EhazxZr71CUEmyOhJjqbIhCHIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qZXYPWAG; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qZXYPWAG" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38511175ad3so1832484a91.2 for ; Tue, 07 Jul 2026 00:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783410565; x=1784015365; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+brjFLVFjY/4CAFVXT8akEWDnOfxHjuH7xO2k8ZWc/w=; b=qZXYPWAGkcZOgpl0tP8cwWGy+HlLQqUwfZdhzTFmo3peCkCukAG8sTzlTF+mJx8BZ2 NtiJMMqooK1meBkE0sFCKs8m7LN1vt4K1lI3O+YbjKRT4i3UzHzcuUdZSC93wzN3D4ED hD3IrrW8dQBNDn7PORt/l2QS4C+oosn20yHGRbittElpCn4Iz8a+JKo+FwmHIXmKBICb YP5WDLIp+anMX7SP8VPn29arlEG2BkJz/lBnwuiqmCGMVlVCo4/AVKdw5BOB4itNR6vn rQIw9We0vNuh0iZ8CBgaMTSHbBfpwRlfl2gNubvGk8Ek6xJwdZSUD/M4JvRPHmUa7MPB whaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783410565; x=1784015365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+brjFLVFjY/4CAFVXT8akEWDnOfxHjuH7xO2k8ZWc/w=; b=DvfERtFULUNVt+4S9EaYjKkKDGqazczqoCcH/zZqISXXzBhABJwHQJ96gKk5dMMZBt CJ+x5+GkzuiWRmRTHrQ2bpBXX63zDXKnMB8bSw1DQ4sLc7KH3dAwyB2PmhGfSaD1gmFf UOGeET21NUoQYEgtF2bZHLqF6QUkq5eR49QTy85PsCMBm5u9EFIESpm0OJxI1qHsjzPr qg+NeE9RjwPROeGnu4zgs5P1tstH+osbCuAZ6KK9TNTEBt5sbLpBd9r5SoFEgIndPCZ4 VKcGQir6v3cothO428nP6rFOj8ejZ5QnXK11QBDIW2nVJ2/UYovGbaVKHmrE+UVLB4KR 1prw== X-Forwarded-Encrypted: i=1; AHgh+Rp81RzsFPK2SidFqm01uyblS+9vB1EcLCErRlvayABJx5arG98NtO/XygVqwGL649JZL/l3Ya4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0Uo8rBBPA4L7zTNBnk276Fib2NSfLT2m0UZxRpNKpjq/s7yzY e2lvu8/Frro745jGlymsutJ8qokL6pg13DxW28UvCCbIY7R3qxYF66v0 X-Gm-Gg: AfdE7ckRrwLd83B/bdcKB3WbG7mp0QWy7K2XwIRrC0ZBInefOye4YLlbw16wv4FCGsw NnpRTIqVgYSQXFb52xo0OuvFrYks2tG3bW5ZGicSGItOk3UnbkbRBO3QH9Urw4GrtdEGKFwvszq DOSiJTV3+WjriZB7fs/rj4iht5h8yoqdWORqnTWvXOFPiUaN+Zo/x/2yoBDBFycxH8B+4178yDG uBqUFiZmKVuKffd2aqEOgdINnvrq1DRqmuVCXAKaU9AZv1znKBJ/jaYz4z+tVQtnFpIMuEA9wvh VeErO+Z4WwJZRe9M/Hu5TGw4UpFRZEzzYkSA9UMHfm1R85G09RnlriHNVY44G/oy3srcwqGhRHI qkLDCxG4/QLqw2846gmuazZgxPJdRnbMIX+mTkhiso/ycnToojvalfcC9RUBdbhxIWnBIhgj/f9 qXxVwQATr8DlDlLQ0Vdx/KI/wxmYaXbpwfIh955KuvUF44 X-Received: by 2002:a17:90b:2709:b0:380:9d0d:7af8 with SMTP id 98e67ed59e1d1-38758260ad3mr4159340a91.20.1783410565340; Tue, 07 Jul 2026 00:49:25 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a361asm626710a91.15.2026.07.07.00.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 00:49:25 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), stable@vger.kernel.org, Chen-Yu Tsai , Miles Chen , Akari Tsuyukusa Subject: [PATCH v2 3/6] clk: mediatek: mt7622: fix memory leak on module removal Date: Tue, 7 Jul 2026 16:48:32 +0900 Message-ID: <20260707074839.240676-4-akkun11.open@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260707074839.240676-1-akkun11.open@gmail.com> References: <20260707074839.240676-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk-mt7622-apmixedsys.c and clk-mt7622-infracfg.c do not call platform_set_drvdata() during their driver probe callback, but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: c50e2ea6507b ("clk: mediatek: mt7622-apmixedsys: Add .remove() callback for module build") Fixes: 838b86331c5e ("clk: mediatek: mt7622: Move infracfg to clk-mt7622-infracfg.c") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa --- drivers/clk/mediatek/clk-mt7622-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt7622-infracfg.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt7622-apmixedsys.c b/drivers/clk/mediatek/clk-mt7622-apmixedsys.c index 8a29eaab0cfc..fae8abda14b3 100644 --- a/drivers/clk/mediatek/clk-mt7622-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt7622-apmixedsys.c @@ -109,6 +109,8 @@ static int clk_mt7622_apmixed_probe(struct platform_device *pdev) if (ret) goto unregister_gates; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_gates: diff --git a/drivers/clk/mediatek/clk-mt7622-infracfg.c b/drivers/clk/mediatek/clk-mt7622-infracfg.c index cfdf3b07c3e0..cec19447d637 100644 --- a/drivers/clk/mediatek/clk-mt7622-infracfg.c +++ b/drivers/clk/mediatek/clk-mt7622-infracfg.c @@ -90,6 +90,8 @@ static int clk_mt7622_infracfg_probe(struct platform_device *pdev) if (ret) goto unregister_cpumuxes; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_cpumuxes: -- 2.54.0