From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7993A873D for ; Tue, 7 Jul 2026 07:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410571; cv=none; b=qZHckMYMut/qEqF4Q2+iZv82BxmwMDYHfB78CcEidWpwBjcxI7qpK3Qu1o9lNIaA3D9B0UN5eRW2yn32VqP7+mL2YKeo48z09pBUv22xYTcVHZ/Y9QzJ6JQmcBso7OSWG3oRYa0Zyyzqv4HFY1QTZ51b2G5NVm16mCpHFHCCkjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410571; c=relaxed/simple; bh=eFufH7LT3CdItIJOBph0MNu+wwyaWOrq8umciX1p/6w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KcGzBkyl8gMpjOrMHy9iuRr3IdwaAkb3neIgA3GnRGK0BLGNQgZAtmIJKbD7dAHwRDpCG18KY1grAXy9sheDNUT6GoihC5cz7cDacZQaBVYmrufYiS+1YmzReWI10tIPRwjIAlEEeBMYufUz6ud4xODJzkHGIJ2YLrp7khvVd3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CR9uKKCp; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CR9uKKCp" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381891a9525so3598549a91.3 for ; Tue, 07 Jul 2026 00:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783410568; x=1784015368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t0usj1Azn3b9r2TvYMyi39ADdH0kaKf4fB0NJ5kTbFs=; b=CR9uKKCpcnbViGJQFdsn1d+0qx8p8n2+RgvojUQdAQrRp8t71tBgmAlAgeHPbihERu b16d/9QNeqXwHl1El8tK87oXwWoB/ytaw9Ipq+XdnedZwMnIUZ55PAIhM/DsqPEVhd1e DINaTL5ItdsG/SRovOHAUJYVYE1upcp8nDXg8mwMbKSw/S3VZU8cGGrb1ailHs4OszHe s6ZtpkpduhR5vPb+YgGbIRcfQWufiz+gv29Schuu6phEJ1sxcrayBKNRm28C/EFLs8Kk A05YKUKuEFc+z27DHWVHALvvTASZd2Mh7OK63ylncZ6hJFMIromhUKSai+jlTakoJsXR ++4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783410568; x=1784015368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t0usj1Azn3b9r2TvYMyi39ADdH0kaKf4fB0NJ5kTbFs=; b=OC06dW52UGQyczKU3L/za49ec48LZ4xLheIN3+glYOXbX/vM2nmXrAzLqKUWONtxdt ZrVqqP4zfJ/+9hYLic3AfmucCsH+pvz+p+o6ewFPLEzd0ormgrpR1FBc3vy+q4WLFpEI dRPnzxFW+N5PlRfkijto3uEisBUM1Wg9M9l59V2bQASTKeXjuGU0XsVadDaWxJSrRcaK MZugOnErfiPGpZsStRK7CLFO9aud6rW0hECP6dmpbL5/T2fBlRFaLEFOkFx1KWJZwkNN ZRtGQWSDjzEr7lvMoikApMhjx+r7yl/FvOvgxYBHjuYbdsz8SuY38r4jU9ef0HYDF7Iz Adgw== X-Forwarded-Encrypted: i=1; AHgh+RqWpXMyRsAovfMkcKjM4oHmGQFiaNnzN8iP2qEoBBot9ay5mKrnZO5P6ndOzfSehQfSc7qe6Cw=@vger.kernel.org X-Gm-Message-State: AOJu0YxhlYVipE2U3aLN+kWtGa7odU1v/AaTwbrUAkxU9DE7PPqRscbC nx0YFc6L8BmtOyMUvqIDK1/0Eifz3AgwPx7GkrT3tDrj/6Ibz9CO3NqL X-Gm-Gg: AfdE7clWHVP0QpTJrFInr/v/pU6pmlMNF7BEq9s2qwRA6drC71ZGRz5Ez3and+72nlC kT5+ji0drCMB1Y/GV/91muDRQHXZWBYS+MDomEN7zK5Yh42belK1P7Psdwc8YTzjwEKs4pI9815 2xfLawt6U9VyQ1Xvvi2DePDzUiMO61+aDWb1PSAYM9j3c4CWUuSG+dCtrdUBrPHQwFu1Y8A9Ml7 pi4u82Pf1okfgaYIYwxDCC32eNGRgJYB5GhlHjnNQvwej17F2S6BX3NXwQGvpmFNSSywKWE6FiL Mua9Sg/M6QWY98SspSJchJH2X3Un216bytxDYUfeonSwFSYHaOhr38q7NQx8lKcYMScSZhctP+w 9BZlSbch5DGU/tq8lJKDzWSA2ORbBFiB/RVHaVw8wnRHW+FMIYUxTYdNPGNMsrJQ8NsgqhaQn9h A05xq7tPlDSIx5U9BfZYOw4oJH33ERQpyJqynRDGoJpsGb X-Received: by 2002:a17:90b:4a0c:b0:380:873:49cb with SMTP id 98e67ed59e1d1-387572b380cmr4047566a91.21.1783410568403; Tue, 07 Jul 2026 00:49:28 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a361asm626710a91.15.2026.07.07.00.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 00:49:28 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), stable@vger.kernel.org, Chen-Yu Tsai , Miles Chen , Akari Tsuyukusa Subject: [PATCH v2 4/6] clk: mediatek: mt8135: fix memory leak on module removal Date: Tue, 7 Jul 2026 16:48:33 +0900 Message-ID: <20260707074839.240676-5-akkun11.open@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260707074839.240676-1-akkun11.open@gmail.com> References: <20260707074839.240676-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk_mt8135_apmixed_probe() in clk-mt8135-apmixedsys.c does not call platform_set_drvdata(), but clk_mt8135_apmixed_remove() callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa --- drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c index 19e4ee489ec3..e3b7dc13b458 100644 --- a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c @@ -66,6 +66,8 @@ static int clk_mt8135_apmixed_probe(struct platform_device *pdev) if (ret) goto unregister_plls; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_plls: -- 2.54.0