From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 142F6422545 for ; Fri, 10 Jul 2026 15:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783698129; cv=none; b=KB+/yXs0p+OBmN34UkyUKWqfTyENxjeTwvJllGLjBBQ6rCzT2rpF7AVFOJCO3eRwoVwE3x/W5RU6MoJkOmD4ZAXj1ytFIBpIll6yLxDed3u+xOYZuzoHL6/V2TxlD1pHN3NhogbqXCX9cLHOKuLNYBOBsVrG32GP/X+oxIdXikE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783698129; c=relaxed/simple; bh=aei2onBR7qVkRapoYecGP3RzJKz3LJ/iRZKZH6ZJqQA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MhSx2Kj6oACgTfXmlaa9x9cGifGP3phfcS9HRIMrCwZ2/VkmWU5mAzttq+4qlKLf2upYQoZC/aNYl7f5JRX7oueu608RcT305xxyqOUPs3TYYyeJiV7gWy98jZC7cF7R2lZvLXrBdNH/7IrEM1NLez/HO5svR/YRWb+1uJL/In8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cYyPhFpF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cYyPhFpF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C021F000E9; Fri, 10 Jul 2026 15:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783698127; bh=PkCjRwkf0ZdJlqvq+TP6DWUbyip5WHEYyXEKa0IeTwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cYyPhFpFdXOLQzYJCO7I+DFD+x+gxz9xWEB5OxVXyH6uvC6xdBZJCYu1YzNkCNq4V Ki7RKHW96nHTS9HzKSD2hJMI6qR8NQsjFphNH1D98bRgA6PB58hvKmmRO3Onyp4afI aKeUejSebWJUumLpqek76MKm8tKfz0JWkfNV2SL+OlF93R4tmPCFybP9Wc409vlbOa 0tNJwsyVS74jVLRIrGDeFczD5ebHv12DseePe3jDzVyZdh9GsaLTm7QlQMRk5Xt7oh BLyEzIQLWtrIGuX523Da8ZbPD17AeKCBSTujC4u8XFYgApuievMFqaxRdE8of3f90K vWjIEArdZjdUg== From: Sasha Levin To: stable@vger.kernel.org Cc: "Rafael J. Wysocki" , Dave Jiang , Sasha Levin Subject: [PATCH 5.10.y] ACPI: NFIT: core: Fix acpi_nfit_init() error cleanup Date: Fri, 10 Jul 2026 11:42:05 -0400 Message-ID: <20260710154205.284338-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026070918-reply-wimp-b2c4@gregkh> References: <2026070918-reply-wimp-b2c4@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Rafael J. Wysocki" [ Upstream commit 38bf27511ef41bffebd157ec3eba41fc89ba59cd ] If acpi_nfit_init() fails after adding the acpi_desc object to the acpi_descs list, that object is never removed from that list because the acpi_nfit_shutdown() devm action is not added for the NFIT device in that case. Next, the acpi_nfit_init() failure causes acpi_nfit_probe() to fail, the acpi_desc object is freed, and a dangling pointer is left behind in the acpi_descs. Any subsequent ACPI Machine Check Exception will trigger nfit_handle_mce() which iterates over acpi_descs and so a use-after-free will occur. Moreover, if acpi_nfit_probe() returns 0 after installing a notify handler for the NFIT device and without allocating the acpi_desc object and setting the NFIT device's driver data pointer, the acpi_desc object will be allocated by acpi_nfit_update_notify() and acpi_nfit_init() will be called to initialize it. Regardless of whether or not acpi_nfit_init() fails in that case, the acpi_nfit_shutdown() devm action is not added for the NFIT device and acpi_desc is never removed from the acpi_descs list. If the acpi_desc object is freed subsequently on driver removal, any subsequent ACPI MCE will lead to a use-after-free like in the previous case. To address the first issue mentioned above, make acpi_nfit_probe() call acpi_nfit_shutdown() directly on acpi_nfit_init() failures and to address the other one, add a remove callback to the driver and make it call acpi_nfit_shutdown(). Also, since it is now possible to pass NULL to acpi_nfit_shutdown() or the acpi_desc object passed to it may not have been initialized, add checks against NULL for acpi_desc and its nvdimm_bus field to that function and make acpi_nfit_unregister() clear the latter after unregistering the NVDIMM bus. Fixes: a61fe6f7902e ("nfit, tools/testing/nvdimm: unify common init for acpi_nfit_desc") Fixes: fbabd829fe76 ("acpi, nfit: fix module unload vs workqueue shutdown race") Signed-off-by: Rafael J. Wysocki Cc: All applicable Reviewed-by: Dave Jiang Link: https://patch.msgid.link/1963615.tdWV9SEqCh@rafael.j.wysocki Signed-off-by: Sasha Levin --- drivers/acpi/nfit/core.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index d314afec44b56d..3fbb892972a927 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -3456,6 +3456,8 @@ static void acpi_nfit_unregister(void *data) struct acpi_nfit_desc *acpi_desc = data; nvdimm_bus_unregister(acpi_desc->nvdimm_bus); + /* The nvdimm_bus object may have been freed, so clear the pointer. */ + acpi_desc->nvdimm_bus = NULL; } int acpi_nfit_init(struct acpi_nfit_desc *acpi_desc, void *data, acpi_size sz) @@ -3680,7 +3682,10 @@ static void acpi_nfit_put_table(void *table) void acpi_nfit_shutdown(void *data) { struct acpi_nfit_desc *acpi_desc = data; - struct device *bus_dev = to_nvdimm_bus_dev(acpi_desc->nvdimm_bus); + struct device *bus_dev; + + if (!acpi_desc || !acpi_desc->nvdimm_bus) + return; /* * Destruct under acpi_desc_lock so that nfit_handle_mce does not @@ -3695,6 +3700,7 @@ void acpi_nfit_shutdown(void *data) mutex_unlock(&acpi_desc->init_mutex); cancel_delayed_work_sync(&acpi_desc->dwork); + bus_dev = to_nvdimm_bus_dev(acpi_desc->nvdimm_bus); /* * Bounce the nvdimm bus lock to make sure any in-flight * acpi_nfit_ars_rescan() submissions have had a chance to @@ -3762,13 +3768,14 @@ static int acpi_nfit_add(struct acpi_device *adev) sz - sizeof(struct acpi_table_nfit)); if (rc) - return rc; - return devm_add_action_or_reset(dev, acpi_nfit_shutdown, acpi_desc); + acpi_nfit_shutdown(acpi_desc); + + return rc; } static int acpi_nfit_remove(struct acpi_device *adev) { - /* see acpi_nfit_unregister */ + acpi_nfit_shutdown(dev_get_drvdata(&adev->dev)); return 0; } -- 2.53.0