From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A4E8285068 for ; Sat, 11 Jul 2026 15:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782396; cv=none; b=qSHKgqO/UPH1CqJcJw7B9toMuB9PUAtrQAGoTSgnKAHpGgYl5JtHdhXa+Na/uPmRzuZ1iChCFIN8HcU6fK7AVop+O0F0BISpaLEx9q3n8Re4k7mDzv+8sh7K7Wjier8QKl/koylDXsOhnRrKyoVXZCFwpc1x/VOCbFZ1PX4BxqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782396; c=relaxed/simple; bh=xfd1Qij55WSKgMYmH/iULiROavfzelZy0Gq6Ktbvt4s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BopV2P3/HCL6SZJcT6pAeSx+FBM67KQwYZDv/OriYBIYxPLRb9lI1uMIbxZfBHOx4CM5hpWdK3znr0qLzk+GBfuY/9+oxisevafEVemfE15fF8OIbAPhfxESl3bgNXi7DkGN9pvCAqmqjQQtXTtcbvGo/IbwpnUjeSVcKGmTYG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RdER+N6g; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RdER+N6g" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-51c22c61795so12471601cf.0 for ; Sat, 11 Jul 2026 08:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783782392; x=1784387192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XSPQ4s327xjju3OZzaMxfnUi+7xam88AtuluAZAKUPI=; b=RdER+N6ghm5RpSKKvj+gqtJxRBfPmMkBL8fMv4K6APpV1kKcCcxbKfb5/4cKDFpTtg FwCU4a/ts9PUK1uxOiASMqHWAPZBj7oCY5/VG2TDLeMgcFI0F3pmM6OehTWfJxlWvWmA ah3CqWm3AK/jmu2R6lJVPtlaj0PmN8hka8eK+DXUa/pVcf1fygS69HwuV4pENMFmziC/ xROgyWzftvniM5Q86qCuKbjsmDvx6lx9HgEXP8eicWeLYRGBw3muIhXTNrn1ja2P5Q29 q7vDzGqm5U8rmfAtaCRZJOwQdyAKP+Mx1n2TTczKw2aLxJHKKOem+CC31ZLhAyYd/enM slUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782392; x=1784387192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XSPQ4s327xjju3OZzaMxfnUi+7xam88AtuluAZAKUPI=; b=i6zkgQR7YU1UImmqQOwFAe+KWcvtYLuSsG0GvcaQFvumPHiWJwZWtlIvj1EQgB/y89 OT3BjFpctw+rC9nnjQq++/yYMiTpiRyzERk8cFFsCFhGBWSv4bIuWhSTbtUlg+eyKUrA kTN+A1IExFEjjeeYKadxLKKUyqYbQnZD1IqEBFuZ/ZmrW+gwudXapA/okKYKYlZYqGLa 09X/r5tMXe8ScirtBBNLc/AwLKnmK1Xzv+Vx0/QcBl+k73QpBC65Gt95CCG7Q8InuCHE Y5TC/vxLhqK92qljbEDxO4TLK19sBB97Ptvi3wfAHHvJ6e2KSbylu5iXC2xfYVpuos99 q9Aw== X-Forwarded-Encrypted: i=1; AHgh+Rqqf3HmxvYpIL8WvNvsAaFi05aOf0fU1s59v1YOXdAVO0mISiL7xOM0jAFeLXEyv+NZEd3xfLU=@vger.kernel.org X-Gm-Message-State: AOJu0YwIm0w57MQCzdsl0fgS23wBMp0wVSJqYiGNbCwdwPluzGRevSUi m0hmtR/8OB3XJF4YNzdX+HwGCKpgXI0euKtS7kUSyWa+Akk43qwjEW29 X-Gm-Gg: AfdE7cnvkLMFk6HswgQZQJCitYX5QcUhTnBMSncTkko4arQ31BJf01VSx8SzwW0RJnE m3URJYUuSCZGa7qQyNerBunNXzZdTw86iHBf2oIJQqw2IN08gRpmCfiYgNsGomwi8OuK9Ou2rxP 1fWGA/uDXOOplJM/Sz1xdBJss61X90IbNdX18f8/KjqNkrLDpqFA8A2mrDfnusRUAQZVRM/wqve tjNY6GJZrIGvXKzY3fuZTRFMahFOg3a7NxKs9loEXKrqxUb8Hd5yo9N4cziOjEnk1vrgadQ11aA 9nF75MzV3w/sqb++KxYh8YDtCc5aIxDMWx0H8u2Q6zqjBhr7t+2AtIc8ZMFg4cRpr0pgyyE0aHF 9B90Hl+oftrNdgobhC9088LqFPQD5X8gJZ7TFSsv1Ghd8tkZ7Byj6b4UzojqKEVNf6HFUp5ALBp e+T8mEjaIXSBVXmSHbRjwfT46PlYGbXhgxTGD/dx7/WZDizICZdGm7ANfd4meGE1RTMWZKvEXoC JS19RgnuA== X-Received: by 2002:a05:620a:28c9:b0:92e:8e36:32a7 with SMTP id af79cd13be357-92ef2c7289amr321690985a.68.1783782392025; Sat, 11 Jul 2026 08:06:32 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5b88a38sm465793285a.12.2026.07.11.08.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 08:06:31 -0700 (PDT) From: Michael Bommarito To: Haiyang Zhang , Dexuan Cui , Long Li Cc: "K . Y . Srinivasan" , Wei Liu , Andrew Lunn , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] net: mana: cap HWC init max message size to HW_CHANNEL_MAX_REQUEST_SIZE Date: Sat, 11 Jul 2026 11:06:28 -0400 Message-ID: <20260711150628.2914205-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit mana_hwc_init_event_handler() in hw_channel.c stores device-advertised HWC_INIT_DATA_MAX_REQUEST and HWC_INIT_DATA_MAX_RESPONSE values without bounds checking. mana_hwc_alloc_dma_buf() later computes the DMA buffer size as MANA_PAGE_ALIGN(q_depth * max_msg_size) in 32-bit arithmetic. A malicious device returning a large max_msg_size causes the product to wrap, allocating a small buffer while laying out q_depth request slots at the unwrapped stride, placing slots outside the allocation. Impact: a compromised hypervisor device model or malicious MANA PCI device can cause out-of-bounds DMA buffer writes during HWC channel initialization. A reproducer is available on request. Clamp both values to HW_CHANNEL_MAX_REQUEST_SIZE (4096), consistent with the cap already applied at the channel-create callsite. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Michael Bommarito --- drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c index 48a9acea4ab6c..a0916b50cffce 100644 --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c @@ -152,10 +152,14 @@ static void mana_hwc_init_event_handler(void *ctx, struct gdma_queue *q_self, break; case HWC_INIT_DATA_MAX_REQUEST: + if (val == 0 || val > HW_CHANNEL_MAX_REQUEST_SIZE) + val = HW_CHANNEL_MAX_REQUEST_SIZE; hwc->hwc_init_max_req_msg_size = val; break; case HWC_INIT_DATA_MAX_RESPONSE: + if (val == 0 || val > HW_CHANNEL_MAX_REQUEST_SIZE) + val = HW_CHANNEL_MAX_REQUEST_SIZE; hwc->hwc_init_max_resp_msg_size = val; break; -- 2.53.0