From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74CFE3546C1 for ; Mon, 13 Jul 2026 19:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971221; cv=none; b=KEEieTAKPoQXNLNiSNL9WXwZ1F/lI0KVqghJUEr73RUbTQvra+mkIVRWYvlKaI8lcYJLlIGlNAbLyRNMmlbxp8Mrj+xcSXcPXOUQxDHOaeHokBijnl4Z87DYeWORoYBr9P+q4wLkedHs1D8DIijF6G81rnxj3qq2crxyRjEa7eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971221; c=relaxed/simple; bh=1OFczrwWoI0prDEmBIUrx939EeAsrLRn0ygwvvyfnvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mDD5ugzEOVanI4sGC6ZQCLo4TY04YyrqvKTsZeOMm33EDSUBHHhu8QoSx2tSXBtJDPjCNf7AXts9Mmq6u8mlLpCQ0XZrx1kDzESRstOrMFMVXaqr68krf8xwg8wNSLpaJjLPLegCugBjEsBb4HdpGhb1DpJmjD4OYuQBOI8DZto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i3/ybCEp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i3/ybCEp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DFCE1F00A3A; Mon, 13 Jul 2026 19:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783971220; bh=A8+KNoBbAqeX6A/AndBwwJZcG3W3kdOplvA4UkhHJ10=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=i3/ybCEpcdHeTZR3pzaBNztkseCKW4Zgcj0dxW5PFAd11k9x5pWlJlNHoQ5vfMy4C 3GLSDv4885ZMr5DvkGBIfAfAn2I+/3XaX8MoOtKCfJqsvazlYoX2deE7hfpxmvygNg G/sJN7Mw/6k8eZed+I5RSvT/mMBATYwuxXfXe6+bE1h7xO3TDUqsjUu6M4lTxBLzAL DpQzfzCZ15L6uWUBlZbvqx1/ZAXYaOATZZ9JEXF3J8TP4L9IsfdliPQo9jxjoX9AFA 7YVjWuinY9/0RAkHrTs69c8x60XTMGGtZwjgYrspp0zh1TXJ9RMTQF5G7Z2kXtfPKv RwCRLAHCZGSPA== From: Sasha Levin To: stable@vger.kernel.org Cc: Zhang Lixu , Andy Shevchenko , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 5.10.y 2/2] iio: hid-sensor-rotation: Fix stale or zero output when reading raw values Date: Mon, 13 Jul 2026 15:33:36 -0400 Message-ID: <20260713193336.2037451-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713193336.2037451-1-sashal@kernel.org> References: <2026071341-urethane-barber-5549@gregkh> <20260713193336.2037451-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhang Lixu [ Upstream commit 3ce8d099e0afc5a7da75a2007a67f67c4f5a4af1 ] When reading the raw quaternion attribute (in_rot_quaternion_raw), the driver currently returns either all zeros (if the sensor was never enabled) or stale data (if the sensor was previously enabled) because it reads from the internal buffer without explicitly requesting a new sample from the sensor. To fix this, power up the sensor, call sensor_hub_input_attr_read_values() to issue a synchronous GET_REPORT and receive the full quaternion data directly into a local buffer, then decode the four components. Fixes: fc18dddc0625 ("iio: hid-sensors: Added device rotation support") Signed-off-by: Zhang Lixu Reviewed-by: Andy Shevchenko Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/orientation/hid-sensor-rotation.c | 40 ++++++++++++++++++- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c index 23bc61a7f018cf..b10204c147baf9 100644 --- a/drivers/iio/orientation/hid-sensor-rotation.c +++ b/drivers/iio/orientation/hid-sensor-rotation.c @@ -60,6 +60,13 @@ static int dev_rot_read_raw(struct iio_dev *indio_dev, long mask) { struct dev_rot_state *rot_state = iio_priv(indio_dev); + struct hid_sensor_hub_device *hsdev = rot_state->common_attributes.hsdev; + struct hid_sensor_hub_attribute_info *info = &rot_state->quaternion; + u32 usage_id = HID_USAGE_SENSOR_ORIENT_QUATERNION; + union { + s16 val16[4]; + s32 val32[4]; + } raw_buf; int ret_type; int i; @@ -69,8 +76,37 @@ static int dev_rot_read_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_RAW: if (size >= 4) { - for (i = 0; i < 4; ++i) - vals[i] = rot_state->sampled_vals[i]; + if (info->size <= 0 || info->size > sizeof(raw_buf)) + return -EINVAL; + + hid_sensor_power_state(&rot_state->common_attributes, true); + + ret_type = sensor_hub_input_attr_read_values(hsdev, + hsdev->usage, + usage_id, + info->report_id, + SENSOR_HUB_SYNC, + info->size, + (u8 *)&raw_buf); + + hid_sensor_power_state(&rot_state->common_attributes, false); + + if (ret_type < 0) + return ret_type; + + switch (info->size) { + case sizeof(raw_buf.val16): + for (i = 0; i < ARRAY_SIZE(raw_buf.val16); i++) + vals[i] = raw_buf.val16[i]; + break; + case sizeof(raw_buf.val32): + for (i = 0; i < ARRAY_SIZE(raw_buf.val32); i++) + vals[i] = raw_buf.val32[i]; + break; + default: + return -EINVAL; + } + ret_type = IIO_VAL_INT_MULTIPLE; *val_len = 4; } else -- 2.53.0