From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 111F81DED5B for ; Mon, 13 Jul 2026 19:43:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971791; cv=none; b=tKaaoAvJHikbecSO0r/+UsJR5wTGZgZXXc6VYd7Ad2nED50MuqvuriLIUoy5YoTV0OBDBxAbgzUna5ScuFaLilED9/mrbRdBPSdKM9pNDsxckzOOggdj5+pM6L0ZiurqKZosLoM4GY14Tg+elC+IZyHYvVTnP+bQP4N06fzikQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971791; c=relaxed/simple; bh=WsysDYKlmNIi1GeaMYZNzj3eo5Jd1cfgBO4xygxqFM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EEmcWWC8HbJdMhsSu7L0qUVm/s2mXkmMoie2TVqdOZZJBrTiH8WufvgRfweSMz1tpfb1arTdkvoAn1Y1+VQWR5CtMFFdCWIVrBXFUtkbB0qTQ76rWpJvJHbZgPwzAIr74JABUPHjFyL8yoTolJCtVrUdJ53D+NokxolSaxBYXdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V18a9lzf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V18a9lzf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 150B81F000E9; Mon, 13 Jul 2026 19:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783971789; bh=xg6cJ7Emy56zQk35qGT2BR2rdqy14HcsQeCTzOrDaOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=V18a9lzfYyS+E55hLaV9xF11f9hklzThT6ACS+Iy9vM56OYzrTiCZdW6LIrYlAwUu gWt14xEGMHt8Lc3bdUC+BKyACCUarhVj5KTdQBVzxIxquxQgkXEtUUR7FHnvLvfMsO Snu9l3wiKp/lViG5u1dtSZi2/5MVE23aCUsvMynVpYIc61d3FAzo3ENan/fef3bDvC 3Qmu1ZCgDK/d47mUVhNe+kUEAwjxb1OCGh6BHn9cHd37qZSEPLZg5XAS1c1FsIadzq Zu/1yyJLPV0kVXvdkgsXboAQGdKLlY34F6bWvwHhGRHj0G1QOKC+sjfFiVmIjQMDH2 ZYdHKaKSK2vVg== From: Sasha Levin To: stable@vger.kernel.org Cc: Biren Pandya , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 6.6.y] iio: pressure: mpl115: fix runtime PM leak on read error Date: Mon, 13 Jul 2026 15:43:07 -0400 Message-ID: <20260713194307.2064131-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026071359-barbell-reversal-8689@gregkh> References: <2026071359-barbell-reversal-8689@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Biren Pandya [ Upstream commit fbe67ff37a6fd855a6c097f84f3738bd13d0a898 ] mpl115_read_raw() takes a runtime PM reference with pm_runtime_get_sync() before reading the processed pressure or raw temperature, but on the read error path it returns without calling pm_runtime_put_autosuspend(). Each failed read therefore leaks a runtime PM reference and prevents the device from autosuspending. Drop the reference before checking the return value so both the success and error paths are balanced. Fixes: 0c3a333524a3 ("iio: pressure: mpl115: Implementing low power mode by shutdown gpio") Signed-off-by: Biren Pandya Assisted-by: Claude:claude-opus-4-8 coccinelle Cc: Signed-off-by: Jonathan Cameron [ moved pm_runtime_mark_last_busy() together with pm_runtime_put_autosuspend() ] Signed-off-by: Sasha Levin --- drivers/iio/pressure/mpl115.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c index 02ea38c8a3e431..e3eb154feb5fde 100644 --- a/drivers/iio/pressure/mpl115.c +++ b/drivers/iio/pressure/mpl115.c @@ -106,20 +106,20 @@ static int mpl115_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_PROCESSED: pm_runtime_get_sync(data->dev); ret = mpl115_comp_pressure(data, val, val2); - if (ret < 0) - return ret; pm_runtime_mark_last_busy(data->dev); pm_runtime_put_autosuspend(data->dev); + if (ret < 0) + return ret; return IIO_VAL_INT_PLUS_MICRO; case IIO_CHAN_INFO_RAW: pm_runtime_get_sync(data->dev); /* temperature -5.35 C / LSB, 472 LSB is 25 C */ ret = mpl115_read_temp(data); - if (ret < 0) - return ret; pm_runtime_mark_last_busy(data->dev); pm_runtime_put_autosuspend(data->dev); + if (ret < 0) + return ret; *val = ret >> 6; return IIO_VAL_INT; -- 2.53.0