Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Timber <dxdt@dev.snart.me>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	Sungjong Seo <sj1557.seo@samsung.com>,
	Yuezhang Mo <yuezhang.mo@sony.com>, Andy Wu <Andy.Wu@sony.com>,
	Aoyama Wataru <wataru.aoyama@sony.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v1] exfat: bail prematurely from exfat_extend_valid_size() upon fatal signal
Date: Mon, 13 Jul 2026 14:05:26 +0200	[thread overview]
Message-ID: <2026071359-overstep-gambling-73b9@gregkh> (raw)
In-Reply-To: <59343a70-1d74-4f37-a6a8-5a65fd585b90@dev.snart.me>

On Mon, Jul 13, 2026 at 04:55:34PM +0900, David Timber wrote:
> GKH,

Please don't top-post.

> Just a quick question: the
> handbook(Documentation/process/stable-kernel-rules.rst) really insists
> on putting an upstream commit, but this is an interesting issue that
> goes away with the iomap patchset set for release in v7.2. There isn't
> really an upstream that explicitly fixes it. I don't think it falls
> under any of Options 1, 2 or 3. Should I just remove that line?

If this is not a problem in Linus's tree, and this needs to be fixed in
a stable kernel, you need to document it really really really well why
we can't just take the same commits that are in Linus's tree for the
issue.

And even then I'll push back hard for why this is needed.  Be warned :)

> Also, in the last patch I submitted to you(SEEK_DATA/SEEK_HOLE on
> /dev/null), you were against the idea of using switch...case for
> inaction rather than action on a value. If you ACK, should I just use an
> if statement like so?
> 
> + if (ret < 0 && ret != -ENOSPC && ret != -EINTR)  {

I have no context here at all, sorry.  I'm not a exfat developer, and I
get 1000+ emails a day...

thanks,

greg k-h

  reply	other threads:[~2026-07-13 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  6:19 [PATCH v1] exfat: bail prematurely from exfat_extend_valid_size() upon fatal signal David Timber
2026-07-13  6:53 ` Greg KH
2026-07-13  6:56   ` David Timber
2026-07-13  7:55   ` David Timber
2026-07-13 12:05     ` Greg KH [this message]
2026-07-13 12:14       ` David Timber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071359-overstep-gambling-73b9@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Andy.Wu@sony.com \
    --cc=dxdt@dev.snart.me \
    --cc=linkinjeon@kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=stable@vger.kernel.org \
    --cc=wataru.aoyama@sony.com \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox