From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7540937268B for ; Tue, 14 Jul 2026 23:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784072056; cv=none; b=KgFW3Z80xqI1EdoLfLuzocQ+gtWPMyqTW0onVVO3rWib1Ra/I2/tLuE7t7lHrMDNvJDtsxLScU3PlVz66c5uPgyDORj/NPZszklxxgWU7FIF8lCZc44Ch3VwxYd7d1EKcLPFAXtItItqS4bUN+GsCOBFSRWcrveIMIHQSe7cuLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784072056; c=relaxed/simple; bh=5TwFCZAEOsHT3Nn4KEcZf7mYBhX6jslV4LqzrWwADtk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XdcdI5J2ctzo1sCygeMhc+8gywVDAyNLp4OhlI6kn7v4eYgBkCpmjjNSlM45I9iY76eZlOCQlu7xWCxYKPN8QTLj/ALK6UcBE6XKKbIeXV2dbpy/QknmK7Abj0meKTONkgdC67l+Uo6OS8upKBqdun0MWrX+XP05cGQkiYxPkcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HkFimT4k; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HkFimT4k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4531F00A3D; Tue, 14 Jul 2026 23:34:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784072055; bh=mus0Xdyf4eETswoNYHrFoGzymKNkkkiI3YMgobEEy2g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HkFimT4kKXlyvr1NuTTLUOtTI9C5Nshvwr9gsYqTod8t+kknpSfQJ/3NIjArDflqA Cnu7Ygt2DC3euGDHao7S/A1oerWSWxN0fqFV40j1kNQqVV11McV53xtUfTtQ3bo7mj vKRufHeiNWvne3GQCH/1rahMzErxQc0aJ99gMHQ4U8KPxYL+ThJS7mawVexbILHnxF c0Bwm6P80hj/dQOfhBkHBClEbQfCbj6I8LELjya9UWUV7QRQ1jGO2uKq/bou6r2ynE iZkWrPVOLG8GCjItmmq9k5EIiGY5nSoosmhT5Ecyf7dkGzQvc0afi09bPcj1wuKdLR MLBsaBBIx/Hvw== From: Sasha Levin To: stable@vger.kernel.org Cc: Alexandru Hossu , stable , Luka Gejak , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.10.y 2/2] staging: rtl8723bs: fix heap buffer overflow in rtw_cfg80211_set_wpa_ie() Date: Tue, 14 Jul 2026 19:34:11 -0400 Message-ID: <20260714233411.3592079-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260714233411.3592079-1-sashal@kernel.org> References: <2026071336-divorcee-scope-a8b1@gregkh> <20260714233411.3592079-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexandru Hossu [ Upstream commit 5a752a616e756844388a1a45404db9fc29fec655 ] supplicant_ie is a 256-byte array in struct security_priv. The WPA and WPA2 IE copy paths use: memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen + 2); where wpa_ielen is the raw IE length field (u8, 0-255). When a local user supplies a connect request via nl80211 with a crafted WPA IE of length 255, wpa_ielen + 2 equals 257, overflowing the 256-byte buffer by one byte into the adjacent last_mic_err_time field. rtw_parse_wpa_ie() does not prevent this: its length consistency check compares *(wpa_ie+1) against (u8)(wpa_ie_len-2), which is (u8)(255) == 255 when wpa_ie_len = 257, so the check passes silently. Add explicit bounds checks for both the WPA and WPA2 paths before the memcpy, rejecting any IE whose total size (wpa_ielen + 2) exceeds the supplicant_ie buffer. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable Reviewed-by: Luka Gejak Signed-off-by: Alexandru Hossu Link: https://patch.msgid.link/20260522004531.1038924-4-hossu.alexandru@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index c20fa87c95bd5b..1ed88d36600ec0 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1820,6 +1820,10 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel pwpa = rtw_get_wpa_ie(buf, &wpa_ielen, ielen); if (pwpa && wpa_ielen > 0) { + if (wpa_ielen + 2 > sizeof(padapter->securitypriv.supplicant_ie)) { + ret = -EINVAL; + goto exit; + } if (rtw_parse_wpa_ie(pwpa, wpa_ielen + 2, &group_cipher, &pairwise_cipher, NULL) == _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm = dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeWPAPSK; @@ -1831,6 +1835,10 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel pwpa2 = rtw_get_wpa2_ie(buf, &wpa2_ielen, ielen); if (pwpa2 && wpa2_ielen > 0) { + if (wpa2_ielen + 2 > sizeof(padapter->securitypriv.supplicant_ie)) { + ret = -EINVAL; + goto exit; + } if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen + 2, &group_cipher, &pairwise_cipher, NULL) == _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm = dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeWPA2PSK; -- 2.53.0