From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4C354921A7 for ; Tue, 14 Jul 2026 14:58:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784041103; cv=none; b=r5gpYTnw20xx3iQWSAhtECsoy7LQPCz+uB6BFqRGyE2mIoqODARTF69R4TboF7MBNWPL4T7ex7Vs6M2Ur+I+H+nI+AUyuH+ldtYyKAKpbibfIHdNcOo7CaRD+xLQYRZ6fk0VGjqNeFwNhoL1diqBhrzGI02ydgFxvtomvrCj4+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784041103; c=relaxed/simple; bh=/fkw6MPCtgJlNqjbEjQ0mE5nRMNAbrlkZfN0VXPyqEo=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=P1s3nrAnsfatxMpWPahdeioMM+KrtbFabv6E5xU7oj7pEf/PujDM16SfNSFtgEswP460qkKBOR2DWFKLO9xpSugDXxWdCj0kj5HK95YJ2zSTOQUDs/WGNDToWfMzhaVRiocInhTBehx4/iauZkMf3nSLJz/Wio5nozXZTSRhpOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WT2/vx7x; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WT2/vx7x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35B8A1F00A3A; Tue, 14 Jul 2026 14:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784041101; bh=qIFDizhRLR+SNd5GXdFFZxIbVNZN7xHzIQ5d8zTZfSQ=; h=Subject:To:Cc:From:Date; b=WT2/vx7x7NOhIpOwdoNO4hNnqCQW/721mfpqmIWs0PuTeLThhV6brNFJ999nleF8f znY/6hnKbhK1jFXuG7eqoquGwJgxAsPGDw1qNmWdYdg2sQuJkdKCWSaJgu3HfCOKqZ RigRUTRmLe7jmvuaNQuSKze8x2LOa9krkqTxXl7E= Subject: FAILED: patch "[PATCH] HID: pidff: Use correct effect type in effect update" failed to apply to 5.10-stable tree To: oleg@makarenk.ooo,jkosina@suse.com,lemon.xah@gmail.com,oroundtree1@gmail.com Cc: From: Date: Tue, 14 Jul 2026 16:55:46 +0200 Message-ID: <2026071446-sway-trustless-6174@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x b251598b8bf37300510868f739a79e07800d41ce # git commit -s git send-email --to '' --in-reply-to '2026071446-sway-trustless-6174@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From b251598b8bf37300510868f739a79e07800d41ce Mon Sep 17 00:00:00 2001 From: Oleg Makarenko Date: Tue, 9 Jun 2026 19:00:27 +0300 Subject: [PATCH] HID: pidff: Use correct effect type in effect update MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When updating an existing effect, the effect type from the last created effect was sent to the device instead of the updated one. This caused incorrect reports when a game creates multiple different effects and updates only one that is not the last created. Fixes FFB in multiple games that create multiple simultaneous effects (Forza Horizon 5/6). Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices") Cc: stable@vger.kernel.org Tested-by: Oliver Roundtree Co-developed-by: Ryno Kotzé Signed-off-by: Ryno Kotzé Signed-off-by: Oleg Makarenko Signed-off-by: Jiri Kosina diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index c45f182d0448..5f4395f7c645 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -522,7 +522,7 @@ static void pidff_set_effect_report(struct pidff_device *pidff, pidff->set_effect[PID_EFFECT_BLOCK_INDEX].value[0] = pidff->block_load[PID_EFFECT_BLOCK_INDEX].value[0]; pidff->set_effect_type->value[0] = - pidff->create_new_effect_type->value[0]; + pidff_get_effect_type_id(pidff, effect); pidff_set_duration(&pidff->set_effect[PID_DURATION], effect->replay.length);