From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
Greg Kroah-Hartman <gregkh@kernel.org>,
Weidong Zhu <weizhu@fiu.edu>, Chao Shi <coshi036@gmail.com>
Subject: Re: [PATCH 6.6.y] block: skip sync_blockdev() on surprise removal in bdev_mark_dead()
Date: Thu, 16 Jul 2026 21:37:31 -0400 [thread overview]
Message-ID: <20260716232340.0004-stable-reply@kernel.org> (raw)
In-Reply-To: <20260716073452.3246468-1-coshi036@gmail.com>
On Thu, Jul 16, 2026 at 03:34:52AM -0400, Chao Shi wrote:
> bdev_mark_dead()'s @surprise == true means the device is already gone.
> The filesystem callback fs_bdev_mark_dead() honours this and skips
> sync_filesystem(), but the bare block device path (no ->mark_dead op)
> lost its !surprise guard when the holder ->mark_dead callback was wired
> up (see Fixes), and now calls sync_blockdev() unconditionally, which can
> hang forever waiting on writeback that can no longer complete.
Queued for 6.6, thanks.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-07-17 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 21:20 Please backport 49f06cff50a4 ("block: skip sync_blockdev() on surprise removal in bdev_mark_dead()") to 6.6.y, 6.12.y, 6.18.y Chao S
2026-07-15 4:48 ` Greg KH
2026-07-15 7:46 ` Chao S
2026-07-16 7:34 ` [PATCH 6.6.y] block: skip sync_blockdev() on surprise removal in bdev_mark_dead() Chao Shi
2026-07-17 1:37 ` Sasha Levin [this message]
2026-07-18 2:54 ` Chao S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716232340.0004-stable-reply@kernel.org \
--to=sashal@kernel.org \
--cc=coshi036@gmail.com \
--cc=gregkh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=weizhu@fiu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox