From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90FFE42254E for ; Thu, 16 Jul 2026 12:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784205886; cv=none; b=kTot+1hX7asxvrRtPcMZ5UVpM5Js4ZorLLvKD//+I5HQy1T+MyScw0CLjmtOWeUterg6uL72y5+6ZJ/pqrTGBmIW9kbb7HKvuAG16WKol6vl0Zo9wbqETjmCCzXNsnmz061JzuBTjYDkTMEp4rvA+cRoEF8q5Vl4qe7h9HsRVJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784205886; c=relaxed/simple; bh=ZNEK/dv/ecu+DwuSC1CYj9k2GE8XwnUiUqHjh0Qes2g=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=A1Gml+bpuILfWVl6ngniWCXIeWsTD4S8JOZI89Iv+EyVYvKOyX8TxdE3cqsBWUgjpEkpapPNYb6sCE+IAIZNK4How8tn85wm4VWXd53Qh6A48ImwjenLg+6Asu0w2dwVSQggGa+8Lr25se5Br1Fm/FA6lOGBfRXF/CsQ2jQw7c0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uj23kbBI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uj23kbBI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2D5B1F00A3A; Thu, 16 Jul 2026 12:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784205885; bh=0s6V5MMq5wnxzccoFzjIQ7MMPe1EFjG8dnOlDH33XDE=; h=Subject:To:Cc:From:Date; b=uj23kbBIhn/vpM/TKGu/W3LiyOkua+dDnanWxZkOvegU+kOOPNNtzJDAxWgMqmDfp mJrM09ktS/IjYt9BbDleCP6m/qgykjjYF7vXCZ6YQTq0feW9pynaPcHl9xyrerPV2V +Y4AKWEgzwy2YJAPC1A8ToOLxWx39EnRxLSu+az0= Subject: FAILED: patch "[PATCH] Input: mms114 - reject an oversized device packet size" failed to apply to 5.10-stable tree To: hexlabsecurity@proton.me,dmitry.torokhov@gmail.com Cc: From: Date: Thu, 16 Jul 2026 14:44:38 +0200 Message-ID: <2026071638-seltzer-gambling-3268@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 66725039f7090afe14c31bd259e2059a68f04023 # git commit -s git send-email --to '' --in-reply-to '2026071638-seltzer-gambling-3268@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 66725039f7090afe14c31bd259e2059a68f04023 Mon Sep 17 00:00:00 2001 From: Bryam Vargas Date: Sun, 14 Jun 2026 14:19:43 -0700 Subject: [PATCH] Input: mms114 - reject an oversized device packet size mms114_interrupt() reads a packet of touch data from the device into a fixed-size on-stack buffer struct mms114_touch touch[MMS114_MAX_TOUCH]; which holds MMS114_MAX_TOUCH (10) events of MMS114_EVENT_SIZE (8) bytes, i.e. 80 bytes. The length of the I2C read into it is taken verbatim from the device: packet_size = mms114_read_reg(data, MMS114_PACKET_SIZE); if (packet_size <= 0) goto out; ... error = __mms114_read_reg(data, MMS114_INFORMATION, packet_size, (u8 *)touch); packet_size is a single device register byte (0x0F) and the only check is the lower bound packet_size <= 0; it is never bounded against the size of touch[]. A malfunctioning, malicious or counterfeit controller (or an attacker tampering with the I2C bus) can report a packet_size of up to 255, so __mms114_read_reg() writes up to 175 bytes past the end of touch[] on the IRQ-thread stack: a stack out-of-bounds write that can overwrite the stack canary, saved registers and the return address. A well-formed device never reports more than the buffer holds, so reject an oversized packet and drop the report, consistent with the handler's other error paths, rather than reading past the buffer. Fixes: 07b8481d4aff ("Input: add MELFAS mms114 touchscreen driver") Signed-off-by: Bryam Vargas Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260612-b4-disp-dc4b8dc4-v1-1-d7cb0a828d92@proton.me Signed-off-by: Dmitry Torokhov diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 9597214d9d3c..4d748a13408d 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -226,6 +226,12 @@ static irqreturn_t mms114_interrupt(int irq, void *dev_id) if (packet_size <= 0) goto out; + if (packet_size > sizeof(touch)) { + dev_err(&client->dev, "Invalid packet size %d (max %zu)\n", + packet_size, sizeof(touch)); + goto out; + } + /* MMS136 has slightly different event size */ if (data->type == TYPE_MMS134S || data->type == TYPE_MMS136) touch_size = packet_size / MMS136_EVENT_SIZE;