From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABECA25B09D for ; Sun, 19 Jul 2026 14:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784472829; cv=none; b=jsgWpixmQvtLhBBdLxG6ecdq+FomVZumtm3yHKCoaZtcNTC/cI0aN/2xIfpOvaAA1I9p/Q+6FORm0b/vpj2vgGCzf9G+9A4bq3kp9DR6ytByzyzapT9omsiBygwgqGKxMJudGwnibkNVIAZulQ6RN+9Rt2SnGg2UBVOF2QiHbT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784472829; c=relaxed/simple; bh=BsqiynjGqIq+yetEQa90F65IDB8y2XxIvyKBVND38VA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lOy9SA6VOCtB0qdxmqRvhjugcYGLR40z9zTJGI1YbR3Iwclg9HYXjiv5PdN/ti0eFHTBA0VNMnfyYet+PqzP1LiC/HUbVXicsyR0b9r96XWRC61sHVtSMt41KbvoSb6MAFnZ5JQ99mygWcLyQO/qWZBkvfdm6TBxtPPviwwRo2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LSqjxcVE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LSqjxcVE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD9381F000E9; Sun, 19 Jul 2026 14:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784472828; bh=waU0CWGUbROVTQeNYIm4u3JKJGdTVqrA/4tkcEpw7Aw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LSqjxcVEvbPJYKJIHrNApTixp6uqyiG0jkjnv9VjDotCtnwPFgIx8dw4yBXUBvCKE Zss6mve2AJeW73sc2n5wE30AiUmBf3aDK11JIVrI0Fn6A9JpsDGvJciMAWV7dJyKTa UQo2oyGUPcK6EJzY1X0424hkhpDv69YUmdD1hxBUFK2PjOl2v5OieZ6mRT8j2QT2Qb nmFP0becLWZ+GuWwRZznb7gKurhpRtLLZU7yeWEyXTrpMhOZ79UHZmaXYM8yx0eCcj Jpy8SQYdtg2QowXMxSifeZ4+6RorlVn+Qv2tksr60qEJ3s5h5FNguyESBu8JY1D/Na U65rKgH7eyrvw== From: Sasha Levin To: stable@vger.kernel.org Cc: Dawei Feng , stable , Alan Stern , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.10.y] usb: free iso schedules on failed submit Date: Sun, 19 Jul 2026 10:53:46 -0400 Message-ID: <20260719145346.5460-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026071434-gully-granddad-4bef@gregkh> References: <2026071434-gully-granddad-4bef@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dawei Feng [ Upstream commit b9399d25fbb34a05bbe76eeedd730f62ff2670e9 ] EHCI and FOTG210 isochronous submits build an ehci_iso_sched before linking the URB to the endpoint queue, and keep the staged schedule in urb->hcpriv until iso_stream_schedule() and the link helpers consume it. If the controller is no longer accessible, or usb_hcd_link_urb_to_ep() fails, submit jumps to done_not_linked before that handoff happens and leaks the staged schedule still attached to urb->hcpriv. Free the staged schedule from done_not_linked when submit fails before the URB is linked and clear urb->hcpriv after the free. The bug was first flagged by an experimental analysis tool we are developing for kernel memory-management bugs while analyzing v6.13-rc1. The tool is still under development and is not yet publicly available. Manual inspection confirms that the bug is still present in v7.1.1. An x86_64 allyesconfig build showed no new warnings. As we do not have an EHCI host controller with a USB isochronous device to test with, no runtime testing was able to be performed. Fixes: 8de98402652c ("[PATCH] USB: Fix USB suspend/resume crasher (#2)") Fixes: e9df41c5c589 ("USB: make HCDs responsible for managing endpoint queues") Fixes: 7d50195f6c50 ("usb: host: Faraday fotg210-hcd driver") Cc: stable Signed-off-by: Dawei Feng Reviewed-by: Alan Stern Link: https://patch.msgid.link/20260630071419.349161-1-dawei.feng@seu.edu.cn Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/ehci-sched.c | 11 +++++++++-- drivers/usb/host/fotg210-hcd.c | 6 ++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c index 6dfb242f9a4b9c..11054cc10b89fb 100644 --- a/drivers/usb/host/ehci-sched.c +++ b/drivers/usb/host/ehci-sched.c @@ -1613,6 +1613,7 @@ iso_stream_schedule( status = 1; /* and give it back immediately */ iso_sched_free(stream, sched); sched = NULL; + urb->hcpriv = NULL; } } urb->error_count = skip / period; @@ -1643,8 +1644,6 @@ iso_stream_schedule( return status; fail: - iso_sched_free(stream, sched); - urb->hcpriv = NULL; return status; } @@ -1956,6 +1955,10 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb, usb_hcd_unlink_urb_from_ep(ehci_to_hcd(ehci), urb); } done_not_linked: + if (status < 0) { + iso_sched_free(stream, urb->hcpriv); + urb->hcpriv = NULL; + } spin_unlock_irqrestore(&ehci->lock, flags); done: return status; @@ -2333,6 +2336,10 @@ static int sitd_submit(struct ehci_hcd *ehci, struct urb *urb, usb_hcd_unlink_urb_from_ep(ehci_to_hcd(ehci), urb); } done_not_linked: + if (status < 0) { + iso_sched_free(stream, urb->hcpriv); + urb->hcpriv = NULL; + } spin_unlock_irqrestore(&ehci->lock, flags); done: return status; diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index de925433d4c5f0..104f9458b96bf5 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -4271,8 +4271,6 @@ static int iso_stream_schedule(struct fotg210_hcd *fotg210, struct urb *urb, return 0; fail: - iso_sched_free(stream, sched); - urb->hcpriv = NULL; return status; } @@ -4566,6 +4564,10 @@ static int itd_submit(struct fotg210_hcd *fotg210, struct urb *urb, else usb_hcd_unlink_urb_from_ep(fotg210_to_hcd(fotg210), urb); done_not_linked: + if (status < 0) { + iso_sched_free(stream, urb->hcpriv); + urb->hcpriv = NULL; + } spin_unlock_irqrestore(&fotg210->lock, flags); done: return status; -- 2.53.0