From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF4E20468E for ; Mon, 20 Jul 2026 12:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784550968; cv=none; b=WV7VBBsygp59O7OeqbAYs7gVBC2myqvTQAOXl+Oy++ocVZ3VqgfysGtMIZ/crOI1e+qLHNU5959zovO2zy1IwmuyISBfYFmwEi6mlxiQC9wDHcO12FVC03BkdFlDq+7Ik+oI6G9gypEbtP6LfU5tRDQrzg+WtxYFsqFzuEaN3QM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784550968; c=relaxed/simple; bh=eGYRuauKugcH26SAzv1v2yAbtjPC/w0tpYbgym+AB2w=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=iYb9Annto56caKGTb17QEixbaUkg/tD19joiEoPfZQlGtZ0eguEu04AnF7L/RneUeKWFxtBuLxrSNyIcTXG00sHNvHfVXX4pmYOJq8uYWa4mXesyBglo5dN59mp+yEFuyVeK06AF9A6cmOhlJjTG+s3OOYJmv+T9hnTHfK5CWmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gzwpaYCz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gzwpaYCz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A37341F000E9; Mon, 20 Jul 2026 12:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784550967; bh=zTm2wCJjUHJcj66I4lgqlNrD7RZL+Dk0fTtmYjJyHh4=; h=Subject:To:Cc:From:Date; b=gzwpaYCza/+mfv0BoDzQE3aZoRJINkmkgxHNUKOcTuy8FATcY/m5nYdmF3AMTu+uk bjd6D+NZM3T1/Tg0PcpOqg5AOhiUEQyHl2wGLeL17r7Smf5D/1ob0hfgyrDaRduS84 Cki3nEk+UsibS3nAXn1yVdiK9CJmdn0fSk7jhWLA= Subject: FAILED: patch "[PATCH] netfilter: nf_conntrack_sip: validate skb_dst() before" failed to apply to 6.6-stable tree To: pablo@netfilter.org,fw@strlen.de,n05ec@lzu.edu.cn Cc: From: Date: Mon, 20 Jul 2026 14:34:03 +0200 Message-ID: <2026072003-scorch-encourage-ddad@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x e5e24a365a5e024efef63cc49abb345fbd4852c5 # git commit -s git send-email --to '' --in-reply-to '2026072003-scorch-encourage-ddad@gregkh' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From e5e24a365a5e024efef63cc49abb345fbd4852c5 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Fri, 26 Jun 2026 13:24:49 +0200 Subject: [PATCH] netfilter: nf_conntrack_sip: validate skb_dst() before accessing it tc ingress and openvswitch do not guarantee routing information to be available. These subsystems use the conntrack helper infrastructure, and the SIP helper relies on the skb_dst() to be present if sip_external_media is set to 1 (which is disabled by default as a module parameter). This effectively disables the sip_external_media toggle for these subsystems without resulting in a crash. Fixes: cae3a2627520 ("openvswitch: Allow attaching helpers to ct action") Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") Cc: stable@vger.kernel.org Reported-by: Ren Wei Signed-off-by: Pablo Neira Ayuso Signed-off-by: Florian Westphal diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index 5ec3a4a4bbd7..f3f90a866338 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -956,7 +956,6 @@ static int set_expected_rtp_rtcp(struct sk_buff *skb, unsigned int protoff, return NF_ACCEPT; saddr = &ct->tuplehash[!dir].tuple.src.u3; } else if (sip_external_media) { - struct net_device *dev = skb_dst(skb)->dev; struct dst_entry *dst = NULL; struct flowi fl; @@ -978,7 +977,11 @@ static int set_expected_rtp_rtcp(struct sk_buff *skb, unsigned int protoff, * through the same interface as the signalling peer. */ if (dst) { - bool external_media = (dst->dev == dev); + const struct dst_entry *this_dst = skb_dst(skb); + bool external_media = false; + + if (this_dst && dst->dev == this_dst->dev) + external_media = true; dst_release(dst); if (external_media)