From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3959A42A7AC for ; Mon, 20 Jul 2026 14:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557766; cv=none; b=j5MusBh1P4SafVdlEaj2z9IqM2geFK/5TEMwRWDNODMfLgGeLnjO+p66MkFzVWqS26UgEl+8FWEGd7efK6y/6Gt3r2fc/PAxE7Gt1smM3d+AdhM3ghB9ePYNQ65LZeM6eCbTs00XDV62ql9E6Maw3Sp2ty7uZ8A4cJrb89/GhqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557766; c=relaxed/simple; bh=0j3OrRly1Ezjhk8KMbWpVxPqk5Zb/939gq93LnMO1Kk=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=PRdU1Xx5ySYGzmnVhcsSR16oYY3U8V9eRfxTlInWDhqfLMdZhKeM2vlY/Kh3mUWrnxx0X8FnpN+GpqGWbfnkxNb4adWbJxrinampQLTaALXlK0VEw24ZhX9THFb1mh+NpA24EgaY6/ythqnqKguSFiyAq0UzsHLJE9XVJEbA7us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ANSui0HD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ANSui0HD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6713C1F000E9; Mon, 20 Jul 2026 14:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784557764; bh=UTW31pM6Z3NNnzS8MckdpPRL7uwPZvf0IvdyWMcYNqM=; h=Subject:To:Cc:From:Date; b=ANSui0HDdOFTB3qnTy9rg23cShAapVCq7684PM/LX+l88+VLs9kGNLVJCXNG3oPoc EXUn83UP8tytXny9fhXRhQdXU4iuv/GEK9K05B+Ludu4l8jYPht+WIJJTKmQERsLdv 4cUck1TVZcXTjzCb3YQmI9G54gz84Bs2XqfQujNI= Subject: FAILED: patch "[PATCH] samples/damon/mtier: fail early if address range parameters" failed to apply to 6.18-stable tree To: yuzenghui@huawei.com,akpm@linux-foundation.org,sj@kernel.org,stable@vger.kernel.org Cc: From: Date: Mon, 20 Jul 2026 16:29:08 +0200 Message-ID: <2026072008-humongous-quintuple-a2a9@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 7746d72c64054976887928d64d2caf25c5a6dcc0 # git commit -s git send-email --to '' --in-reply-to '2026072008-humongous-quintuple-a2a9@gregkh' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 7746d72c64054976887928d64d2caf25c5a6dcc0 Mon Sep 17 00:00:00 2001 From: Zenghui Yu Date: Mon, 29 Jun 2026 07:44:31 -0700 Subject: [PATCH] samples/damon/mtier: fail early if address range parameters are invalid The comment on top of `struct damon_region` clearly says that For any use case, @ar should be non-zero positive size. which is now verified in damon_verify_new_region() if the kernel is built with DAMON_DEBUG_SANITY. The WARN_ONCE() can be triggered if the mtier sample module is enabled before node{0,1}_{start,end}_addr have been properly initialized, which is obviously not good. ------------[ cut here ]------------ start 0 >= end 0 WARNING: mm/damon/core.c:217 at damon_new_region+0xf4/0x118, CPU#59: bash/341468 Call trace: damon_new_region+0xf4/0x118 (P) damon_set_regions+0xfc/0x3c0 damon_sample_mtier_build_ctx+0xe8/0x3a8 damon_sample_mtier_start+0x1c/0x90 damon_sample_mtier_enable_store+0x98/0xb0 param_attr_store+0xb4/0x128 module_attr_store+0x2c/0x50 sysfs_kf_write+0x58/0x90 kernfs_fop_write_iter+0x16c/0x238 vfs_write+0x2c0/0x370 ksys_write+0x74/0x118 __arm64_sys_write+0x24/0x38 invoke_syscall+0xa8/0x118 el0_svc_common.constprop.0+0x48/0xf0 do_el0_svc+0x24/0x38 el0_svc+0x54/0x370 el0t_64_sync_handler+0xa0/0xe8 el0t_64_sync+0x1ac/0x1b0 ---[ end trace 0000000000000000 ]--- Note that the same issue can happen if detect_node_addresses is true, and node 0 or 1 is memoryless. Fix it together by checking the validity of parameters right before damon_new_region() and fail early if they're invalid. Link: https://lore.kernel.org/20260629144432.133962-1-sj@kernel.org Fixes: 82a08bde3cf7 ("samples/damon: implement a DAMON module for memory tiering") Signed-off-by: Zenghui Yu Signed-off-by: SJ Park Reviewed-by: SJ Park Cc: # 6.16.x Signed-off-by: Andrew Morton diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index eb1143de8df1..3785b0c7ffb1 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -120,6 +120,9 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) addr.end = promote ? node1_end_addr : node0_end_addr; } + if (addr.start >= addr.end) + goto free_out; + range.start = addr.start; range.end = addr.end;