From: Liew Rui Yan <aethernet65535@gmail.com>
To: yikai@z1k.dev
Cc: aethernet65535@gmail.com, sj@kernel.org, stable@vger.kernel.org
Subject: Re: [6.1.176 regression] damon_reclaim.enabled broken
Date: Mon, 20 Jul 2026 17:28:40 +0800 [thread overview]
Message-ID: <20260720092840.238806-1-aethernet65535@gmail.com> (raw)
In-Reply-To: <CANMyjpgq5n0Ekt4dgyLRHGb89_Ew0aOMZ3j32V_w0GjHkqH1FQ@mail.gmail.com>
Hi Yikai,
Thank you for reporting this issue :>
I just investigated the problem and found the root cause. It looks like
a typo in damon_reclaim_timer_fn(), where '!=' was used instead of '=='
(unlike damon_lru_sort), which caused the delayed work to return early
and fail to enable during early boot.
Comparison
==========
/* DAMON_RECLAIM */
static void damon_reclaim_timer_fn(struct work_struct *work)
{
bool now_enabled;
now_enabled = enabled;
if (damon_reclaim_enabled() != now_enabled)
return;
damon_reclaim_turn(now_enabled);
}
/* DAMON_LRU_SORT */
static void damon_lru_sort_timer_fn(struct work_struct *work)
{
bool now_enabled;
now_enabled = enabled;
if (damon_lru_sort_enabled() == now_enabled)
return;
damon_lru_sort_turn(now_enabled);
}
This appears to affect only version .176 and .177 (introduced by
2f54908fae211).
I will send out the fix patch as soon as possible!
Best regards,
Rui Yan
next prev parent reply other threads:[~2026-07-20 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 3:44 [6.1.176 regression] damon_reclaim.enabled broken Yikai Zhao
2026-07-20 9:28 ` Liew Rui Yan [this message]
2026-07-20 15:28 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720092840.238806-1-aethernet65535@gmail.com \
--to=aethernet65535@gmail.com \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yikai@z1k.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox