Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
	Shivam Kumar <kumar.shivam43666@gmail.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 5.10.y] nvmet-tcp: Fix potential UAF when ddgst mismatch
Date: Mon, 20 Jul 2026 20:56:25 -0400	[thread overview]
Message-ID: <20260720175500.0018-stable-reply@kernel.org> (raw)
In-Reply-To: <20260720140748.17471-1-kumar.shivam43666@gmail.com>

> When data digest is enabled on an NVMe/TCP connection and a digest
> mismatch occurs on a non-final H2C_DATA PDU during an R2T-based
> data transfer, the digest error handler in nvmet_tcp_try_recv_ddgst()
> calls nvmet_req_uninit() - which performs percpu_ref_put() on the
> submission queue - but does NOT mark the command as completed.

This one doesn't apply to linux-5.10.y: the diff context assumes
4606467a75cf ("nvmet-tcp: check INIT_FAILED before nvmet_req_uninit in
digest error path") and the nvmet_tcp_finish_cmd() removal, neither of
which is in 5.10.y -- the ddgst error path there still calls
nvmet_tcp_finish_cmd(cmd).

Your 5.10.y backport of 4606467a75cf was queued today, so could you
send a v2 of this patch generated on top of it? The end state in your
patch looks correct and can stay as-is.

-- 
Thanks,
Sasha

  reply	other threads:[~2026-07-21  0:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 12:14 FAILED: patch "[PATCH] nvmet-tcp: Fix potential UAF when ddgst mismatch" failed to apply to 5.10-stable tree gregkh
2026-07-20 14:07 ` [PATCH 5.10.y] nvmet-tcp: Fix potential UAF when ddgst mismatch Shivam Kumar
2026-07-21  0:56   ` Sasha Levin [this message]
2026-07-21 13:58     ` [PATCH v2 " Shivam Kumar
2026-07-22  0:53       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720175500.0018-stable-reply@kernel.org \
    --to=sashal@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kumar.shivam43666@gmail.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox