From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>, Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCH 5.10.y] batman-adv: clean untagged VLAN on netdev registration failure
Date: Mon, 20 Jul 2026 20:56:30 -0400 [thread overview]
Message-ID: <20260720175500.0023-stable-reply@kernel.org> (raw)
In-Reply-To: <20260720134709.650871-1-sven@narfation.org>
> The register_netdevice() call will try to clean up the net_device using
> unregister_netdevice_queue() - which only uses the .priv_destructor to
> free private resources. In this situation, .dellink will not be called.
On 5.10 this move regresses normal interface removal: 5.10 still has
the legacy sysfs code, and batadv_softif_destroy_netlink() removes the
mesh kobject via batadv_sysfs_del_meshif() before the untagged VLAN
cleanup (now running from batadv_mesh_free()) gets to
batadv_sysfs_del_vlan(), so every plain "ip link del" hits a kernfs
WARN (a panic under panic_on_warn).
Could you send a v2 for 5.10 that keeps the untagged VLAN destroy in
batadv_softif_destroy_netlink() and only adds the batadv_mesh_free()
fallback for the registration-veto path?
I've queued the 6.12/6.6/6.1/5.15 versions.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-07-21 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 12:43 FAILED: patch "[PATCH] batman-adv: clean untagged VLAN on netdev registration" failed to apply to 5.10-stable tree gregkh
2026-07-20 13:47 ` [PATCH 5.10.y] batman-adv: clean untagged VLAN on netdev registration failure Sven Eckelmann
2026-07-21 0:56 ` Sasha Levin [this message]
2026-07-21 8:46 ` Sven Eckelmann
2026-07-21 8:51 ` [PATCH 5.10.y v2] " Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720175500.0023-stable-reply@kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox