From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C733D3C3BFD for ; Mon, 20 Jul 2026 20:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784580273; cv=none; b=OTdV1eymWgApk2rVJSp2U/69HndBO1x+YTuTGfQ+gNzrXxzDvVZTenWawmpktK6DA2/VtyVXxCr4m1JllixIj88bLFWGLkim70l8PHDGkLFrr0CkARQqUUPS72ZZAQ1bCGcIbWb4zJYqWOxjQWaYPHmqpnJksAx8RNFveMAHyNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784580273; c=relaxed/simple; bh=w+deUUWsuCQXLgUeu37b8jjpkUjxhdckCUrD0oMIIvk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SzwGztIBrypuJZF8V6Z4Rp528r4Gv0iTGUbGZJ3e9MMrD785PXqGIiw6c22A1Qq7riKsxlLjQVfwqIuBrRH0dkxA0XT8LDM2B39mstNFUYauZmMt9d6UaPFy2QI0CTbfUKqIYzVzzgBKUmTll8BuEGl5k4odM6RlEare23SkHYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SblC2x67; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SblC2x67" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A511F000E9; Mon, 20 Jul 2026 20:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784580272; bh=bhM+nnPv1CjCpNN5bZwnxrHZZu6am7LDb2SeWLxySyQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SblC2x67oAaZn7BFZH3Jcg5Lxm6wPuzEJcSOcwZOO6dHXgidyEP5mV8w/VoowfLKX CATiFly2Rayb9TPojGXQvLZqT0AJjNDOLpDTWlFueFHdomumrHzF1rh1iUnmUe/pT0 As5JKN+gPQk0BMFZVT/BQYPoXwH0wtrRRa0H9vrkUSLtBHDqebEA7chBVBcta34qTR r6AI6bsRuosbvWSKcrEzjHnqI1QnsWqvvxENAqY+mMWFjJQYR93MKHVhU4hWXiDLb6 kIxBBXR2m+gadD/LlFZNDVymA90HCawWMioMXLcAsbgFaIS7Y5fNCd4/2/P66c5SrI +cmm0MvOzv5/Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Ahsan Atta , Maksim Lukoshkov , Giovanni Cabiddu , Herbert Xu , Sasha Levin Subject: [PATCH 5.10.y] crypto: qat - fix restarting state leak on allocation failure Date: Mon, 20 Jul 2026 16:44:29 -0400 Message-ID: <20260720204429.3338926-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026071552-citrus-stump-8aa1@gregkh> References: <2026071552-citrus-stump-8aa1@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ahsan Atta [ Upstream commit 7d3ed20f7e46b3e991936fedd7a28f3ff4aec8d2 ] In adf_dev_aer_schedule_reset(), ADF_STATUS_RESTARTING is set before allocating reset_data. If the allocation fails, the function returns -ENOMEM without queuing reset work, so nothing ever clears the bit. This leaves the device permanently stuck in the restarting state, causing all subsequent reset attempts to be silently skipped. Fix this by using test_and_set_bit() to atomically claim the RESTARTING state, preventing duplicate reset scheduling races under concurrent fatal error reporting. If the subsequent allocation fails, clear the bit to restore clean state so future reset attempts can proceed. Cc: stable@vger.kernel.org Fixes: d8cba25d2c68 ("crypto: qat - Intel(R) QAT driver framework") Signed-off-by: Ahsan Atta Co-developed-by: Maksim Lukoshkov Signed-off-by: Maksim Lukoshkov Reviewed-by: Giovanni Cabiddu Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/qat/qat_common/adf_aer.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c index bf6e2116148b5a..4b2378b726379a 100644 --- a/drivers/crypto/qat/qat_common/adf_aer.c +++ b/drivers/crypto/qat/qat_common/adf_aer.c @@ -116,13 +116,14 @@ static int adf_dev_aer_schedule_reset(struct adf_accel_dev *accel_dev, struct adf_reset_dev_data *reset_data; if (!adf_dev_started(accel_dev) || - test_bit(ADF_STATUS_RESTARTING, &accel_dev->status)) + test_and_set_bit(ADF_STATUS_RESTARTING, &accel_dev->status)) return 0; - set_bit(ADF_STATUS_RESTARTING, &accel_dev->status); reset_data = kzalloc(sizeof(*reset_data), GFP_KERNEL); - if (!reset_data) + if (!reset_data) { + clear_bit(ADF_STATUS_RESTARTING, &accel_dev->status); return -ENOMEM; + } reset_data->accel_dev = accel_dev; init_completion(&reset_data->compl); reset_data->mode = mode; -- 2.53.0