From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 194B5390CBF for ; Tue, 21 Jul 2026 00:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784594712; cv=none; b=o0mRSIbC/THFS5gwQguGCaswALa0lka4jOoiUv98FeoFgEz8XQhvrodaZfOA4hoxIOmLzW3cXyFH5Qd6heRH9ycJtJ6Fnjng3wDKU6auHh2LDUXnLk/btVKnLPs7LjINlttNpigb/o0ZI0qmQAfilqkQOpVo6W1IB+21f18PNR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784594712; c=relaxed/simple; bh=rqs2woQGU4CbfWKESyVMi5BCJ0IoOT6sr9fLCPDiCHA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KH0brc7rLe4nWAL83hJQLU4Z/rv13d5ZtDeILzwqMa0X9NU7Ueu/8cE8NyCNKMA3PQYAZqLF/zbeK3qATsxJsqHf5Nu3JjW51cjkslWPt2nXS8MAcn5/xucTVdV7cy+niiF/bVMM4xN8HjxidYYj/ZH1MwumIdX9f92ejpHG8gc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fmQDS3Lf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fmQDS3Lf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 534F21F000E9; Tue, 21 Jul 2026 00:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784594711; bh=xN0oMcuAE2vi7HkBZOUG8Ttb1Hegf/AZALaW57EeKiA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fmQDS3Lf6APhOJDqkFQc41PuU1I6A4y70aciHvtEHWoNREXu/FJ7lHUw657tj89px wA1zqVhcslrt/Pxpg7qNmK0ZryC14jFDx8WwiuleMbP+U14Wich9/nZtjMOnNcCjFr WzgB2e7U3sBqBwg0th8bh0sHIxGOtBY51OhBxCO7XDSi9o9hABtdGyIfoevB95n40l /Tqccw7Fz0OXOtWpRc++pmMcD+QTcB25fkSACjcULKAaIwZkZuqDzf0/UinDeckWpW uuDECuzBSvLhJ1Q+3vHrb1sEzseX39szpID0RiN16YI5UwBh74zX91dAr4hH2E1Jpw lklDmufir0+Eg== From: Sasha Levin To: stable@vger.kernel.org Cc: Giovanni Cabiddu , Ahsan Atta , Laurent M Coquerel , Herbert Xu , Sasha Levin Subject: [PATCH 5.15.y] crypto: qat - validate RSA CRT component lengths Date: Mon, 20 Jul 2026 20:45:08 -0400 Message-ID: <20260721004508.3421467-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026071550-encrypt-hypnotist-52ba@gregkh> References: <2026071550-encrypt-hypnotist-52ba@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Giovanni Cabiddu [ Upstream commit b3ac78756588059729b9195fcc9f4b37d54057a5 ] The generic RSA key parser (rsa_helper.c) bounds each CRT component (p, q, dp, dq, qinv) by the modulus size n_sz, but qat_rsa_setkey_crt() allocates half-size DMA buffers (key_sz / 2) and right-aligns each component with: memcpy(dst + half_key_sz - len, src, len) When a CRT component is larger than half_key_sz the subtraction underflows and memcpy writes past the DMA buffer, causing memory corruption. Add a len > half_key_sz check next to the existing !len check for each of the five CRT components so the driver falls back to the non-CRT path instead of writing out of bounds. Fixes: 879f77e9071f ("crypto: qat - Add RSA CRT mode") Cc: stable@vger.kernel.org Signed-off-by: Giovanni Cabiddu Reviewed-by: Ahsan Atta Reviewed-by: Laurent M Coquerel Tested-by: Laurent M Coquerel Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/qat/qat_common/qat_asym_algs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c index 4128200a903293..4437c3a5c6dd73 100644 --- a/drivers/crypto/qat/qat_common/qat_asym_algs.c +++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c @@ -1032,7 +1032,7 @@ static void qat_rsa_setkey_crt(struct qat_rsa_ctx *ctx, struct rsa_key *rsa_key) ptr = rsa_key->p; len = rsa_key->p_sz; qat_rsa_drop_leading_zeros(&ptr, &len); - if (!len) + if (!len || len > half_key_sz) goto err; ctx->p = dma_alloc_coherent(dev, half_key_sz, &ctx->dma_p, GFP_KERNEL); if (!ctx->p) @@ -1043,7 +1043,7 @@ static void qat_rsa_setkey_crt(struct qat_rsa_ctx *ctx, struct rsa_key *rsa_key) ptr = rsa_key->q; len = rsa_key->q_sz; qat_rsa_drop_leading_zeros(&ptr, &len); - if (!len) + if (!len || len > half_key_sz) goto free_p; ctx->q = dma_alloc_coherent(dev, half_key_sz, &ctx->dma_q, GFP_KERNEL); if (!ctx->q) @@ -1054,7 +1054,7 @@ static void qat_rsa_setkey_crt(struct qat_rsa_ctx *ctx, struct rsa_key *rsa_key) ptr = rsa_key->dp; len = rsa_key->dp_sz; qat_rsa_drop_leading_zeros(&ptr, &len); - if (!len) + if (!len || len > half_key_sz) goto free_q; ctx->dp = dma_alloc_coherent(dev, half_key_sz, &ctx->dma_dp, GFP_KERNEL); @@ -1066,7 +1066,7 @@ static void qat_rsa_setkey_crt(struct qat_rsa_ctx *ctx, struct rsa_key *rsa_key) ptr = rsa_key->dq; len = rsa_key->dq_sz; qat_rsa_drop_leading_zeros(&ptr, &len); - if (!len) + if (!len || len > half_key_sz) goto free_dp; ctx->dq = dma_alloc_coherent(dev, half_key_sz, &ctx->dma_dq, GFP_KERNEL); @@ -1078,7 +1078,7 @@ static void qat_rsa_setkey_crt(struct qat_rsa_ctx *ctx, struct rsa_key *rsa_key) ptr = rsa_key->qinv; len = rsa_key->qinv_sz; qat_rsa_drop_leading_zeros(&ptr, &len); - if (!len) + if (!len || len > half_key_sz) goto free_dq; ctx->qinv = dma_alloc_coherent(dev, half_key_sz, &ctx->dma_qinv, GFP_KERNEL); -- 2.53.0