From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF1343C7DD; Tue, 21 Jul 2026 21:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784668244; cv=none; b=UXX4qO+lQHVps4rcOqmwL4B0f7DwcviAZk1EduE2DnPzuVdkYaM3X7mE1I5KVc2kaeo3TbRbavYFj+pYgHW+F4lvdP72t6eG89OS7OjgU4yenAiex/tJd7KxLUQ956rSaupZ3k+sY9odVM+zVgVDHDPkMxLAw8ZSikACG2UUeWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784668244; c=relaxed/simple; bh=+cSn2OSF7FmQWaltNgz67tI7YljwPWu8w6ZsTLsX+pw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pTWFdbrN2MMksrFUPsCXF+ywWdsg3quuPTX9M0SDoQ1jDvRbP7/oc3d8chsah4ODE20wdYcAg1m9LEjGXrj1jNIIazDeO0W7ZL8tVDM4e0PySS4ZkfCFPE1RfVUM2PvSG7EAsJjH4YMNYj87mwbRPa6TPSdtGwVdIYlvfc22CmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AI3Zifcl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AI3Zifcl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 733B31F000E9; Tue, 21 Jul 2026 21:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784668243; bh=ngLRn87P2QXa3dUDSkPRkU8NY4VTlLAxHVm/oaEeFCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AI3ZifclEmiNWoWV45QQyeXP8EuHAblTuYIdOzFxICiVa0YIXJ9MHsl5u1r2vV0O4 P02Te2PLy4Zjn/GrE3WNcEzwtiK6GcGTXDZBdfkfoTJghGJrcmjS8dck5agb8LY3NH zuwZOSpwvm3J8iIjknGdwwXvbCVIp/6x+1RW2mNA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joshua Crofts , Pengpeng Hou , Andy Shevchenko , Jonathan Cameron Subject: [PATCH 6.1 0058/1067] iio: adc: ti-ads124s08: Return reset GPIO lookup errors Date: Tue, 21 Jul 2026 17:10:59 +0200 Message-ID: <20260721152425.863485579@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou commit 7dc4de2aa6316f1d044cde21f5acfec5f3ec6b47 upstream. devm_gpiod_get_optional() returns NULL when the optional GPIO is absent, but returns an ERR_PTR when the GPIO provider lookup fails, including probe deferral. Probe currently logs the ERR_PTR case as if the reset GPIO were simply absent and keeps the error pointer in reset_gpio. Later ads124s_reset() treats any non-NULL reset_gpio as a valid descriptor and passes it to gpiod_set_value_cansleep(). Return the lookup error instead of retaining the ERR_PTR. Fixes: e717f8c6dfec ("iio: adc: Add the TI ads124s08 ADC code") Cc: stable@vger.kernel.org Reviewed-by: Joshua Crofts Signed-off-by: Pengpeng Hou Reviewed-by: Andy Shevchenko Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/ti-ads124s08.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/iio/adc/ti-ads124s08.c +++ b/drivers/iio/adc/ti-ads124s08.c @@ -322,7 +322,8 @@ static int ads124s_probe(struct spi_devi ads124s_priv->reset_gpio = devm_gpiod_get_optional(&spi->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ads124s_priv->reset_gpio)) - dev_info(&spi->dev, "Reset GPIO not defined\n"); + return dev_err_probe(&spi->dev, PTR_ERR(ads124s_priv->reset_gpio), + "Failed to get reset GPIO\n"); ads124s_priv->chip_info = &ads124s_chip_info_tbl[spi_id->driver_data];