From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B2C343E06C; Tue, 21 Jul 2026 21:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669876; cv=none; b=k5Wh3BA03mkKK+Eb/aiA2qPEElWZik5xio4RdCRlqI7KWoC6I2L9EfOnScrwz0wGfTdpPjCBeYsFUblvs9ps2TPoGdnJzIVcfdND/krgbh8U5hyaiPpD6QCf0WDyfBdILq8Kw/sIltKiFqpOp3e3wMC2aEVv4ne1vtrbRrHKf0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669876; c=relaxed/simple; bh=ez1bAHfSEQrwp329s6V9nXsrPgocDoAN6I9pWISiS2U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dfw2n6gwiEvo53mSp9kSSWkj4JS+eQyqAHNnrEE7WSdLQLjTsuCwoOiu+Txeo03eskcIN+vEGkZ+ZvKLTYO1Tur4jZ5iGGZcZAbgd9BGEUDyms0iX/XTdhGvV+j2lJD/DbV17hEr2A7TTE7s4Y9aHJd/NAiB++aOWnmmeB4IdOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CDGFpMSF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CDGFpMSF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B35A1F000E9; Tue, 21 Jul 2026 21:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784669873; bh=gHnn2ZeYc7TCyV0pMPSRvFSa8r7YfuhCwcoSFK4LBZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CDGFpMSF55f1S5ohifaB7rY6v3IDkZcMFR2dVrNek+EpUuyPurUyT37TrKgK1LEOJ 8JTBEJxhB5mjVw8wO6y/gtFv9mUAKvHQUpj66JW5ybiCOgoPkGCklOJ22GUjQRz9rS wSHaWVSY0CXxDA/ev43zmpl9F1q431qdEFav646w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Michael Bommarito , Simon Horman , Jakub Kicinski Subject: [PATCH 6.1 0719/1067] net: qrtr: fix 32-bit integer overflow in qrtr_endpoint_post() Date: Tue, 21 Jul 2026 17:22:00 +0200 Message-ID: <20260721152440.672879172@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michael Bommarito commit 20054869770c7df060c5ecee3e8bbf9029c47191 upstream. qrtr_endpoint_post() validates an incoming packet with if (!size || len != ALIGN(size, 4) + hdrlen) goto err; where size comes from the wire. On 32-bit, size_t is 32 bits and ALIGN(size, 4) wraps to 0 for size >= 0xfffffffd, so the check passes and skb_put_data(skb, data + hdrlen, size) writes past the hdrlen-sized skb and oopses the kernel. 64-bit is unaffected. This is the 32-bit residual of ad9d24c9429e2 ("net: qrtr: fix OOB Read in qrtr_endpoint_post"), which fixed only the 64-bit case. Reject any size that cannot fit the buffer before the ALIGN. Fixes: ad9d24c9429e2 ("net: qrtr: fix OOB Read in qrtr_endpoint_post") Cc: stable@vger.kernel.org Signed-off-by: Michael Bommarito Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260611125455.2352279-1-michael.bommarito@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/qrtr/af_qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/qrtr/af_qrtr.c +++ b/net/qrtr/af_qrtr.c @@ -491,7 +491,7 @@ int qrtr_endpoint_post(struct qrtr_endpo goto err; } - if (!size || len != ALIGN(size, 4) + hdrlen) + if (!size || size > len || len != ALIGN(size, 4) + hdrlen) goto err; if ((cb->type == QRTR_TYPE_NEW_SERVER ||