From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0EFE417D67 for ; Tue, 21 Jul 2026 19:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784661240; cv=none; b=Uv7W2cgk1sSXKAGe/NSaYYfxupV5DrvfbyniiQEDtdTDtBpHFFQAGU4nNAr1xvda6XAOHOp5xR1KaHNfGgrS+GKRmcbXzZQLdsfi16i+EteHSCNHTAeQ3r0xK3TxW7xqXzx2K1N9pYJI8gUAt3XE7Fj6Zt72hFB2rq+EGn9br7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784661240; c=relaxed/simple; bh=INqRfMxZtKzOKya0am/+atTQ7tY8lwia4tkkvo6uNhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hJHVcQs6Xt/7yvZGzUTRQEuLnEQVGfJzTkX6QdXcLaZL4SZ4YV/Z5p9wv06a+FT5WRFxXAvi6uyGdBwC5YevL6qCCiP0luGhWXK1DGXv09aBRhp/Kv2MUt+GlGbQlnTjJ1rOGKnMjf8RHv//46qrG8PfZJ1QjEf4HecmU9Cz3T8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mAlrtpfp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mAlrtpfp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69DB61F00A3D; Tue, 21 Jul 2026 19:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784661238; bh=lurHaPqg1lgXMB93gDnmBezmTsR8UoNLNYkHnMV0u6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mAlrtpfprelAuMb5Kgu/+4cmEkguQKlkgSFB6Q6YQOfQXtxQWu1eOt0s9prPzJpq1 13JMupMl+zrHi4kphWNHPaW7AplM8Kqx1kBds5Ojc2A4oROeOimG6K55dRLsY50P4d NyParhBVO6NSlQRiJI/ADOiF+GD/FtpLAHCi8rgNwLJbaCZPva8NSOispU+IK4HU3M W8NFS4SB4jozLjtB36KC+Y57R/Hte9POhw61mBh5eRTMsKSDBL1qcDj996bn36I3xJ wNif3Ywwd5WlwBnBuzu/3zvRm3hb+VDRxEqI6hyn2xJ0Xj7PqaNUrkr/V0eL4FJzT3 0Z8aWSmDYCBuQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Mikhail Gavrilov , Vivek Kasireddy , Sasha Levin Subject: [PATCH 5.10.y 2/2] dma-buf/udmabuf: skip redundant cpu sync to fix cacheline EEXIST warning Date: Tue, 21 Jul 2026 15:13:56 -0400 Message-ID: <20260721191356.403244-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721191356.403244-1-sashal@kernel.org> References: <2026071652-riveter-energy-4da7@gregkh> <20260721191356.403244-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mikhail Gavrilov [ Upstream commit 504e2b4ab97a51d56d966cd36d0997ad30b65b2d ] When CONFIG_DMA_API_DEBUG_SG is enabled, importing a udmabuf into a DRM driver (e.g. amdgpu for video playback in GNOME Videos / Showtime) triggers a spurious warning: DMA-API: amdgpu 0000:03:00.0: cacheline tracking EEXIST, \ overlapping mappings aren't supported WARNING: kernel/dma/debug.c:619 at add_dma_entry+0x473/0x5f0 The call chain is: amdgpu_cs_ioctl -> amdgpu_ttm_backend_bind -> dma_buf_map_attachment -> [udmabuf] map_udmabuf -> get_sg_table -> dma_map_sgtable(dev, sg, direction, 0) // attrs=0 -> debug_dma_map_sg -> add_dma_entry -> EEXIST This happens because udmabuf builds a per-page scatter-gather list via sg_set_folio(). When begin_cpu_udmabuf() has already created an sg table mapped for the misc device, and an importer such as amdgpu maps the same pages for its own device via map_udmabuf(), the DMA debug infrastructure sees two active mappings whose physical addresses share cacheline boundaries and warns about the overlap. The DMA_ATTR_SKIP_CPU_SYNC flag suppresses this check in add_dma_entry() because it signals that no CPU cache maintenance is performed at map/unmap time, making the cacheline overlap harmless. All other major dma-buf exporters already pass this flag: - drm_gem_map_dma_buf() passes DMA_ATTR_SKIP_CPU_SYNC - amdgpu_dma_buf_map() passes DMA_ATTR_SKIP_CPU_SYNC The CPU sync at map/unmap time is also redundant for udmabuf: begin_cpu_udmabuf() and end_cpu_udmabuf() already perform explicit cache synchronization via dma_sync_sgtable_for_cpu/device() when CPU access is requested through the dma-buf interface. Pass DMA_ATTR_SKIP_CPU_SYNC to dma_map_sgtable() and dma_unmap_sgtable() in udmabuf to suppress the spurious warning and skip the redundant sync. Fixes: 284562e1f348 ("udmabuf: implement begin_cpu_access/end_cpu_access hooks") Cc: stable@vger.kernel.org Signed-off-by: Mikhail Gavrilov Acked-by: Vivek Kasireddy Signed-off-by: Vivek Kasireddy Link: https://patch.msgid.link/20260331061657.79983-1-mikhail.v.gavrilov@gmail.com Signed-off-by: Sasha Levin --- drivers/dma-buf/udmabuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 15b8656abb9f84..23ec52b4387c9a 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -67,7 +67,7 @@ static struct sg_table *get_sg_table(struct device *dev, struct dma_buf *buf, if (ret < 0) goto err_alloc; - ret = dma_map_sgtable(dev, sg, direction, 0); + ret = dma_map_sgtable(dev, sg, direction, DMA_ATTR_SKIP_CPU_SYNC); if (ret < 0) goto err_map; return sg; @@ -82,7 +82,7 @@ static struct sg_table *get_sg_table(struct device *dev, struct dma_buf *buf, static void put_sg_table(struct device *dev, struct sg_table *sg, enum dma_data_direction direction) { - dma_unmap_sgtable(dev, sg, direction, 0); + dma_unmap_sgtable(dev, sg, direction, DMA_ATTR_SKIP_CPU_SYNC); sg_free_table(sg); kfree(sg); } -- 2.53.0