From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97AB43BBFD1 for ; Tue, 21 Jul 2026 09:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784625302; cv=none; b=fY51MCLI+l/ELGMeGOacGFBiZyOW8yWWidVZK4tNsKr8beX2WsfT5EFiLduZ3rKutDezF/JuX3WbrUJ30a5cdnsBq4xqObywl3OJeY9+YFEmy2tEpVm9NveOO99wI1eOSpnBCX09hhNgf7wtfh5UvERh1BEo82ITEmNYNYW34q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784625302; c=relaxed/simple; bh=fLOEPsXdtryR9wubQBoQMUMG6aQCI0TJlvE5FgOFgXQ=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=d9Casqu18NNQ+/2y0p/H+LfDpVrII+0sMvJOcaK9s77qWfMJTnf8X47sEpQFhUCqnARvwYqpmEUlYKMmwcsPw8BQF4eidnxpfAH87VepzU+J4aKsXE5cx6ZTA5vwoSjw5I0SdR1ivTrurkgYMfEtTd9a0wPHyhBTwJ8d5jGSdHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gEAsfxXk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gEAsfxXk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 022E11F00A3A; Tue, 21 Jul 2026 09:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784625301; bh=aDzOQ5c90O3XEukuPm+A0gPFmildZj/s+BgjC8sk9xQ=; h=Subject:To:Cc:From:Date; b=gEAsfxXk5aTlEaYQ2QoBSZFDJHYfzdhjFIKP5WS8AyOmIJML1Pmfe6XBCPuWpqiwH qc/Ej01xi2BoT6Z94BsL18NoKxi8hqDFf+BluxOCTa+TE7/F8NDV/UZPsPyFt+MWwB q0SP99L50pwGJ+2ZCxl5E6ET6tVWAjPI/C0K42ng= Subject: FAILED: patch "[PATCH] net: macb: drop in-flight Tx SKBs on close" failed to apply to 6.1-stable tree To: theo.lebrun@bootlin.com,nb@tipi-net.de,pabeni@redhat.com Cc: From: Date: Tue, 21 Jul 2026 11:14:41 +0200 Message-ID: <2026072141-confess-wrinkly-83cf@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 27f575836cfebbf872dec020428742b10650a955 # git commit -s git send-email --to '' --in-reply-to '2026072141-confess-wrinkly-83cf@gregkh' --subject-prefix 'PATCH 6.1.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 27f575836cfebbf872dec020428742b10650a955 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20Lebrun?= Date: Thu, 2 Jul 2026 17:37:02 +0200 Subject: [PATCH] net: macb: drop in-flight Tx SKBs on close MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The MACB driver has since forever leaked the outgoing SKBs that have not yet been marked as completed. They live in queue->tx_skb which gets freed without remorse nor checking. macb_free_consistent() gets called in a few codepaths, but only close will trigger the added expressions. In macb_open() and macb_alloc_consistent() failure cases, queues' tx_skb just got allocated and are empty. Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver") Cc: stable@vger.kernel.org Reviewed-by: Nicolai Buchwitz Signed-off-by: Théo Lebrun Link: https://patch.msgid.link/20260702-macb-drop-tx-v4-1-1c833eebdbc8@bootlin.com Signed-off-by: Paolo Abeni diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index fd282a1700fb..d394f1f43b68 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -2668,8 +2668,25 @@ static void macb_free_consistent(struct macb *bp) dma_free_coherent(dev, size, bp->queues[0].rx_ring, bp->queues[0].rx_ring_dma); for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) { - kfree(queue->tx_skb); - queue->tx_skb = NULL; + if (queue->tx_skb) { + unsigned int dropped = 0, tail; + + for (tail = queue->tx_tail; tail != queue->tx_head; + tail++) { + if (macb_tx_skb(queue, tail)->skb) + dropped++; + macb_tx_unmap(bp, macb_tx_skb(queue, tail), 0); + } + + queue->stats.tx_dropped += dropped; + bp->dev->stats.tx_dropped += dropped; + + kfree(queue->tx_skb); + queue->tx_skb = NULL; + } + + queue->tx_head = 0; + queue->tx_tail = 0; queue->tx_ring = NULL; queue->rx_ring = NULL; }