From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54F33353A88 for ; Wed, 22 Jul 2026 13:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784728486; cv=none; b=hRSY6BvGWVx3f7vKoXEAlTQLJE6N/49r+NQTq96HcaGLed/ZqK3Z0LsPRricxyuCKz5MzOG+IoXlaFeVIABgWQc9ns3AkqAGiwPnZHXHd3emd+UGHC1bENGL/1chGUkBW57zxGQ3ztO1ggF728h/9HqA9kGatK87tbIyZmz45mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784728486; c=relaxed/simple; bh=hQXwVvJiJMAJltB/XBNufMgSyDt9AsinxXQZrVpmMzI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LcTbbtFz5pPq0kErblqfynAKqrZuEfROKpYWfUZq8bFNqY0TR3NhRapnaObS7r1vg/wiKRiYaJCCi7FBwrVegBl03dybNoZeRCESlAyjLae3G+j9YguAAQgnWWCZLb2LAg8pGeXpGmAZcE7kA6i/y0fwsKS6Q776oumcfqPpbTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n7fKrgoN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n7fKrgoN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 853DF1F000E9; Wed, 22 Jul 2026 13:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784728485; bh=V+vQtKuXnH6YwUK6i5STl+3iYVgoVttTlS4wO7FBp9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=n7fKrgoNlQ7nNniuEzhP/wYy2sGkI0lGMtUMlpwSAGj3TUksHiaDlwlNMDkg570wM 9wq5ZW+gAvImzpu1g+gyfW+qfqQdyf7N+gpK38+XiB3LvRZwixK+w5hSc0pt4u3pE5 hTdPgsyZEePs4/ksvMEnt8nOz9FiXnpaVQKexXWAyEakGXnPmh8M7HUpQyw9kiWD0a GBxzdhxUTfAR3uknZElF8Nv5aI+CPD12yShPs5DLBU+isgF77jYWjsgBjSdPMU3b7+ PVbcvhzG+Hro9mRzPXyJGyWrliYvcVHR9cLokKV5o1pzdHstt//LaJtiqesgAllQSl MVwGm42QkV3FQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Xu Rao , Takashi Iwai , Sasha Levin Subject: [PATCH 5.15.y] ALSA: hda: Fix cached processing coefficient verbs Date: Wed, 22 Jul 2026 09:54:42 -0400 Message-ID: <20260722135442.1365693-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026072012-yin-trance-e288@gregkh> References: <2026072012-yin-trance-e288@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Xu Rao [ Upstream commit f67be28fdf8b5d31ac1cc1152bb17250f9f8f513 ] Intel HD Audio defines Coefficient Index and Processing Coefficient as separate audio widget controls in the Audio Widget Verb Definitions: Coefficient Index selects the coefficient slot, while Processing Coefficient accesses the value at the selected slot. hda_reg_read_coef() selects the slot with AC_VERB_SET_COEF_INDEX, but then uses AC_VERB_GET_COEF_INDEX for the value read. That reads back the selected index instead of the coefficient value. hda_reg_write_coef() has the same issue and builds the value write from AC_VERB_GET_COEF_INDEX instead of AC_VERB_SET_PROC_COEF. This only affects the regmap coefficient cache path used by codecs that set codec->cache_coef. Direct coefficient helpers already use the normal SET_COEF_INDEX followed by GET_PROC_COEF or SET_PROC_COEF sequence, which is likely why this has not been noticed widely. Use AC_VERB_GET_PROC_COEF for cached coefficient reads and AC_VERB_SET_PROC_COEF for cached coefficient writes. Fixes: 40ba66a702b8 ("ALSA: hda - Add cache support for COEF read/write") Cc: stable@vger.kernel.org Signed-off-by: Xu Rao Link: https://patch.msgid.link/DB9023BF2920BA99+20260707132419.1731342-1-raoxu@uniontech.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/hda/hdac_regmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c index 39610a15bcc988..9b786cec8f1e13 100644 --- a/sound/hda/hdac_regmap.c +++ b/sound/hda/hdac_regmap.c @@ -215,7 +215,7 @@ static int hda_reg_read_coef(struct hdac_device *codec, unsigned int reg, err = snd_hdac_exec_verb(codec, verb, 0, NULL); if (err < 0) return err; - verb = (reg & ~0xfffff) | (AC_VERB_GET_COEF_INDEX << 8); + verb = (reg & ~0xfffff) | (AC_VERB_GET_PROC_COEF << 8); return snd_hdac_exec_verb(codec, verb, 0, val); } @@ -233,7 +233,7 @@ static int hda_reg_write_coef(struct hdac_device *codec, unsigned int reg, err = snd_hdac_exec_verb(codec, verb, 0, NULL); if (err < 0) return err; - verb = (reg & ~0xfffff) | (AC_VERB_GET_COEF_INDEX << 8) | + verb = (reg & ~0xfffff) | (AC_VERB_SET_PROC_COEF << 8) | (val & 0xffff); return snd_hdac_exec_verb(codec, verb, 0, NULL); } -- 2.53.0