From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD2E33C8716 for ; Wed, 22 Jul 2026 23:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784764019; cv=none; b=YFqP9nU6PTyJ1FAhid26lLLiqG/bNXN2x+ifiok3x350H1E8sxzm/W3fKuLHibQv5BiqHIz8BMzPFYCx2qm3RPbE/PO0qeM1t6L5iw7NRtmXNRp0IuwuDmS/k5hOUW0HoWglGVCDa+EeSsDOFdqtHJoqwqE9ox4QCjvkkmGJtp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784764019; c=relaxed/simple; bh=zyRQcx2bqweKaWghEmDMBDvTlH+cohNvDmPRCYwYX04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cGq/iRm2KqLPT0mhneqlITjkeudWfeVuJYeR9o/n4ycRydBJn3g7kPX3sx544ZGhaci7DvOqr4qBXLQLXJzYKCA1nj3ZMYbfKcqOWpg7IyQuVFMn/Ms16VgjpyBIaKA4eLIVNby2J9+x+mVW0ap7nldxgvPpw/57UQLmzdar1pY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mbYzvsbd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mbYzvsbd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FF5D1F00A3D; Wed, 22 Jul 2026 23:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784764018; bh=+EznGlXl2l1dEFF/wbtVR95idgGrXoafLsX6aD4JfbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mbYzvsbd65OG3HW2FaawekiDYTyYVy2SUppt2/S5cGSdzEQD5XquVGMh4zqXJg3sG yZMxiYeyYdnTWDiFOKcsm4clka6bncRXF6QIwt4u+B7w2PJAO+LvQN5eGHJeDPVNjv cGR2eY+Fi1WThenuaAiGHlc90s0yxQ4iqfQ7XVz7FJe02/+xcbb3JvRRt0Tv5Mg/Ti FCO5xOpD543UEk4NRIMmwOBaE5pZs6f+qVEpsQzLb4G8/Opn1YBn2WaxoiI4y3t648 sf4Kek7EaXUp37SjJ2tfG4dx3qLoIQIXBr+ACwViH8U04afQq+U6USpWpKlaHbqLfP E+TqSdBJ0Mrsg== From: Sasha Levin To: stable@vger.kernel.org Cc: Wentao Liang , Ido Schimmel , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1.y 2/2] mlxsw: fix refcount leak in mlxsw_sp_port_lag_join() Date: Wed, 22 Jul 2026 19:46:55 -0400 Message-ID: <20260722234655.2612015-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260722234655.2612015-1-sashal@kernel.org> References: <2026072025-willpower-discolor-ccfb@gregkh> <20260722234655.2612015-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wentao Liang [ Upstream commit 41c8c1d65b32beacd8d916a22457b4f6e47f45af ] When mlxsw_sp_port_lag_index_get() fails, mlxsw_sp_port_lag_join() returns an error without releasing the lag reference obtained by the earlier mlxsw_sp_lag_get(). All other error paths in the function jump to the cleanup label that ends with mlxsw_sp_lag_put(), so this is a single missed release. Fix the leak by replacing the bare 'return err' with a goto to the existing error cleanup label, which will drop the reference safely. Cc: stable@vger.kernel.org Fixes: 0d65fc13042f ("mlxsw: spectrum: Implement LAG port join/leave") Signed-off-by: Wentao Liang Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/20260609083709.209743-1-vulab@iscas.ac.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index 2560bbf5df74b2..956564135c503a 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -4462,7 +4462,7 @@ static int mlxsw_sp_port_lag_join(struct mlxsw_sp_port *mlxsw_sp_port, err = mlxsw_sp_port_lag_index_get(mlxsw_sp, lag_id, &port_index); if (err) - return err; + goto err_lag_uppers_bridge_join; err = mlxsw_sp_lag_uppers_bridge_join(mlxsw_sp_port, lag_dev, extack); -- 2.53.0