From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E923409102 for ; Thu, 23 Jul 2026 16:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784825666; cv=none; b=NjOn9FvxY1GD5AAP3fvcTuCJ/nSHA9RzYTmSD2MYk3kkY6sjBqqKODy6ngrM2c4ZkMwT2OQYZ9e98U6qvcX7qWaeNSkmO4unvlPjuzpGbUxm8KoriNCpJizG2CwOKCtGcevUgW7gXG4dITbbzVJfVKQxwcyeP3ZaYRoAScLaO44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784825666; c=relaxed/simple; bh=zcpRuMcG8V1WLzVteCewRJ1or6ZXKD93iEaEVE4fRw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dVBm9RnyOJjD4mEL6J2EUXmt4jYJf46xjID5Eq6haUGNx35F8bfEjE7lIvLyWpCS/5lm4XkMaX1aPCfUTvWaUIqLHpcGrKuEwfAIjVjmBmMQ+waNS3vcFH4X6vTlrbxuVmnsb/wVuYOml3AbYSb9w2lkrEWXt8VdQyS1IvEqbBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QZJSOHGJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QZJSOHGJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DC731F000E9; Thu, 23 Jul 2026 16:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784825665; bh=LHpetW3KaMJsuqf1crKGDCq45JumnQTPUaA8edbuY+w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QZJSOHGJ0aK+XhseZgQ2gH/6F3lUbTbV7TQkXTHTNgrgnXum/XKer94UoMBzUAl0b z1TlXE503+LxcqqG+xSoS6or8glV7f1rw7h07BwgvzONnIAFEmUXXHgsFx9UfZlbbj Qa9ICYU8cVF1KvIWn9vV5zqVjyyZZzR1cnYSaCQYCAULnhyiE/S1peHybe8tm0DUN7 gibugtKBTxx4YEpty4ftNJbmRpWSTs0uG3Ri7YeoG2BpROhCW3nKQV7e9wmgBAiIwY kq21IkMSdoHswvbBXTgGqa+T+XmmAPq3G3pDeS6lTv+SLZq+VAbPwMKvWeMdGcPWZv vU+8UYzNDY8nQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Pablo Neira Ayuso , Ren Wei , Florian Westphal , Sasha Levin Subject: [PATCH 5.15.y 2/2] netfilter: nf_conntrack_sip: validate skb_dst() before accessing it Date: Thu, 23 Jul 2026 12:54:22 -0400 Message-ID: <20260723165422.3390558-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260723165422.3390558-1-sashal@kernel.org> References: <2026072003-quintuple-cascade-1edd@gregkh> <20260723165422.3390558-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Pablo Neira Ayuso [ Upstream commit e5e24a365a5e024efef63cc49abb345fbd4852c5 ] tc ingress and openvswitch do not guarantee routing information to be available. These subsystems use the conntrack helper infrastructure, and the SIP helper relies on the skb_dst() to be present if sip_external_media is set to 1 (which is disabled by default as a module parameter). This effectively disables the sip_external_media toggle for these subsystems without resulting in a crash. Fixes: cae3a2627520 ("openvswitch: Allow attaching helpers to ct action") Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") Cc: stable@vger.kernel.org Reported-by: Ren Wei Signed-off-by: Pablo Neira Ayuso Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_sip.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index d2373733e98179..10f57b12f26f26 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -947,7 +947,6 @@ static int set_expected_rtp_rtcp(struct sk_buff *skb, unsigned int protoff, return NF_ACCEPT; saddr = &ct->tuplehash[!dir].tuple.src.u3; } else if (sip_external_media) { - struct net_device *dev = skb_dst(skb)->dev; struct dst_entry *dst = NULL; struct flowi fl; @@ -969,7 +968,11 @@ static int set_expected_rtp_rtcp(struct sk_buff *skb, unsigned int protoff, * through the same interface as the signalling peer. */ if (dst) { - bool external_media = (dst->dev == dev); + const struct dst_entry *this_dst = skb_dst(skb); + bool external_media = false; + + if (this_dst && dst->dev == this_dst->dev) + external_media = true; dst_release(dst); if (external_media) -- 2.53.0