From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D431131197C for ; Fri, 24 Jul 2026 01:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784856325; cv=none; b=fNEdBST5O5e4gQgUsZipZcxAJV41SC4ebh/srr9MOG2cvN22hH5AoNzRv/FFj/Re8cetv0RzB2+GRdop1+Hx0KOMRcRFUi+FovHaul0xUX8CSsUxeFrTlcKvq1IuUc9OOBTQYkN1MKTqL3d3O2Kd6vzh6vqbTJR+NZ9NVZb831M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784856325; c=relaxed/simple; bh=k8DBaZnVJUdHsQ/cmSq28UJ2ucwXPc7pILec0fesKeo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TSVZPob++WUITtA9n2dlpp5vTQGA+hOZl7Xk4+/wjupt23EiyS2wsRHHaNvShJDbeFLdSBkOOkEodezzdKOitU4tGIgihNYamdyYPTUYi7oxvLIhhjD4UsPYj+tmWmLzOO1WFA+Hfxy+OWGtRoSNipb1o9xdpUNIkAfrHOEBYU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n8JrOGUb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n8JrOGUb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 265F81F00A3D; Fri, 24 Jul 2026 01:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784856323; bh=nKx/tGjxhML7EmKaD1YyxEiNZtOU3ZIWm26mb00YBZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=n8JrOGUbNsXbZdrEoMhGpNAZw3ZTSw/E7PmqYtJvuDfNnwRoQr3d48XJRoVKK8Esk pDAW9wlzFVvjMi7VX0KRvvMKTvavrK5jPAIeVP71u2/j26/T+Kxt9aTuy5Dug6yRqY XWhkO4eJyPaoEQWWQQHfAKgW2tauowhwvzYFzK0RCwP9KI5asj0L7hbkPIYQV6t0WE Wv8XttGURibNrp/U19D+tvYwrY6kDpDUjHMu3dLfWuUerqHy2OA4cidi70fbhmbowD m3sZKK7qn+26EfoNwG41yOSiVzxYffI28XsZo9ACnxR8e6/B67h3IpDmSV+ySBWu96 bjOTqOyj1Uc9g== From: Sasha Levin To: stable@vger.kernel.org Cc: Tristan Madani , Stephen Smalley , Paul Moore , Sasha Levin Subject: [PATCH 5.10.y 3/3] selinux: avoid sk_socket dereference in selinux_sctp_bind_connect() Date: Thu, 23 Jul 2026 21:25:19 -0400 Message-ID: <20260724012519.3833356-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260724012519.3833356-1-sashal@kernel.org> References: <2026072006-hush-cape-c69a@gregkh> <20260724012519.3833356-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani [ Upstream commit 56acfeb10019e200ab6787d01f8d7cbe0f01526f ] selinux_sctp_bind_connect() dereferences sk->sk_socket to pass a struct socket * to selinux_socket_bind() and selinux_socket_connect_helper(). However, when the hook is invoked from the ASCONF softirq path (sctp_process_asconf), there is no file reference guaranteeing that sk->sk_socket is non-NULL. The setsockopt callers (bindx, connectx, set_primary, sendmsg connect) hold a file reference and are not affected. Both selinux_socket_bind() and selinux_socket_connect_helper() immediately resolve sock->sk, never using the struct socket * for anything else. Refactor the inner logic into helpers that take a struct sock * directly so that selinux_sctp_bind_connect() never needs to touch sk->sk_socket at all. Cc: stable@vger.kernel.org Fixes: d452930fd3b9 ("selinux: Add SCTP support") Suggested-by: Stephen Smalley Signed-off-by: Tristan Madani Reviewed-by: Stephen Smalley Tested-by: Stephen Smalley Signed-off-by: Paul Moore Signed-off-by: Sasha Levin --- security/selinux/hooks.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 279eef31eac581..ae71959e735159 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4608,9 +4608,8 @@ static int selinux_socket_socketpair(struct socket *socka, Need to determine whether we should perform a name_bind permission check between the socket and the port number. */ -static int selinux_socket_bind(struct socket *sock, struct sockaddr *address, int addrlen) +static int __selinux_socket_bind(struct sock *sk, struct sockaddr *address, int addrlen) { - struct sock *sk = sock->sk; struct sk_security_struct *sksec = selinux_sock(sk); u16 family; int err; @@ -4746,13 +4745,17 @@ static int selinux_socket_bind(struct socket *sock, struct sockaddr *address, in return -EAFNOSUPPORT; } +static int selinux_socket_bind(struct socket *sock, struct sockaddr *address, int addrlen) +{ + return __selinux_socket_bind(sock->sk, address, addrlen); +} + /* This supports connect(2) and SCTP connect services such as sctp_connectx(3) * and sctp_sendmsg(3) as described in Documentation/security/SCTP.rst */ -static int selinux_socket_connect_helper(struct socket *sock, +static int selinux_socket_connect_helper(struct sock *sk, struct sockaddr *address, int addrlen) { - struct sock *sk = sock->sk; struct sk_security_struct *sksec = selinux_sock(sk); int err; @@ -4846,7 +4849,7 @@ static int selinux_socket_connect(struct socket *sock, int err; struct sock *sk = sock->sk; - err = selinux_socket_connect_helper(sock, address, addrlen); + err = selinux_socket_connect_helper(sk, address, addrlen); if (err) return err; @@ -5310,13 +5313,11 @@ static int selinux_sctp_bind_connect(struct sock *sk, int optname, int len, err = 0, walk_size = 0; void *addr_buf; struct sockaddr *addr; - struct socket *sock; if (!selinux_policycap_extsockclass()) return 0; /* Process one or more addresses that may be IPv4 or IPv6 */ - sock = sk->sk_socket; addr_buf = address; while (walk_size < addrlen) { @@ -5345,14 +5346,14 @@ static int selinux_sctp_bind_connect(struct sock *sk, int optname, case SCTP_PRIMARY_ADDR: case SCTP_SET_PEER_PRIMARY_ADDR: case SCTP_SOCKOPT_BINDX_ADD: - err = selinux_socket_bind(sock, addr, len); + err = __selinux_socket_bind(sk, addr, len); break; /* Connect checks */ case SCTP_SOCKOPT_CONNECTX: case SCTP_PARAM_SET_PRIMARY: case SCTP_PARAM_ADD_IP: case SCTP_SENDMSG_CONNECT: - err = selinux_socket_connect_helper(sock, addr, len); + err = selinux_socket_connect_helper(sk, addr, len); if (err) return err; -- 2.53.0