From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C8F312815 for ; Fri, 24 Jul 2026 02:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860574; cv=none; b=lfTIpIkM4ID+jVy8MKIPZlEKMocZB2NYh+jRlRH9aACbVA0vkq+6uzEwACW2a63yxYY5bQghFYpeNG2DA/dfz+JuI+dxasGSYAstAg8n69BOvcFsRCsR8wlHAHkbWdT7F4QYpQns5o+eqoYZyM9EYN9sTyQsAGhG8GfRF8EPblM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860574; c=relaxed/simple; bh=olPxujuYkEW8ok539c4p0l5U2j8JwhQTnj/MAOjfLW0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RpogmQs4Wp8/IbCJOjqpFZdSxi/hduKo0DBQoiCAPIqREtD0r2q+LKEUQ8Gv+WnHYzejDAjg1BUz6ZaQl5lVMO3vFHjN7A8sIluADYFo9a7gQm1SjztVO2anG67uUJQ7bzJhJ8UVRODRc42jr8/WdZJsuLsl6W+nl+701B5MzR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pyhQA/ZD; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyhQA/ZD" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-51c928bf172so12581021cf.3 for ; Thu, 23 Jul 2026 19:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784860572; x=1785465372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jPRPDODK54d+U5KjdC02Y68fkYSuUcD8QWj3Elue670=; b=pyhQA/ZDzdoxCfvrMcYmbptJ53ypOoJ7yuUC0kWaNdWyLZTHlxzZ4JKEC6Sb97F/ho ysmqMaPSf3P8NgconY7RyLRdNKSu+XJBkaBuw0vrZDWCJ5GmfYzooUdcNRkzDn/x0DQp 1j1cwJYkMnFu4buNc0FCXlbF8ox6CsD+aPobxfOebjqnA8SZLTXQHwWdKdS7no/Vfl7Q zDTDBFszf3tZg/sAU9rPtgOxAjivb282cZSai9XNkBR0ueZVbGTC49zeB865eoVStTJs vnm6WLue8mDYkPwJ3UJL0F4SwXWHT56hpyrQRT0RXXjjhB7tvCgTTypnrMaWvjUwp3SQ tNqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784860572; x=1785465372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jPRPDODK54d+U5KjdC02Y68fkYSuUcD8QWj3Elue670=; b=m9FT0iyYqTxQPqpch4SWWzxK6DqvU4H0pezydaoPC05HTNuRDZ9ArH2BXEZZDsbSmw VO1w+yK9YXtTnXQUyQiRYbFul0vVxyE/2PbXe1GWDE24fvLemkJzNNpIKY8W1psW/0kO /nBTCiyUOKKLAm40YPgAT4bzSJvl2M/YF0+3LFDluJD3S0HNk+HM1Xwg8lEamLji7Mhg 6t2wDr00KXKr7Ea0ElRYfhJwMhIVXkeG2Lb17eFiuW71yJMnDtPXQhFuDMROe94UDT5u 6hI5W17Dbm8LwT7YpJmXaOCPiOVt6c59wa5+BFYkZaSEUow5PTgtiar/i3t99i7iGDY3 G7WA== X-Forwarded-Encrypted: i=1; AHgh+RoA6e+lfEafjywWS5OmXuAzUFBqQy6wwQ7UgyTgZ8eDVwxQcgWJxpxfdwmZ8+CJAh9BH2DGP2s=@vger.kernel.org X-Gm-Message-State: AOJu0YyyInzLRdydvSes0nFGC2hsmIl5kori0u9pfzTVPpn4bEDicYMu nNdckA3MCFYEy4KeJNhJ8ytj9f1Gw3NYXTkhNCbRNOfdxKejvLcIdZio X-Gm-Gg: AR+sD12V/a+lWjN0iqChojGdkvd/1jRlm71niyiMEXALqJA+fp//gojwnzpD4AUUwsk XeyEllkvL5qqqJqTnuk40D98jm6pTYiKLBUnwhCCMRGrG2DqOo9BFdNB35VDWGIvvxkDCiTSEMg /gpWziwOIfSleKkFFcbpo3fsfNsajzs+MoHAwzlsLZbiYfMckvidEe7rOOm+A1fuqcnlld4TyTh 4oUyVup2tsXvYQjRtirSahZqm5BQKtbZTYr+IJunvaTozZRiHNaWYMPIMjw8yewvrGqoWNrIS9o oM3Lw6AIjIhCGBThdvWISMlJgNW9zENATCUkB2U0nNLcPHVPyGjwlo8kQhMcMyQvaGzIOVJ7tzg e/zr/064IwIC5pywi97CnLW7/ugunBVib1ET2XeilsP+zVQfEQqfF9Tg6GuBbxlYMV9xbYbZPcA HaQ7crS3T0GIoy2ms= X-Received: by 2002:a05:622a:106:b0:51c:1fa1:80d3 with SMTP id d75a77b69052e-5283df10f33mr58127371cf.49.1784860571755; Thu, 23 Jul 2026 19:36:11 -0700 (PDT) Received: from FredPC.lan ([2600:382:311b:26:fed0:9b59:babb:80f6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907baa0f4dasm58223986d6.41.2026.07.23.19.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 19:36:11 -0700 (PDT) From: Fredric Cover To: sfrench@samba.org Cc: pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Fredric Cover , stable@vger.kernel.org Subject: [PATCH] smb: client: clear ce->tgthint in free_tgts() Date: Thu, 23 Jul 2026 19:35:39 -0700 Message-ID: <20260724023539.1596955-1-fredric.cover.lkernel@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When free_tgts() frees all structures in ce->tlist, ce->tgthint is left pointing to one of the freed cache_dfs_tgt structures. If ce->tgthint is not reset before it is used later, it results in a use-after-free. Set ce->tgthint to NULL in free_tgts() after the elements are freed to reflect that no elements remain. Fixes: 54be1f6c1c37 ("cifs: Add DFS cache routines") Cc: stable@vger.kernel.org Signed-off-by: Fredric Cover --- fs/smb/client/dfs_cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/smb/client/dfs_cache.c b/fs/smb/client/dfs_cache.c index 8cd93cd2f00f..451550eb4023 100644 --- a/fs/smb/client/dfs_cache.c +++ b/fs/smb/client/dfs_cache.c @@ -122,6 +122,8 @@ static inline void free_tgts(struct cache_entry *ce) kfree(t->name); kfree(t); } + + WRITE_ONCE(ce->tgthint, NULL); } static inline void flush_cache_ent(struct cache_entry *ce) -- 2.53.0