From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABE8D400966 for ; Mon, 27 Jul 2026 13:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785158002; cv=none; b=diTVpwk1vLTQMbP3FibYmjrJq7Mgmqi73Yx61wvsdTaOp4GL1FUW793n3hW5qnb8DDLPiymh0m7WN7M8mPhxClOEXnCU1YFL4HDXBeGpdOCYVQ2BQcj3TBHpgDTZW6Bys51R65V5vmWBBtB+0Xtc2Cg3ZXLihKeoqXUEFuJCIC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785158002; c=relaxed/simple; bh=Fnw8QNB5Dw/rcnIG2mVhlxaJCxHWnMW0ld1vB5CvgrA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AdYYWF85AtAKqBPAxiZ/tHnnysLzN6gjEZ4FnppYBn/Q3lgN0WvvTIlmAlEnxUBojJT6k5GyJKa5sQeqp48YlXQreQcnpbgcLL7YJqo4zfDz67qYrE7m0kZ4bGpidtemZUH6nLgmPackOIkJf9F4aBY/7VyiOZhPuZ2uDLVLJgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P7wOYU14; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7wOYU14" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AEBB1F00A3A; Mon, 27 Jul 2026 13:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785158001; bh=KdJuNPijJmwzecYGgKF9y9YDsB2gZvLpuMHYhE8Dmwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P7wOYU147droPD2b84lCZxR4REE0KJv1nfUMMAQXnPSWrChevOV+yHuz/sj8rzHHk JE1QBUJNya+k5lC13jy1DfRkF0tT79zcpwyYbqSxXUPFwLTdd1prjTX4ImhREv5zGC oGKFZsc0HY1Vr9dklyFyRi0ONytOZnhSJB9oVPbC4SLbbOFqx8US1DoI+kocj+gADA 0QADO/TgkM9LXZr0oSsOFDkhUyD9NxjgDtprCg40mBGzPJoqligIQC5ZjprTBDTmFR kF8MFjw34Ig0vkYk9zT9PZkATuhgX7GfaT5iea53A2Uxr4jk3nDhc2XZ2XqZ/JEUUJ CCK7ahHBUn1Ew== From: Sasha Levin To: stable@vger.kernel.org Cc: Vincent Jardin , Oleksij Rempel , Carlos Song , Stefan Eichenberger , Andi Shyti , Sasha Levin Subject: [PATCH 5.10.y 2/2] i2c: imx: fix locked bus on SMBus block-read of 0 (atomic) Date: Mon, 27 Jul 2026 09:13:17 -0400 Message-ID: <20260727131317.399719-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260727131317.399719-1-sashal@kernel.org> References: <2026072037-gentleman-dwelled-cdd7@gregkh> <20260727131317.399719-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Vincent Jardin [ Upstream commit cb2fc37857693b55909fb77dc2c87cfbc1cdc476 ] SMBus 3.1 6.5.7 allows a Block Read byte count of 0, but the atomic (polling) path rejects it as -EPROTO. Worse, it returns without a NACK+STOP: the next receive cycle has already started, so the target keeps holding SDA and the bus stays stuck until a power cycle for this i2c controller. Reading I2DR to obtain the count likewise arms the next byte on the count > I2C_SMBUS_BLOCK_MAX path, which also returned -EPROTO directly and left the bus held. Handle both: NACK the in-flight dummy byte (TXAK) and extend msgs->len so the existing last-byte handling emits STOP; the dummy byte is discarded. A count of 0 is a valid empty block read; a count above I2C_SMBUS_BLOCK_MAX is still reported as -EPROTO, but only after the bus has been released. The interrupt-driven path has the same flaw from a later commit and is fixed separately, as it carries a different Fixes: tag and stable range. Fixes: 8e8782c71595 ("i2c: imx: add SMBus block read support") Signed-off-by: Vincent Jardin Cc: # v3.16+ Acked-by: Oleksij Rempel Acked-by: Carlos Song Reviewed-by: Stefan Eichenberger Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20260713-for-upstream-i2c-lx2160-fix-v1-v3-1-073ac9e103a5@free.fr Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-imx.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 3e7f972c63127c..b9d26a2c9dd964 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -890,6 +890,7 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs, int i, result; unsigned int temp; int block_data = msgs->flags & I2C_M_RECV_LEN; + int block_err = 0; result = i2c_imx_prepare_read(i2c_imx, msgs, atomic, false); if (result) @@ -911,8 +912,20 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs, */ if ((!i) && block_data) { len = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR); - if ((len == 0) || (len > I2C_SMBUS_BLOCK_MAX)) - return -EPROTO; + if ((len == 0) || (len > I2C_SMBUS_BLOCK_MAX)) { + /* + * SMBus 3.1 6.5.7: support count byte of 0. + * I2C_SMBUS_BLOCK_MAX case should not hold the SDA either. + */ + if (len > I2C_SMBUS_BLOCK_MAX) + block_err = -EPROTO; + temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); + temp |= I2CR_TXAK; + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + msgs->buf[0] = 0; + msgs->len = 2; + continue; + } dev_dbg(&i2c_imx->adapter.dev, "<%s> read length: 0x%X\n", __func__, len); @@ -960,7 +973,7 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs, "<%s> read byte: B%d=0x%X\n", __func__, i, msgs->buf[i]); } - return 0; + return block_err; } static int i2c_imx_atomic_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs, -- 2.53.0