From: Eric Biggers <ebiggers@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH 6.18.y 1/4] dm-verity-fec: fix the size of dm_verity_fec_io::erasures
Date: Mon, 27 Jul 2026 21:09:26 +0000 [thread overview]
Message-ID: <20260727210926.GE1021387@google.com> (raw)
In-Reply-To: <20260727210011.1929439-1-sashal@kernel.org>
On Mon, Jul 27, 2026 at 05:00:08PM -0400, Sasha Levin wrote:
> From: Eric Biggers <ebiggers@kernel.org>
>
> [ Upstream commit a7fca324d7d90f7b139d4d32747c83a629fdb446 ]
>
> At most 25 entries in dm_verity_fec_io::erasures are used: the maximum
> number of FEC roots plus one. Therefore, set the array size
> accordingly. This reduces the size of dm_verity_fec_io by 912 bytes.
>
> Note: a later commit introduces a constant DM_VERITY_FEC_MAX_ROOTS,
> which allows the size to be more clearly expressed as
> DM_VERITY_FEC_MAX_ROOTS + 1. This commit just fixes the size first.
>
> Fixes: a739ff3f543a ("dm verity: add support for forward error correction")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Stable-dep-of: 31d6e6c0ba8d ("dm-verity: fix buffer overflow in FEC calculation")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
1. Missing cover letter.
2. I was only sent patches 1-3 of 4.
3. Missing Cc to the subsystem mailing list. Needed since these aren't
clean cherry-picks.
4. These backports seem to have unnecessary differences from the
upstream commits. DM_VERITY_FEC_MAX_ROOTS in added in the first
commit, but upstream it was added in the third one.
- Eric
next prev parent reply other threads:[~2026-07-27 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 15:19 FAILED: patch "[PATCH] dm-verity: fix buffer overflow in FEC calculation" failed to apply to 6.18-stable tree gregkh
2026-07-27 21:00 ` [PATCH 6.18.y 1/4] dm-verity-fec: fix the size of dm_verity_fec_io::erasures Sasha Levin
2026-07-27 21:00 ` [PATCH 6.18.y 2/4] dm-verity-fec: fix reading parity bytes split across blocks (take 3) Sasha Levin
2026-07-27 21:00 ` [PATCH 6.18.y 3/4] dm-verity-fec: replace {MAX,MIN}_RSN with {MIN,MAX}_ROOTS Sasha Levin
2026-07-27 21:00 ` [PATCH 6.18.y 4/4] dm-verity: fix buffer overflow in FEC calculation Sasha Levin
2026-07-27 21:09 ` Eric Biggers [this message]
2026-07-27 21:21 ` [PATCH 6.18.y 1/4] dm-verity-fec: fix the size of dm_verity_fec_io::erasures Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727210926.GE1021387@google.com \
--to=ebiggers@kernel.org \
--cc=mpatocka@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox