From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7DD448B98 for ; Tue, 28 Jul 2026 14:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785248875; cv=none; b=f6oUt4RVcE3SoSp8qXUxDF4XHrbUuNmg7skdOP9ynFjj9wUelyQUgBMG/9cGi2MHH7Ku/16BGbm1RJ7p0iFHCc1XYn9fROC78gCsDKqALU5mSBc3ZDlHMK/+ZHddwirfvdOIthW3jCtU2MUIGTLMUXQVNTonVirgQc05lzOjd/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785248875; c=relaxed/simple; bh=TJRojWNyvPMhWwdIm509zFAQFxlZccM161ad/0UH99Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D4vzwoh8R+mMTA206wepNoFYlv93tZ1DZyPoWJxMiOQO4iSywxLy4t9UyxTtyjr8q+csVO9R9Z1XaqoJVJIp9l62/+vgN/M1nHeRVb44ZF0id7J9i4/JnG18a968LbMCkkB5ITNy0yJOkxH0T5lB48r8cIzCOJQLKzhY32CxrBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q1aBtEjM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q1aBtEjM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D9911F00A3A; Tue, 28 Jul 2026 14:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785248873; bh=Ge05h2IjHRyo3L1TEI6pt+JG5//T7RAG30T0kM9df24=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Q1aBtEjMlEH3D9QDmC9qgetraepHa1N+BPnsvxYvbgBISWQmhPFnwmUkeK5wyJdgM 2Jtm84o3tSAEaQpU3ep3nbV6pNlQ9/bvzkh9JoYLCBf3ipTBZtF2MVId/hsZbZk4S9 1nZcZH5iOsyv5noPX0csxQAINQlTyZ5Mu7DdXR2/cBIgH3poKqEVzlqy3eSuKcn2Tk lZmscwWV3/f6m3v5gyeoSsJS3778J09aaFReh2/H6rPhYR0J3Oie6CdiFHa9G/qyRL 46A3g1M+OiNOGx2uz99lCvL5pXf68HboExlBM5gTEchWQvTWSpE2+bAitXR3cRRiQG czSS9vWF73tZg== From: Sasha Levin To: stable@vger.kernel.org Cc: Runyu Xiao , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.1.y 2/2] gpio: tegra: do not call pinctrl for GPIO direction Date: Tue, 28 Jul 2026 10:27:50 -0400 Message-ID: <20260728142750.4096390-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260728142750.4096390-1-sashal@kernel.org> References: <2026072048-oven-revivable-04e6@gregkh> <20260728142750.4096390-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Runyu Xiao [ Upstream commit d3e91a95b2b0fc6336dbf3ec90d831a1654d2720 ] tegra_gpio_direction_input() and tegra_gpio_direction_output() already program the GPIO controller direction registers directly. The additional pinctrl_gpio_direction_input/output() calls do not add a Tegra pinctrl operation, because the Tegra pinmux ops provide GPIO request/free handling but no gpio_set_direction hook. The extra call still enters the pinctrl core and takes pctldev->mutex. Shared GPIO users can call the direction path while holding their per-line spinlock, so this otherwise redundant pinctrl direction call can sleep in an atomic context. This was found by our static analysis tool and then confirmed by manual review of tegra_gpio_probe(), the Tegra GPIO direction callbacks and the Tegra pinctrl ops. The reviewed path has a default non-sleeping struct gpio_chip while the direction callback still enters the pinctrl mutex path. A directed runtime validation kept the same non-sleeping chip registration and drove: gpio_shared_proxy_direction_output() gpiod_direction_output_raw_commit() tegra_gpio_direction_output() pinctrl_gpio_direction_output() Lockdep reported a sleep-in-atomic warning with the shared GPIO spinlock held and pinctrl_get_device_gpio_range() plus tegra_gpio_direction_output() on the stack. Do not mark the whole chip as can_sleep to paper over this: can_sleep describes whether get()/set() may sleep, and Tegra value access is MMIO. Remove the redundant pinctrl direction calls and keep pinctrl involvement in the existing request/free path. Fixes: 11da90541283 ("gpio: tegra: Fix offset of pinctrl calls") Cc: stable@vger.kernel.org Signed-off-by: Runyu Xiao Link: https://patch.msgid.link/20260619152439.1239561-1-runyu.xiao@seu.edu.cn Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-tegra.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 4ad71df6e59a85..7b3936a00743a7 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -174,18 +174,11 @@ static int tegra_gpio_direction_input(struct gpio_chip *chip, unsigned int offset) { struct tegra_gpio_info *tgi = gpiochip_get_data(chip); - int ret; tegra_gpio_mask_write(tgi, GPIO_MSK_OE(tgi, offset), offset, 0); tegra_gpio_enable(tgi, offset); - ret = pinctrl_gpio_direction_input(chip, offset); - if (ret < 0) - dev_err(tgi->dev, - "Failed to set pinctrl input direction of GPIO %d: %d", - chip->base + offset, ret); - - return ret; + return 0; } static int tegra_gpio_direction_output(struct gpio_chip *chip, @@ -193,19 +186,12 @@ static int tegra_gpio_direction_output(struct gpio_chip *chip, int value) { struct tegra_gpio_info *tgi = gpiochip_get_data(chip); - int ret; tegra_gpio_set(chip, offset, value); tegra_gpio_mask_write(tgi, GPIO_MSK_OE(tgi, offset), offset, 1); tegra_gpio_enable(tgi, offset); - ret = pinctrl_gpio_direction_output(chip, offset); - if (ret < 0) - dev_err(tgi->dev, - "Failed to set pinctrl output direction of GPIO %d: %d", - chip->base + offset, ret); - - return ret; + return 0; } static int tegra_gpio_get_direction(struct gpio_chip *chip, -- 2.53.0