From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDC843DD528 for ; Tue, 28 Jul 2026 22:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785277095; cv=none; b=g33xw8F1hqTlPi58c178zpobvtFYAHIBdhGQbVWd7lZE5ZI74gs6V5l1voc0Sx1g1tFT/qiQYpcxtyhnt4ZGFtfTH1+FduHPhEDTLanVHnNVX+jYZfDdTtZmJ++MoJAGuC6g1Mj8oces5U03ONtF90EYd+EZpuTs8AR7/syU/+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785277095; c=relaxed/simple; bh=DrGOrqFgt5bGeQ+0F5jsIXMgLGDdPuLRJWrvf36xwzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g2Aa3tHmldZ/D9gOj8GCWiY3k7k2Y0+OYvY0Ql8yxF+hDXOXnkxk1aoAax4JzWi6JleUaQm4O9EM8KBITiL1HBQfHW+l29S83V8LSOG6Sddjjx8hSuEMWozqIL5H3NTQasBYg+MCbl7XkCmwCJHSOp2APqzl527zPvgPSRFyNpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EFIjG8bk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EFIjG8bk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 267001F000E9; Tue, 28 Jul 2026 22:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785277093; bh=CbGihwobmzwTMgFdlwxRbYU4hnxszu+t7OT8r+I8YFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EFIjG8bkCqKSGWBroNyX5vKCc1QrhsZ4BrWcttklZZCMiMtBgtGK8ooRzDOVkB42v BPr7D4qPBQIEsvCoaxkX5mZudZluXavXnNlpVKPTPwlOaQlgnrD1jJ5FcSPWV2Dbp3 zJfglTzl3aJ8qWDKKs0Yqe/ATRv3dMr+x7vNlM5Ndw3TlH50+xLYh9jDWf72ok0F+K BgaDdTCVbZe7cBig47idtvZlZmwo7pke+Z8AmTkTyxlP2sTAUKxqtatvHA9BJNwHe0 meG4ez+JVTDwy030zO5rEF1wbrxQmbR6QH0EHa1Y034XNmpqfYga8ELD9OB2bNM+7Z WRNe+lEiJkrLg== From: Sasha Levin To: stable@vger.kernel.org Cc: Runyu Xiao , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.10.y] gpio: tegra: do not call pinctrl for GPIO direction Date: Tue, 28 Jul 2026 18:18:11 -0400 Message-ID: <20260728221811.747329-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026072049-staunch-cognitive-7c1c@gregkh> References: <2026072049-staunch-cognitive-7c1c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Runyu Xiao [ Upstream commit d3e91a95b2b0fc6336dbf3ec90d831a1654d2720 ] tegra_gpio_direction_input() and tegra_gpio_direction_output() already program the GPIO controller direction registers directly. The additional pinctrl_gpio_direction_input/output() calls do not add a Tegra pinctrl operation, because the Tegra pinmux ops provide GPIO request/free handling but no gpio_set_direction hook. The extra call still enters the pinctrl core and takes pctldev->mutex. Shared GPIO users can call the direction path while holding their per-line spinlock, so this otherwise redundant pinctrl direction call can sleep in an atomic context. This was found by our static analysis tool and then confirmed by manual review of tegra_gpio_probe(), the Tegra GPIO direction callbacks and the Tegra pinctrl ops. The reviewed path has a default non-sleeping struct gpio_chip while the direction callback still enters the pinctrl mutex path. A directed runtime validation kept the same non-sleeping chip registration and drove: gpio_shared_proxy_direction_output() gpiod_direction_output_raw_commit() tegra_gpio_direction_output() pinctrl_gpio_direction_output() Lockdep reported a sleep-in-atomic warning with the shared GPIO spinlock held and pinctrl_get_device_gpio_range() plus tegra_gpio_direction_output() on the stack. Do not mark the whole chip as can_sleep to paper over this: can_sleep describes whether get()/set() may sleep, and Tegra value access is MMIO. Remove the redundant pinctrl direction calls and keep pinctrl involvement in the existing request/free path. Fixes: 11da90541283 ("gpio: tegra: Fix offset of pinctrl calls") Cc: stable@vger.kernel.org Signed-off-by: Runyu Xiao Link: https://patch.msgid.link/20260619152439.1239561-1-runyu.xiao@seu.edu.cn Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-tegra.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 86568154cdb3d3..4a3f2fe7a3a8bd 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -168,18 +168,11 @@ static int tegra_gpio_direction_input(struct gpio_chip *chip, unsigned int offset) { struct tegra_gpio_info *tgi = gpiochip_get_data(chip); - int ret; tegra_gpio_mask_write(tgi, GPIO_MSK_OE(tgi, offset), offset, 0); tegra_gpio_enable(tgi, offset); - ret = pinctrl_gpio_direction_input(chip->base + offset); - if (ret < 0) - dev_err(tgi->dev, - "Failed to set pinctrl input direction of GPIO %d: %d", - chip->base + offset, ret); - - return ret; + return 0; } static int tegra_gpio_direction_output(struct gpio_chip *chip, @@ -187,19 +180,12 @@ static int tegra_gpio_direction_output(struct gpio_chip *chip, int value) { struct tegra_gpio_info *tgi = gpiochip_get_data(chip); - int ret; tegra_gpio_set(chip, offset, value); tegra_gpio_mask_write(tgi, GPIO_MSK_OE(tgi, offset), offset, 1); tegra_gpio_enable(tgi, offset); - ret = pinctrl_gpio_direction_output(chip->base + offset); - if (ret < 0) - dev_err(tgi->dev, - "Failed to set pinctrl output direction of GPIO %d: %d", - chip->base + offset, ret); - - return ret; + return 0; } static int tegra_gpio_get_direction(struct gpio_chip *chip, -- 2.53.0