Re: [PATCH 6.1.y] net: qrtr: ns: Raise node count limit to 512

[Sasha Levin <sashal@kernel.org>]

> -/* Max lookup limit is chosen based on the current platform requirements. If the
> - * requirement changes in the future, this value can be increased.
> - */
> -#define QRTR_NS_MAX_LOOKUPS 64
> -

I've queued 6.18, 6.12 and 6.6, but I'm holding 6.1, 5.15 and 5.10 and
would like one v2 covering those three.

Two things:

1) The hunk above is in the 6.1 and 5.10 patches only.  It removes a
   duplicated #define that our own backports of 27d5e84e810b ("net: qrtr:
   ns: Limit the total number of nodes") introduced, which upstream
   ff194cffd586 ("net: qrtr: ns: Raise node count limit to 512") does not
   touch.  The 5.15 patch does not have it, even though 6.1 and 5.15
   currently have a byte-identical net/qrtr/ns.c.  Taking them as-is would
   leave the three old trees gratuitously different from each other.

2) More importantly, none of 6.1, 5.15 and 5.10 ever decrement node_count.
   The backports of 27d5e84e810b dropped the node_count-- hunk with the
   note that ctrl_cmd_bye() has no delete_node, but all three trees do have
   the delete_node: label with the xa_erase() + kfree().  So the counter is
   monotonic there and raising the cap from 64 to 512 only defers the wedge
   rather than fixing it.

Could you send a single v2 for 6.1, 5.15 and 5.10 that matches upstream
exactly and adds the missing node_count-- in ctrl_cmd_bye()?

-- 
Thanks,
Sasha