From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539E943C7A2; Thu, 30 Jul 2026 14:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422559; cv=none; b=obYPoe5CdKqAgW24gLmeIwujlreIbJnXwJxBrlYi/1ghPzU4avV/DNVk1D2JbM/DMS44vWe7mbH68ey7CRH1kexfbRjrSSVXkauvp9vJbzxTMTpDjalkZl89dvF6b7isMnM3T9YankZenZIzyyXbdgMcCLU6vfva/1FKbRU9LpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422559; c=relaxed/simple; bh=AvXLLQg87KznHvmfrOkrwPG2KDj9tba/HVGbsUCRxz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VdVNl4MWSrfDGS97308WfNkNfa0HPb3N7skeuIDaPw22wQ4pnUavRsla8GR2ydRuQDdhofbnJS4BEfi76ttTDioeVUiyk6XzqTxa0Cveb02MacJCfeES7U/G+9/1wjVtULcaQ7STWeDGyRmHEHG2sxgquuW00VoWhHNsEJTqTvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xBBh6E83; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xBBh6E83" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68B641F000E9; Thu, 30 Jul 2026 14:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785422558; bh=4AhKdUXlm1hNoprPIB+mhdKSH8c/XfdmtOxUIp9bGe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xBBh6E83XVbbSJbNFHBQ/J0v8vY51M6P/WoXm2W8c8K66UAMSGVItfTsNjEgUe+C/ 63JTvzPmFGfMDQuAxJ3MhYVNbJ7qCq23Huoa2p1hGXCUDIJtqizQ5DYQh733uITJkV 54Cf+XPexcDxK6gFrRZUVaKY9OQU0kItMiKMxD9w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Nicolas Dufresne , Jernej Skrabec , Chen-Yu Tsai , Hans Verkuil Subject: [PATCH 7.1 480/744] media: cedrus: skip invalid H.264 reference list entries Date: Thu, 30 Jul 2026 16:12:33 +0200 Message-ID: <20260730141454.497799928@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou commit 10358ea986c3c85516d1c8206486464f79d36e76 upstream. Cedrus consumes H.264 ref_pic_list0/ref_pic_list1 entries from the stateless slice control and later uses their indices to look up decode->dpb[] in _cedrus_write_ref_list(). Rejecting such controls in cedrus_try_ctrl() would break existing userspace, since stateless H.264 reference lists may legitimately carry out-of-range indices for missing references. Instead, guard the actual DPB lookup in Cedrus and skip entries whose indices do not fit the fixed V4L2_H264_NUM_DPB_ENTRIES array. This keeps the fix local to the driver use site and avoids out-of-bounds reads from malformed or unsupported reference list entries. Fixes: e000e1fa4bdbd ("media: uapi: h264: Update reference lists") Cc: stable@vger.kernel.org Signed-off-by: Pengpeng Hou Reviewed-by: Nicolas Dufresne Acked-by: Jernej Skrabec Tested-by: Chen-Yu Tsai Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c @@ -210,6 +210,9 @@ static void _cedrus_write_ref_list(struc u8 dpb_idx; dpb_idx = ref_list[i].index; + if (dpb_idx >= V4L2_H264_NUM_DPB_ENTRIES) + continue; + dpb = &decode->dpb[dpb_idx]; if (!(dpb->flags & V4L2_H264_DPB_ENTRY_FLAG_ACTIVE))