From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>, tze.yee.ng@altera.com
Subject: Re: [PATCH 5.15.y] firmware: stratix10-svc: fix memory leaks and list corruption bugs
Date: Thu, 30 Jul 2026 22:39:43 -0400 [thread overview]
Message-ID: <20260730203630.stable-0004@kernel.org> (raw)
In-Reply-To: <20260730023604.14996-1-tze.yee.ng@altera.com>
On Wed, Jul 29, 2026 at 07:36:04PM -0700, tze.yee.ng@altera.com wrote:
>- pmem = devm_kzalloc(chan->ctrl->dev, sizeof(*pmem), GFP_KERNEL);
>+ pmem = kzalloc_obj(*pmem);
Did you even build test this?
>@@ -944,16 +946,17 @@ void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr)
> {
> struct stratix10_svc_data_mem *pmem;
>
>+ guard(mutex)(&svc_mem_lock);
>+
> list_for_each_entry(pmem, &svc_data_mem, node)
This wouldn't work either, right?
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-07-31 2:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 13:28 FAILED: patch "[PATCH] firmware: stratix10-svc: fix memory leaks and list corruption" failed to apply to 5.15-stable tree gregkh
2026-07-30 2:36 ` [PATCH 5.15.y] firmware: stratix10-svc: fix memory leaks and list corruption bugs tze.yee.ng
2026-07-31 2:39 ` Sasha Levin [this message]
2026-08-03 12:16 ` NG, TZE YEE
2026-07-30 2:40 ` FAILED: patch "[PATCH] firmware: stratix10-svc: fix memory leaks and list corruption" failed to apply to 5.15-stable tree NG, TZE YEE
2026-08-04 11:17 ` [PATCH 5.15.y v2] firmware: stratix10-svc: fix memory leaks and list corruption bugs tze.yee.ng
2026-08-05 1:13 ` Sasha Levin
2026-08-05 2:43 ` NG, TZE YEE
2026-08-05 16:41 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730203630.stable-0004@kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tze.yee.ng@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox