Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, Johan Hovold <johan@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH 6.6.y 1/4] i2c: core: fix irq domain leak on adapter registration failure
Date: Thu, 30 Jul 2026 15:14:01 +0200	[thread overview]
Message-ID: <2026073056-nature-oversold-2714@gregkh> (raw)
In-Reply-To: <20260721182758.332454-1-sashal@kernel.org>

On Tue, Jul 21, 2026 at 02:27:55PM -0400, Sasha Levin wrote:
> From: Johan Hovold <johan@kernel.org>
> 
> [ Upstream commit 8ce19524e4cc2462685f596a6402fbd8fb984ab2 ]
> 
> Make sure to tear down the host notify irq domain on adapter
> registration failure to avoid leaking it.
> 
> This issue was flagged by Sashiko when reviewing another adapter
> registration fix.
> 
> Fixes: 4d5538f5882a ("i2c: use an IRQ to report Host Notify events, not alert")
> Cc: stable@vger.kernel.org	# 4.10
> Cc: Benjamin Tissoires <bentiss@kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Stable-dep-of: 07d5fb537928 ("i2c: core: fix adapter debugfs creation")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/i2c/i2c-core-base.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 943f0021d6a2c1..4b3bc72ef53ddf 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -1551,7 +1551,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
>  	res = device_register(&adap->dev);
>  	if (res) {
>  		pr_err("adapter '%s': can't register device (%d)\n", adap->name, res);
> -		goto out_list;
> +		goto err_remove_irq_domain;
>  	}
>  
>  	adap->debugfs = debugfs_create_dir(dev_name(&adap->dev), i2c_debugfs_root);
> @@ -1599,6 +1599,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
>  	init_completion(&adap->dev_released);
>  	device_unregister(&adap->dev);
>  	wait_for_completion(&adap->dev_released);
> +err_remove_irq_domain:
> +	i2c_host_notify_irq_teardown(adap);
>  out_list:
>  	mutex_lock(&core_lock);
>  	idr_remove(&i2c_adapter_idr, adap->nr);
> -- 
> 2.53.0
> 
> 

Didn't apply :(

      parent reply	other threads:[~2026-07-30 13:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 12:40 FAILED: patch "[PATCH] i2c: core: fix adapter debugfs creation" failed to apply to 6.6-stable tree gregkh
2026-07-21 18:27 ` [PATCH 6.6.y 1/4] i2c: core: fix irq domain leak on adapter registration failure Sasha Levin
2026-07-21 18:27   ` [PATCH 6.6.y 2/4] i2c: core: fix hang " Sasha Levin
2026-07-21 18:27   ` [PATCH 6.6.y 3/4] i2c: core: fix NULL-deref " Sasha Levin
2026-07-21 18:27   ` [PATCH 6.6.y 4/4] i2c: core: fix adapter debugfs creation Sasha Levin
2026-07-30 13:14   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026073056-nature-oversold-2714@gregkh \
    --to=greg@kroah.com \
    --cc=bentiss@kernel.org \
    --cc=johan@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox