From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C78EB3FFAB0 for ; Mon, 3 Aug 2026 14:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766653; cv=none; b=eUQnXuUKhpX0PwQfK/33aCDSRlAdRFlF/STVkCA5/I9iBYgFTogdtky27jFdvRknaZXoZAcoGooESsfqFOILPffuTN9pmE/gONxbpHK+2UloBOR/Bx4Pr1MW0Zxi/banf6nYR3tdHeynzDuLBsR+zZS8id6kTdULSVxPBJKRSKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766653; c=relaxed/simple; bh=E+PMGIEqdJEzntNkc/cXlKmXnPZXFP5wyGQ4Xlmg9rA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kImjDBtfBXPbAZIac2MgGU04FyD81RyKV4paMkw5s21EqQLP28XFjXU4wtSkJNMD/BJCDM8IjmDr/MA88twjJ6U8CjYxMk7Gz0zb9XGbkSZ1CfFT8Coa06B/8J7TKWyypXaw88JFNSD9xAKPUAC48bijr6Hspp1ctFPKuacCC2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CWryKh7E; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CWryKh7E" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-383cb94f742so3406347a91.3 for ; Mon, 03 Aug 2026 07:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766651; x=1786371451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4R15TfQbT6I06GeZOzblPl7rBfwuRyPXGr5wu9wmhkM=; b=CWryKh7Eqc60/syD0xcBd1GR/qAJENWYNqRupto/eY3v1p7XLby6WUY5xNGk2PQT6b Zhg0to5yuYa9V76jJLtDlO7OjOPifxehfvEMPpVMeS9zB852p5DBmttdS5JNpuDatM0T pDW4ujTJALNVZpUzmwm5sh2pHO3p9RwWCC1BlexYTQoUk+xS+ZhOnhQkR5w174QQhMXZ w+CRA92qWx3DkCcvzStgiKOFM29NSYsUdEuDwKGCDsmr3pUbneLQ876we1s6IQvDII/y 37z63r6SGOnJTisaFwIedo3oCK0YL/3kkXyZSkFyipxCix+o3b9Dud/IfvX0E7Yw7NMD UZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766651; x=1786371451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4R15TfQbT6I06GeZOzblPl7rBfwuRyPXGr5wu9wmhkM=; b=h2js6YDHDv7nEpFm5xLjPmhGF505lqmwCYx1yxdjEevbTxlEwyjheZj9GBCMQmpPTC 4lunuIdFD8WIL0/iBwxCCAwMW1UvM0kEmrdR4B+E6rrSyvoOK8zMQY36OTN/EMjrumAD GokYhoKrpxtDZalzCSzHP/OKBg04VImhk6Rt7X7muRwPIi/sJOcoy3EJLjTCtq2SAtEB 025fMcoWStnnooairLqilCl0lLwGamIxeSz9eprI9//me2tZXi3F6dHUpeB20F8Vw+L7 QxgM2xmOz+9IrIJThsmFVwCBnKmclfb3W96yZ7AeMZ27nFTu5NyVwGX52crvj5sLjOlB VeOw== X-Forwarded-Encrypted: i=1; AHgh+Rqo4lQj7fUvHyMfX4VK7xn2vy/Nr/h3PnQ1GZGzqOtqpTkX0i+pCIT28akLBXaAVIlj7+vYEck=@vger.kernel.org X-Gm-Message-State: AOJu0YzAfC7QltJzbkxhHeuPz0rl6REUbf4PnARK3gzx9VHPB2N2IhR6 jvd0RqDQUKF6RP7ztV2PEk1IKJEhlgOM7HrCDvzmEfrpwpVs0hC5mzRw X-Gm-Gg: AR+sD12RvoIRwtwCSNBEyqcQsWs7lUuMXrzquaIBldD6ddVqXzwRODpmrbj4Lfmjt4q O1HFbDcbdZTeOyzER0XT5PO7PpyEYqvYcS5OfCTzDt+EUsDvQzgCm38LwzBnkwlssiPlPsCvscg xdD62DkkapvyXYS+oYTRSJsciuFQS6KvQih4VclpgKzgCeJiNGiuV1oLlXHxJZ5Fo7Op3ond/L9 SuxT34iLZXnW7hRkPubeK0jrebWL8GRd3P5/8C2s1DNtjvllNKS2oUHEsXLFcD8PA/p+/sOwf7r qEm7hCVdowZUXEjHb7B3FAf2IQ7jGvyqHBaRkB/hDFAcH8Ohc7pSpUlaGmv31PZ/asogGmkduwO FT+WpHOM+FDTMzr1coAHls3SzWYo5KE06h7a6GxZnwkUZnCYbURVoLMB0/k2ZCArQNGG6QNevFp 1KWcJYGyfgRFb7TgV+kiURguWMoV1aGs+N2AgbivAfauEkAsIv4rbWz9KcUbIObrZsqR+EM9Rgj cfKzHzLXBqNan4aHyAx X-Received: by 2002:a17:90b:48c7:b0:381:26f:8f05 with SMTP id 98e67ed59e1d1-38fbc3ff29dmr8848847a91.3.1785766651087; Mon, 03 Aug 2026 07:17:31 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb30dff2esm4078462a91.13.2026.08.03.07.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:17:30 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Chen-Yu Tsai , Akari Tsuyukusa , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_)), stable@vger.kernel.org Subject: [PATCH 01/32] clk: mediatek: mt2712: fix memory leak on module removal Date: Mon, 3 Aug 2026 23:16:28 +0900 Message-ID: <20260803141659.559129-2-akkun11.open@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com> References: <20260803141659.559129-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk_mt2712_apmixed_probe() in clk-mt2712-apmixedsys.c does not call platform_set_drvdata(), but clk_mt2712_apmixed_remove() callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: c6368ce86435 ("clk: mediatek: mt2712-apmixedsys: Add .remove() callback for module build") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney --- drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c index 54b18e9f83f8..087cf574bcdc 100644 --- a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c @@ -129,6 +129,8 @@ static int clk_mt2712_apmixed_probe(struct platform_device *pdev) goto unregister_plls; } + platform_set_drvdata(pdev, clk_data); + return 0; unregister_plls: -- 2.55.0