From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9773A415F1A for ; Mon, 3 Aug 2026 14:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766676; cv=none; b=NxZu0G2lrobJukDR39KXt/hzHJWhc6waC0wnxFIyBoOWyjrh8cpJVJn1lQb6FRofNKAC12Hh2BLQ3kGqUEMa+P66j3eDFk6B/nYd60B9YglckfqzZvDgAcPx0oNOCg+cB+R5Swa1t6yIevXv5tqSw1mAr59xymD/tGYwhqAbh+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766676; c=relaxed/simple; bh=G59FL0kwCIrlNHdd8hEsY83x8QP+b4bNhWMWSKXFaE4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ekYh5XNfZHN2MT7QaxUMf2oYb1zTFal3hP79Nu1//pUNVmMoXtpeMgk01dgsZwylpubBwKmT2NztIlvTA55WmNjKBrJ2nyXwLSHs/QmGgDRKJGbXz9D2mSdCnzpo3Jh70a5r2TexE2jYYqf8PkbAI9/7IDkKaMYFVXUYLSYXb9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n0PGsxYJ; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n0PGsxYJ" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so3470163a91.3 for ; Mon, 03 Aug 2026 07:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766674; x=1786371474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1YUTKcwC82n8dRAk6Rq6PaXfV44JobcORSU/s+vRUxE=; b=n0PGsxYJi3Zcw+1Xviepu4tR1udQgxMMX5zE4+lqLoOLQcj49+H4dz2TZbyqvNvLpF std1ZJJOmklckUJDsi1AKmPkX1M+OhquwW7TGydssSkgzG2I1aqtt48vg/8ifkvjE8Kk pIHrNSENB48djBcDhPKMsJ8Ami/++Io/A1L4CMviQjrl8CaQ1UUSAJDL/I6cQaxV9qIN SPhZZCL9nZe/jNj+lT3fOtJ4iBOufGVtHAuNvxgkNwPEfapH1I8ZTpobLIBNsEteNmcS RhIrC61RUq6Pn3y/pSKNjDXv4hK7ZFhC4J36dG6Y14bfsXftkn3ovjv70Q5FMxE16ekP 7tWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766674; x=1786371474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1YUTKcwC82n8dRAk6Rq6PaXfV44JobcORSU/s+vRUxE=; b=CgiPiEECWNWO96g8wht/DiyOcpOjnxgckGQdFnJvmwOBbqeuIgVdkXo/zQ+rGpGqUH /SrExVeHjJ/+WM6m0hvQoF0MFgtnnTkDzmpyRe4UtmSbSZAfunOoHoC+5Z4fZeS4gyhR Mk7LSOdtXXXYlbpIGF9oJYYmD2I+HWGntogo5Rd8pRDilUIISftJRPD61b28npyhsCTd P1wL5K8yE469iPxHr/TkuBLqzQGOz0lfFcJI6G8QqpYX9cQpYEj/dFRqOHZcUdfU2Sev /xJ6yArOvJrn9zgQPrrY1mPtTCFVUsTjbhT9KS0Xy3JbSGjWFdJ0HTNSKk+/E12WiiW0 Achg== X-Forwarded-Encrypted: i=1; AHgh+RoVYhCHuYg8KqateKPYhQrz3SmNEhvZocd7W/Uw43dVoIMkouqL4azI+kq85PQctBS0NXfzY/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwB9wtUK/ctRWYLqMvauIM+qNqSjGn+e6FSPQmcNuQwSeqRSLYO +G1l738cT7RtwJi1itqhvMP56u+Cj9WGFlF1kvyAI2+Dg/Q5w7ino+YG X-Gm-Gg: AR+sD13099PUaSRkzReyfKE0S2uJb+D3pWIfGruRoMghHHdAjfgKuOuqKIh9kuhknz/ mUubzxXWtxYdih0yugSPeALOtWmWsPksrNnaxRFPCbqGFQHUkkcUt1EN9B53AI921O23RbsxGml v0mwlrqbcHBQyfifok9KoL9HMDHThN75l+LoHB3CuLm1y+msUE8M8NZ0E+nzY1FKyfuLFTN1g7z qy5xrKyyfYbECtcghdqCKRl+4ostzvuu9cSAPvWVdxGzXVC1y27WJ8nLh+b9o4vs6QboOrrNF38 MVGkEvqKnpIgY12NzZAUdmVdTnju0uHVPXIgydplg6bk4J8HZaSQHFyV3sBBeySFc0VZQ2RAWQB tSd6QqxM9gcuKZqxHvXBEa5k8cInBCL2AsnzrATESJ4rntfCy+mtl2Nxqf5JAWpn4e1g4Jn9ZxJ e2waOmt+NCwIoEbPoYVDj842x3m9lzSOq2ft/IQoUVC8K3KCxmpnCinlWrMWRoHamJZLoDnXtJe PTf7BbY/uIzWDmIeSts7NJxXsaae3E= X-Received: by 2002:a17:90b:4acb:b0:38f:aab1:5148 with SMTP id 98e67ed59e1d1-38fbc4313c2mr9516829a91.13.1785766673989; Mon, 03 Aug 2026 07:17:53 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb30dff2esm4078462a91.13.2026.08.03.07.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:17:53 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Chen-Yu Tsai , Akari Tsuyukusa , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_)), stable@vger.kernel.org Subject: [PATCH 06/32] clk: mediatek: mt8192: fix memory leak on module removal Date: Mon, 3 Aug 2026 23:16:33 +0900 Message-ID: <20260803141659.559129-7-akkun11.open@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com> References: <20260803141659.559129-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk_mt8192_apmixed_probe() in clk-mt8192-apmixedsys.c does not call platform_set_drvdata(), but clk_mt8192_apmixed_remove() callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 124294ff468f ("clk: mediatek: mt8192: Move apmixedsys clock driver to its own file") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney --- drivers/clk/mediatek/clk-mt8192-apmixedsys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8192-apmixedsys.c b/drivers/clk/mediatek/clk-mt8192-apmixedsys.c index b0563a285bd6..e6ac40e2f12d 100644 --- a/drivers/clk/mediatek/clk-mt8192-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8192-apmixedsys.c @@ -176,6 +176,8 @@ static int clk_mt8192_apmixed_probe(struct platform_device *pdev) if (r) goto unregister_gates; + platform_set_drvdata(pdev, clk_data); + return r; unregister_gates: -- 2.55.0