From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Hyunwoo Kim <imv4bel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH] KVM: x86: Check for invalid/obsolete root *after* making MMU pages available
Date: Mon, 10 Aug 2026 19:57:40 -0400 [thread overview]
Message-ID: <20260810234738.0001-1-sashal@kernel.org> (raw)
In-Reply-To: <20260808062208.522577-1-senozhatsky@chromium.org>
> Conflicts:
> arch/x86/kvm/mmu/mmu.c
> arch/x86/kvm/mmu/paging_tmpl.h
The 6.1 resolution has two problems I think.
The new call sites pass two arguments, but 6.1 declares
is_page_fault_stale(vcpu, fault, mmu_seq) - so I'm not sure why you're not
seeing a build breakage.
Upstream could move the check because direct_page_fault() is shadow-MMU-only
there. On 6.1 it still serves both MMUs and dispatches on is_tdp_mmu_fault, so
relocating the check into the shadow arm leaves kvm_tdp_mmu_map() with no check
and no mmu_invalidate_retry_hva() retry.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-08-10 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 6:22 [PATCH] KVM: x86: Check for invalid/obsolete root *after* making MMU pages available Sergey Senozhatsky
2026-08-08 6:27 ` Sergey Senozhatsky
2026-08-10 14:08 ` Sean Christopherson
2026-08-10 14:40 ` Sergey Senozhatsky
2026-08-10 22:47 ` Sean Christopherson
2026-08-11 1:49 ` Sergey Senozhatsky
2026-08-10 23:57 ` Sasha Levin [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-21 10:28 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810234738.0001-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=imv4bel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=senozhatsky@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox