From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E16C93C8C46; Mon, 17 Aug 2026 13:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974122; cv=none; b=Rt3HHHhOfGoOkFzJL5K5kLbMGMkEyfHYwXF/eVfVljg1B9rMDEx3K78bIZpc49lKfsHJEiFeKRk56a3tPD/WKyoBhxCY5+IfMOkEU1btVV0efHex60LdIqOQvefgG0S8F/5QRXKRBMpuHgVnfIUFAZTKr0SQyvBCdXMjBIebxLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974122; c=relaxed/simple; bh=kIW6Ztw50UrvarckqzKhW8E04Yxzi+1H/nmfdJd6cY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZsipOAI7X3JeRr+R7//An2Tg/GLXzf4fEGS5d0FzbE6+hm+RE7SV11CBvtBfVoM2eKypvJ3ISrBVcKW50bBSoPiOF8Z/fwIC2eECuZ8DGgwn6khp8cuWZIVfAegS4WdW3nMjA/XzFncwl34HiMCsTijAyqsJU6r+SSM1AW+IDSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Me7CCGOh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Me7CCGOh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24B791F00A3A; Mon, 17 Aug 2026 13:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786974120; bh=/5W/a2f3qySdmfv6A9hlv/fHBaxfAB+7hK0JBeKWGJ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Me7CCGOh990dzC1t+IjQiMvGTUs9vuuz2nse59XMLjBIhlTcSUNvLS2QfQAsYV31l 2UjHaUBLroyiHSn/HqMn+Xn8tiSbEPcp95OECZfs83fxRpMdo/uVHm0EOLZollL8W5 DssiWprArCYuCnoDc7K7F/KCrfFx68+8w0/3icIg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pavan Chebbi , Keegan Freyhof , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 7.1 097/271] bnxt_en: Fix PTP PPS setting bug Date: Mon, 17 Aug 2026 15:30:22 +0200 Message-ID: <20260817132540.780430910@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132536.752504388@linuxfoundation.org> References: <20260817132536.752504388@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Keegan Freyhof [ Upstream commit 80eaf88efec33ac77ed7726d066c4f2f932cc329 ] The existing driver logic is always turning on PTP_CLK_REQ_PPS regardless of the "on" parameter passed to bnxt_ptp_enable(). During shutdown, PTP_CLK_REQ_PPS may be turned off and this bug will do the opposite and may trigger a PCIe PTM request TLP. On some systems this can trigger a PCIe AER. Fix it by properly configuring PTP_CLK_REQ_PPS based on the "on" parameter. Fixes: 9e518f25802c ("bnxt_en: 1PPS functions to configure TSIO pins") Reviewed-by: Pavan Chebbi Signed-off-by: Keegan Freyhof Signed-off-by: Michael Chan Link: https://patch.msgid.link/20260731190937.807270-6-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 5d41dc1bc7820..b89293dfd2d1e 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -495,12 +495,15 @@ static int bnxt_ptp_enable(struct ptp_clock_info *ptp_info, return rc; case PTP_CLK_REQ_PPS: /* Configure PHC PPS IN */ - rc = bnxt_ptp_cfg_pin(bp, 0, BNXT_PPS_PIN_PPS_IN); + pin_id = 0; + if (!on) + break; + rc = bnxt_ptp_cfg_pin(bp, pin_id, BNXT_PPS_PIN_PPS_IN); if (rc) return rc; rc = bnxt_ptp_cfg_event(bp, BNXT_PPS_EVENT_INTERNAL); if (!rc) - ptp->pps_info.pins[0].event = BNXT_PPS_EVENT_INTERNAL; + ptp->pps_info.pins[pin_id].event = BNXT_PPS_EVENT_INTERNAL; return rc; default: netdev_err(ptp->bp->dev, "Unrecognized PIN function\n"); -- 2.53.0