From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A97425228D; Thu, 20 Aug 2026 15:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787239099; cv=none; b=eZ7NERun2nsBT4y2GRwLHI8Nq3l7fU5LeDQzkZm/4+F3f6h//+0ykawUvrt65z1Nw2RV1ulRbvmoXNGg9T2xxzfQA5LeUc4gKKy3rmiSG7E9ubHjkU+vDFKC0a4pzAagPlxnoN8enHL6MTiMYB0Hwox0tHvGEeUQ6mtLxu+9ef8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787239099; c=relaxed/simple; bh=f7tS1lrJG944tv2I8rGDiefBGxm4ZWeP1mKtTS3vtGA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OfoglWc06M7XUcTDrQcbmC5oeZM6vfts7gPBOZP3GURGf7zdIQdA2sAfLANSdsdKyeouNIqFDdL1hpw4h3vllVcVslhNFmBkiC0I3rC9sTYXVLuldrqALsTSg9swjIya1LW+bC7PA6coMVg8CB7BGwN7VzpYzStIzikspXloA9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Os4XC0Kw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Os4XC0Kw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D371F000E9; Thu, 20 Aug 2026 15:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787239098; bh=YdYJCB5IO48GL4Zix2egrYIQi/uoItqTpJT3BSFyLWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Os4XC0KwUjYYkuV/n+2awc/NyJxiegMPNz7rWZCOGnVHIKGEvU9h6IuX4a8H9zOlZ YtEHliWhuBwoZjBL24i9wrjBcSfBkwMqY6mXbut2Ai7IqVqz1/KnF7S9CSt3yiXn57 Xr8R0EOAN1Dlp6Lzw3QVq6c9dMjE3oCU2hGQLD30= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cezary Rojewski , Mark Brown , Sasha Levin Subject: [PATCH 6.18 148/217] ASoC: tas2562: Validate values for volume writes Date: Thu, 20 Aug 2026 16:55:16 +0200 Message-ID: <20260820145242.208963662@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145237.531699751@linuxfoundation.org> References: <20260820145237.531699751@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Brown [ Upstream commit 8fb41964f7e4e4207c8999af2056894caa7a252a ] tas2562_volume_control_put() does not do any validation of the control value written by userspace, it uses it to look up a value in a fixed size array which can easily be overflowed and then writes whatever value it gets back to the device. Add validation that we are loading a value we have in the array. Cc: stable@vger.kernel.org Reviewed-by: Cezary Rojewski Link: https://patch.msgid.link/20260715-asoc-tas2562-put-retval-v1-1-97bf467c924e@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/tas2562.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -472,10 +472,15 @@ static int tas2562_volume_control_put(st { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct tas2562_data *tas2562 = snd_soc_component_get_drvdata(component); - int ret; + int ret, index; u32 reg_val; - reg_val = float_vol_db_lookup[ucontrol->value.integer.value[0]/2]; + index = ucontrol->value.integer.value[0] / 2; + if (index < 0 || index >= ARRAY_SIZE(float_vol_db_lookup)) + return -EINVAL; + + reg_val = float_vol_db_lookup[index]; + /* * The device applies the 32-bit coefficient to the playback path on * the write to DVC_CFG4 (the LSB, book 0 page 2 reg 0x0F), so the