From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4D32412276 for ; Mon, 24 Aug 2026 12:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787574076; cv=none; b=OGlF3vtsPkO6YhIPLMWwBTqqrjNA4I/jv8TQQG9skqYu1Ht6ES2Wz0D1ZZstzaoG2JbnMroSWd+3IhxJRzLi9ndeMFkEgf90bHt6q92figHvIPVMZ7PF8yKZxRgkxWH1/EtwJr1j6b42ujmVzWSx/tRdtnsbRedKM+ZaI9zFRao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787574076; c=relaxed/simple; bh=lUfN3cbji+knVd3K1Xaq1ti3CfMO50Sf5r8ujeK4eMw=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=Bc/cUZvFvDVtEAHLqjtJL1W7i/HhvTBE1ajYnVsA4xySgAQZO4lBDRR7FgOKakb+FNj79KCQNQkc7BK4B5IIfZdtBSFBKt92Wu15kbuyft9FHEuWLBxgHC913mVZ72bQLLrs5XjSznisJ92HN+fMFI+hvc6emjydwHHeVT8Bz64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tbTSGVzF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tbTSGVzF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA7E21F000E9; Mon, 24 Aug 2026 12:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787574074; bh=Yjq714gPA6ffLfW68EP+r6ZKjzIoNc8WblMihBk1RVk=; h=Subject:To:Cc:From:Date; b=tbTSGVzFnPVg2EIU+9rRdLSP4tkRfQZY8HSPk3eaTOwWuf5eesNbMKHtvozF5ozfz JcwMHRomBroEpLeA3ULd6HDtbnkeGjV1NbT0AEsHlREJJrVIjz4PCfgK7uBro9lBGG kazNOYa05LLqOxvhPPF5R5+2BsyuWMGTf5Cb6ptI= Subject: FAILED: patch "[PATCH] nilfs2: reject invalid block index in GC ioctl" failed to apply to 5.10-stable tree To: konishi.ryusuke@gmail.com,slava@dubeyko.com,wuyankun@uniontech.com Cc: From: Date: Mon, 24 Aug 2026 14:20:55 +0200 Message-ID: <2026082455-batch-papyrus-5e86@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x a1735eae55448bc79c2da6593455791e886f6ed8 # git commit -s git send-email --to '' --in-reply-to '2026082455-batch-papyrus-5e86@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From a1735eae55448bc79c2da6593455791e886f6ed8 Mon Sep 17 00:00:00 2001 From: Ryusuke Konishi Date: Fri, 3 Jul 2026 01:07:19 +0900 Subject: [PATCH] nilfs2: reject invalid block index in GC ioctl Syzbot reported list corruption caused by a double list_add_tail() call on bh->b_assoc_buffers within nilfs_lookup_dirty_data_buffers(). Analysis revealed that the root cause was the insertion of a page/folio with a page index of ULONG_MAX into the page cache via the GC ioctl. filemap_get_folios_tag(), called by nilfs_lookup_dirty_data_buffers(), repeatedly detects a dirty folio with a page index of ULONG_MAX due to index wrap-around, leading to duplicate processing of dirty buffers. As a preparatory step, the GC ioctl loads the page/folio of the block to be moved during GC and inserts it into the page cache based on information in the nilfs_vdesc structure passed as an argument. Normally, this does not cause issues because the user-space GC library configures the nilfs_vdesc structure properly. However, since there is no range check on the parameters determining the page index, a request with artificially crafted parameters -- such as those generated by Syzbot -- can result in a page/folio being inserted with a page index of ULONG_MAX, triggering the above problem. This resolves the issue by checking the ranges of 'vd_offset' and 'vd_vblocknr' in the nilfs_vdesc structure that determine the page index, thereby preventing the invalid page/folio insertions. Reported-by: syzbot+c37bed40868932d790e9@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c37bed40868932d790e9 Fixes: 7942b919f732 ("nilfs2: ioctl operations") Cc: wuyankun Cc: stable@vger.kernel.org Signed-off-by: Ryusuke Konishi Signed-off-by: Viacheslav Dubeyko diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index b73f2c5d10f0..0957316e58b8 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c @@ -527,6 +527,7 @@ static int nilfs_ioctl_get_bdescs(struct inode *inode, struct file *filp, * Return: 0 on success, or one of the following negative error codes on * failure: * * %-EEXIST - Block conflict detected. + * * %-EINVAL - Invalid virtual block descriptor. * * %-EIO - I/O error. * * %-ENOENT - Requested block doesn't exist. * * %-ENOMEM - Insufficient memory available. @@ -536,15 +537,30 @@ static int nilfs_ioctl_move_inode_block(struct inode *inode, struct list_head *buffers) { struct buffer_head *bh; + __u64 limit_blkidx = (__u64)inode->i_sb->s_maxbytes >> inode->i_blkbits; int ret; - if (vdesc->vd_flags == 0) + /* + * vblocknr 0 is reserved as an invalid pointer. Also, limit_blkidx + * ensures that the page index converted from vd_vblocknr never + * overflows the page cache limit and respects the architecture's bmap + * key width. + */ + if (unlikely(vdesc->vd_vblocknr == 0 || + vdesc->vd_vblocknr >= limit_blkidx)) + return -EINVAL; + + if (vdesc->vd_flags == 0) { + if (unlikely(vdesc->vd_offset >= limit_blkidx)) + return -EINVAL; + ret = nilfs_gccache_submit_read_data( inode, vdesc->vd_offset, vdesc->vd_blocknr, vdesc->vd_vblocknr, &bh); - else + } else { ret = nilfs_gccache_submit_read_node( inode, vdesc->vd_blocknr, vdesc->vd_vblocknr, &bh); + } if (unlikely(ret < 0)) { if (ret == -ENOENT)