Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
	stable@vger.kernel.org, Donglin Lyu <DongLin_Lyu@outlook.com>,
	Ruslan Shevchenko <adefka@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 6.18.y 2/2] Input: atkbd - skip deactivate for HONOR ZQC-P
Date: Tue, 25 Aug 2026 07:49:34 -0400	[thread overview]
Message-ID: <202608250014.ba830edb041ce9ea@kernel.org> (raw)
In-Reply-To: <2026082459-tweezers-freedom-b725@gregkh>

On Mon, Aug 24, 2026 at 05:15:41PM +0200, Greg KH wrote:
> And this patch differs a lot from the original, why not just backport
> the id table changes that were done in the meantime instead?

It doesn't differ - 2/2 is a identical cherry-pick of 410c44b10967 ("Input:
atkbd - skip deactivate for HONOR ZQC-P"). The only differences from the
upstream patch are the index lines and the hunk offsets. The 13/5 diffstat is
upstream's own doing: that is the "[dtor: keep all HONOR entries together]"
reorder Dmitry did in the same commit.

And the id table change done in the meantime is patch 1/2 - 2aaf33c6e1e8
("Input: atkbd - skip deactivate for HONOR FMB-P's internal keyboard").
Of the quirk-table commits between v6.18 and 410c44b10967, 6.18.y already
has all of them except FMB-P, which is precisely why the plain cherry-pick
of 2/2 failed. With 1/2 in, the table matches upstream's pre-410c44b10967
state and 2/2 applies verbatim.

So both as sent should be fine.

-- 
Thanks,
Sasha

      parent reply	other threads:[~2026-08-25 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 11:07 FAILED: patch "[PATCH] Input: atkbd - skip deactivate for HONOR ZQC-P" failed to apply to 6.18-stable tree gregkh
2026-08-24 14:50 ` [PATCH 6.18.y 1/2] Input: atkbd - skip deactivate for HONOR FMB-P's internal keyboard Sasha Levin
2026-08-24 14:50   ` [PATCH 6.18.y 2/2] Input: atkbd - skip deactivate for HONOR ZQC-P Sasha Levin
2026-08-24 15:15     ` Greg KH
2026-08-24 15:20       ` Greg KH
2026-08-25 11:49       ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608250014.ba830edb041ce9ea@kernel.org \
    --to=sashal@kernel.org \
    --cc=DongLin_Lyu@outlook.com \
    --cc=adefka@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox