From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E1A93F7899 for ; Wed, 26 Aug 2026 12:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787749039; cv=none; b=KqvM2HSGXUxkIIYr3PA8w9+l+qw4qAXZzN3VgoEb6b305/Asj3y/vRlCXHOanauYmISC76aOFQ6EJHykUbvKKnyhF4ft5g6qi1PWY+v8gVJSH7Hzz+7rS0Vu18vVtj+WX2Wgxn/ePT5USAXaQO4eiibpFpFWlxu/8htL+OfIEv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787749039; c=relaxed/simple; bh=ERGZNhMhm1ystwHRzoHfFg/CdmFzgCd9EU2JGdas+P0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V06VgR1F2hSrZOMgupnmzjNcVA4VyGSPfdmY2e0+U19N5c0jz89sL8YzWHOMICbDrDfiIqf4IHFaEsGr+eZ2j8MXdpbl88EfhpSbPcZV3YIoDTVXt/28rDmfaWuxlHcAa0QvJR+ttHnK26gtS3z2dzbgvNpkjN/iqEh02ModpSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gd1ioPsn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gd1ioPsn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 932781F00A3A; Wed, 26 Aug 2026 12:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787749038; bh=IkYIkK5MwFTEfGiLC728lzG+daC2WVWA1XY+wKtlZPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Gd1ioPsn2bFnRLk5vRfZe2eLylr/h8KZDErAeaZ8uH2C+GqODtXM9SDcBmkw+/+Xl B0iJUUQXPdlRsF4MfbXk1ZgDImrINq2yP9JN866MFUn/1EpX3CWKPdIv2tZ8+4BP4A BlU6Mz9njsOOve/8K3ipEmeQn3aKyHAo3JYzG7dqeg8ncGHWKVmgB/Qr52UL5fNCno /B+2yi7D1MwUdriFXTM2ONmggyrYDF1DQ/IZNoDpbKemr1ceDMWLb9002lPYNvAO8s VIVCjji70UlPXjS/cOAohraVpyxBXJRG1QKA6P2FKFb17nsZrGBmlyLNMyybJNRLxl n//s3Wz9FKnvw== From: Sasha Levin To: stable@vger.kernel.org Cc: =?UTF-8?q?Jose=20Villase=C3=B1or=20Montfort?= , Alec Hall , Jiri Kosina , Sasha Levin Subject: [PATCH 6.1.y 2/2] HID: magicmouse: prevent unbounded recursion in magicmouse_raw_event() Date: Wed, 26 Aug 2026 08:57:14 -0400 Message-ID: <20260826125714.2952673-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826125714.2952673-1-sashal@kernel.org> References: <2026082525-sculptor-tubeless-a928@gregkh> <20260826125714.2952673-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Jose Villaseñor Montfort [ Upstream commit db8d634128d2ba88d79c0b601e983ebe14bb0519 ] magicmouse_raw_event() handles DOUBLE_REPORT_ID (0xf7) packets, which pack two touch reports into one, by splitting the packet and calling itself on each half. The only guard against runaway recursion is a "size < 1" check, which stops zero-sized calls but does not bound the recursion depth. A malicious HID device that matches this driver can send a report starting with DOUBLE_REPORT_ID and filled with the sequence [0xf7, 0x00]. Each level consumes two bytes and recurses on the remainder, so an incoming report of up to HID_MAX_BUFFER_SIZE (16 KiB) drives roughly 8000 nested calls. That easily exhausts the 16 KiB kernel stack, leading to a stack overflow: a panic with CONFIG_VMAP_STACK, or memory corruption without it. A double report only ever wraps two normal reports; it is never legitimately nested. Refuse to re-enter the DOUBLE_REPORT_ID case from a recursive call so the recursion depth is bounded to two, while all valid packets keep being parsed exactly as before. Fixes: a462230e16ac ("HID: magicmouse: enable Magic Trackpad support") Link: https://lore.kernel.org/linux-input/20260706181347.700DB1F00A3F@smtp.kernel.org/ Cc: stable@vger.kernel.org Signed-off-by: Jose Villaseñor Montfort Reviewed-by: Alec Hall Tested-by: Alec Hall Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-magicmouse.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c index de13f4ec5dfd4..31cea46dee903 100644 --- a/drivers/hid/hid-magicmouse.c +++ b/drivers/hid/hid-magicmouse.c @@ -377,8 +377,8 @@ static void magicmouse_emit_touch(struct magicmouse_sc *msc, int raw_id, u8 *tda } } -static int magicmouse_raw_event(struct hid_device *hdev, - struct hid_report *report, u8 *data, int size) +static int __magicmouse_raw_event(struct hid_device *hdev, + struct hid_report *report, u8 *data, int size, bool nested) { struct magicmouse_sc *msc = hid_get_drvdata(hdev); struct input_dev *input = msc->input; @@ -489,6 +489,15 @@ static int magicmouse_raw_event(struct hid_device *hdev, * packet. */ + /* + * A double report only ever wraps two normal reports, so it is + * never nested. Refuse to recurse a second time; otherwise a + * malicious device could chain DOUBLE_REPORT_ID packets to drive + * unbounded recursion and overflow the kernel stack. + */ + if (nested) + return 0; + /* Ensure that we have at least 2 elements (report type and size) */ if (size < 2) return 0; @@ -500,9 +509,9 @@ static int magicmouse_raw_event(struct hid_device *hdev, return 0; } - magicmouse_raw_event(hdev, report, data + 2, data[1]); - magicmouse_raw_event(hdev, report, data + 2 + data[1], - size - 2 - data[1]); + __magicmouse_raw_event(hdev, report, data + 2, data[1], true); + __magicmouse_raw_event(hdev, report, data + 2 + data[1], + size - 2 - data[1], true); return 0; default: return 0; @@ -527,6 +536,12 @@ static int magicmouse_raw_event(struct hid_device *hdev, return 1; } +static int magicmouse_raw_event(struct hid_device *hdev, + struct hid_report *report, u8 *data, int size) +{ + return __magicmouse_raw_event(hdev, report, data, size, false); +} + static int magicmouse_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { -- 2.53.0