From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC7637AA77 for ; Thu, 3 Sep 2026 23:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788479812; cv=none; b=VPRULl6ynb4ASDLm9NMvJCza8e6Cc0rFvCjWpZIhOMTB0rDf+R2ZabOK11S6lU357KI+T3pXnJUkujshAn73nal31q+X+OfKLnJTBXq0i3Y/5GtOlwF6DWD26cUeDnkf0kd4I51BKuC8jeLFDd/FEbPQop+VA7IXDnrPVtuzTUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788479812; c=relaxed/simple; bh=PEo9OCZlZIX4OW9b5u8fZIMYpiy5yPLTpADaqMjifh8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ET1546FWWIOUBqo+kBC6kqKRS7/R7eF67Z/7eyZvsCOZJKIKrbLZ5KhYkQw/J9hcxMht2pKWTpu1sluoDVqnIHhj85bkIok3eCG8bPfGUA0Xa3XdaVN29z7YwShj6Hu8eNUDPUqNpID26hmgry9Hm+oDn1kphTJFsBRgmcoN/30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EJ8gyj9N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EJ8gyj9N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A7911F00AC4; Thu, 3 Sep 2026 23:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788479802; bh=WjYuaMPHWRW1HV8fZgAKFp32fMMC0oavyYUR6v9JkOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EJ8gyj9Nhr0l2utot8sjKG6GIs90dzKYjIiJJheE2vxBhLlfcGmmd6T2nQhld1PrK DDI9RX0/ul6bpu4RhzwT+yF9wJXDQQ2N/a9fwuSZ8+uNwic3XWzQPk99cHVHKnbyz0 hsoXOlDaHLaOC5ZAqP/ntCRq/QItge50shIphBijMoyktJ3xaQqJGK9KKpGwA0M6Kv M830Oigj7VFeiXJYJDQCH2P6HnrBLhiUCTlhk5LmLWwa5HbyEhmPTZu7euk6mk/gDN U8I6YWI1UMvPx2lmAvmMQXCV4Gblj3aZmIej7pnyByTPPbuTAOUdZl8kbh5aa6Vrw1 1u7f9lC8UZp7A== From: Sasha Levin To: stable@vger.kernel.org Cc: Ye Liu , Sashiko , Zi Yan , "Vlastimil Babka (SUSE)" , Brendan Jackman , Johannes Weiner , Lorenzo Stoakes , Michal Hocko , Suren Baghdasaryan , "David Hildenbrand (Arm)" , Andrew Morton , Sasha Levin Subject: [PATCH 6.1.y] mm/page_owner: use memcg_data snapshot to avoid TOCTOU in print_page_owner_memcg() Date: Thu, 3 Sep 2026 19:56:39 -0400 Message-ID: <20260903235639.1811043-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090314-dagger-sharpness-8cd1@gregkh> References: <2026090314-dagger-sharpness-8cd1@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Ye Liu [ Upstream commit 90f095b816e25c6a9e4446d299bac5007fdcb3df ] print_page_owner_memcg() reads page->memcg_data via READ_ONCE() at the start to guard against tail pages and NULL data. However, it later re-reads page->memcg_data locklessly in two places: 1: page_memcg_check(page) 2: PageMemcgKmem(page) (via folio_memcg_kmem(), which includes VM_BUG_ON assertions for tail pages and MEMCG_DATA_OBJEXTS) If the page is concurrently freed and reallocated as a THP tail page or slab page between these calls, the VM_BUG_ON assertions can trigger on CONFIG_DEBUG_VM=y builds, crashing the kernel. Fix both TOCTOU issues by using the memcg_data snapshot throughout. Link: https://lore.kernel.org/20260714015117.78351-10-ye.liu@linux.dev Fixes: fcf8935832b8 ("mm/page_owner: print memcg information") Signed-off-by: Ye Liu Reported-by: Sashiko Reviewed-by: Zi Yan Reviewed-by: Vlastimil Babka (SUSE) Cc: Brendan Jackman Cc: Johannes Weiner Cc: Lorenzo Stoakes Cc: Michal Hocko Cc: Suren Baghdasaryan Cc: David Hildenbrand (Arm) Cc: Signed-off-by: Andrew Morton [ adapted memcg_data decoding to Linux 6.6’s mixed mem_cgroup and obj_cgroup representation. ] Signed-off-by: Sasha Levin --- mm/page_owner.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 2d27f532df4c1..797fca82d4fa8 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -361,20 +361,28 @@ static inline int print_page_owner_memcg(char *kbuf, size_t count, int ret, { #ifdef CONFIG_MEMCG unsigned long memcg_data; + struct obj_cgroup *objcg; struct mem_cgroup *memcg; bool online; char name[80]; rcu_read_lock(); memcg_data = READ_ONCE(page->memcg_data); - if (!memcg_data) + if (!memcg_data || PageTail(page)) goto out_unlock; - if (memcg_data & MEMCG_DATA_OBJCGS) + if (memcg_data & MEMCG_DATA_OBJCGS) { ret += scnprintf(kbuf + ret, count - ret, "Slab cache page\n"); + goto out_unlock; + } - memcg = page_memcg_check(page); + if (memcg_data & MEMCG_DATA_KMEM) { + objcg = (void *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); + memcg = objcg ? obj_cgroup_memcg(objcg) : NULL; + } else { + memcg = (void *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); + } if (!memcg) goto out_unlock; @@ -382,7 +390,7 @@ static inline int print_page_owner_memcg(char *kbuf, size_t count, int ret, cgroup_name(memcg->css.cgroup, name, sizeof(name)); ret += scnprintf(kbuf + ret, count - ret, "Charged %sto %smemcg %s\n", - PageMemcgKmem(page) ? "(via objcg) " : "", + (memcg_data & MEMCG_DATA_KMEM) ? "(via objcg) " : "", online ? "" : "offline ", name); out_unlock: -- 2.53.0