From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17879344D9D for ; Thu, 3 Sep 2026 14:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788445916; cv=none; b=qKoauESfek2xWzAVaKJiOcaT5MA/Po6J/7zkdvs9vYgXGumsxJSW8wzjFd3mxzNl953Jn9ZOxuKcw+lkRk07vxN+G0nNM6+IPHOg0q+Z7CuGyydU6uD6Hi9L9R/YB3tQNZJ9Wm0Jsz+WE5BzQeNNS1eGL6YqDDYpXpqNS7KcJjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788445916; c=relaxed/simple; bh=pKzgjiYyAOxacEVjZeWHTqQ8h2gx70fxnZ43Y7n2Gks=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=tH351CvTYjA0ZLeNYxuscPzkgivzkuWa8hQ5foejJXNGo6ewlX/xl2Rf7UhdeAx8lvlUwarP/Kri0J+JGPN7PhJsN1sQMB8FFhpL/SyTdZrLofGlVuIvzU9z5tPy9EAmVkQi+zqlho7118hClvUBmxfNpP4VxcqwD/a9/i9IawA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0VksZ72B; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0VksZ72B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93A8C1F00A3D; Thu, 3 Sep 2026 14:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788445906; bh=i3vpfXV55DoFfWfBf3g+TtwUUYdRxZ3nbQnJSqZdse0=; h=Subject:To:Cc:From:Date; b=0VksZ72BObwl1Fmc8xgKmQiGaPqncfMbJ0b+RP6TEB3zZXILx7HcYUkXrPBIoNzFS IoRvak/2RhVI2mym/PtJoRVMvDDy76qygcTVyN29X+I0xWl0/NvPb3VfiVOnMLSjr2 ri/f57oA9eUJB9MCUCI8U9K8QeGz5YJoM/pAt+Fo= Subject: FAILED: patch "[PATCH] svcrdma: Reject Read lists that exceed the page budget" failed to apply to 6.1-stable tree To: cel@kernel.org,chuck.lever@oracle.com Cc: From: Date: Thu, 03 Sep 2026 16:10:31 +0200 Message-ID: <2026090331-sugar-disloyal-01f5@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 0ca487abb3bdf581851664b5db21f364caf57682 # git commit -s git send-email --to '' --in-reply-to '2026090331-sugar-disloyal-01f5@gregkh' --subject-prefix 'PATCH 6.1.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0ca487abb3bdf581851664b5db21f364caf57682 Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Tue, 26 May 2026 13:34:54 -0400 Subject: [PATCH] svcrdma: Reject Read lists that exceed the page budget Individual Read segment lengths are validated at decode time, but nothing prevents a requester from sending multiple segments whose cumulative length exceeds the rq_pages array budget. When one segment fills the page array exactly, the runtime guard in svc_rdma_build_read_segment() is bypassed because len reaches zero. A subsequent segment then accesses the NULL sentinel slot at rq_pages[rq_maxpages], resulting in a NULL pointer dereference during DMA mapping. Accumulate pages across all Read segments and reject the message at decode time when the total would overflow the page budget. Fixes: 026d958b38c6 ("svcrdma: Add recvfrom helpers to svc_rdma_rw.c") Cc: stable@vger.kernel.org Signed-off-by: Chuck Lever diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c index d64b5f78ce8a..fdfed1be97da 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c @@ -440,11 +440,14 @@ static void svc_rdma_build_arg_xdr(struct svc_rqst *rqstp, * to the first byte past the Read list. rc_read_pcl and * rc_call_pcl cl_count fields are set to the number of * Read segments in the list. - * %false: Read list is corrupt. @rctxt's xdr_stream is left in an - * unknown state. + * %false: Read list is corrupt or exceeds the page budget. @rctxt's + * xdr_stream is left in an unknown state. */ static bool xdr_count_read_segments(struct svc_rdma_recv_ctxt *rctxt, __be32 *p) { + unsigned int maxlen = rctxt->rc_maxpages << PAGE_SHIFT; + unsigned int total_len = 0; + rctxt->rc_call_pcl.cl_count = 0; rctxt->rc_read_pcl.cl_count = 0; while (xdr_item_is_present(p)) { @@ -458,7 +461,10 @@ static bool xdr_count_read_segments(struct svc_rdma_recv_ctxt *rctxt, __be32 *p) xdr_decode_read_segment(p, &position, &handle, &length, &offset); - if (length > rctxt->rc_maxpages << PAGE_SHIFT) + if (length > maxlen) + return false; + total_len += length; + if (PAGE_ALIGN(total_len) > maxlen) return false; if (position) { if (position & 3)