From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C587080D; Fri, 4 Sep 2026 05:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788498966; cv=none; b=G24+jD7GIuEzyUxVOS1BeXmDyZ8/Pt6tosUFiC0zgX2ijUmSIh54kw3hghn76uuOhrNp9Y5E0xNlB2PJ8Ek7TYuBJdVTk8uGg1VDBP55VXGJesd6fnBc8sVvShtI1768G1ih7YgMJ06okAItt+K42tcOsQym34iq3onS+zcWa7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788498966; c=relaxed/simple; bh=STuI/g7oVOQEQdOzP/nmoUrveM3WCrP9h0pByKBIrlY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZpyYtu3DoSNFADHu+E8VXuFKrqFk2ht/niz8rt/YF0U64IUcJQCa3JErEvsq/jRaCCiZsVZ0aj26b5gFldawbcKv4rpKjKFQMwVwsvKeUlE5TntEDij4PQNNkomlgSti1v88EjZ8gJt71dgsaV2doR5yRfu73pvsxhYdaVbXMMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bUDTjLMI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bUDTjLMI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 607461F00A3E; Fri, 4 Sep 2026 05:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788498964; bh=T1LE1TD66En1eUvS4k88ihFfNtenuWbx5ad14Kw0hmg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bUDTjLMIijSgtaSaFE1kwOau5Ze8nbM1jwFqaUg1Bc0BrkBMlgbSEOoLDflwvs7SI y1ta+OwwZJR0i5Of51mtdkj2FmCnmS0MqcRhf6tKms4Av+QnIZBazGuKDe7TcFi7x+ WtOnNxd9cdK1EAeJfclcKaEgWYJUwlWSbUgpDXRA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xu Rao , Jiri Kosina Subject: [PATCH 7.2 249/713] HID: roccat: free buffered reports when destroying device Date: Fri, 4 Sep 2026 06:53:37 +0200 Message-ID: <20260904045809.415765241@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045803.810145556@linuxfoundation.org> References: <20260904045803.810145556@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xu Rao commit bbff0ccbff360a5498075525005f6a913239a3d7 upstream. roccat_report_event() duplicates each report with kmemdup() and stores the allocation in a circular-buffer slot. The allocation is released only when that slot is reused. The device destruction paths free struct roccat_device without releasing reports still stored in cbuf[]. This makes those allocations unreachable and leaks up to ROCCAT_CBUF_SIZE report buffers per device. Add a small destructor that frees every buffered report before freeing the device, and use it in both paths that can destroy a registered device. Fixes: 206f5f2fcb5f ("HID: roccat: propagate special events of roccat hardware to userspace") Cc: stable@vger.kernel.org Signed-off-by: Xu Rao Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-roccat.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) --- a/drivers/hid/hid-roccat.c +++ b/drivers/hid/hid-roccat.c @@ -70,6 +70,15 @@ static struct roccat_device *devices[ROC /* protects modifications of devices array */ static DEFINE_MUTEX(devices_lock); +static void roccat_free_device(struct roccat_device *device) +{ + int i; + + for (i = 0; i < ROCCAT_CBUF_SIZE; i++) + kfree(device->cbuf[i].value); + kfree(device); +} + static ssize_t roccat_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) { @@ -226,7 +235,7 @@ static int roccat_release(struct inode * hid_hw_power(device->hid, PM_HINT_NORMAL); hid_hw_close(device->hid); } else { - kfree(device); + roccat_free_device(device); } } @@ -374,7 +383,7 @@ void roccat_disconnect(int minor) hid_hw_close(device->hid); wake_up_interruptible(&device->wait); } else { - kfree(device); + roccat_free_device(device); } } EXPORT_SYMBOL_GPL(roccat_disconnect);